Remove "envoy" support from chromite |
||||||
Issue descriptionI noticed in a CL that we still support envoy_shell in chromite in scripts like scripts/deploy_chrome.py For example, see https://chromium-review.googlesource.com/#/c/394827/ It would be nice to get rid of that.
,
Oct 14 2016
Thanks! No objections here. I think I might've split out some stuff that was shared between Chrome and envoy, so if there are no non-Chrome users now and no plans to add any, maybe that could be simplified again.
,
Oct 14 2016
,
Oct 14 2016
We might want to keep any app_shell stuff, though. (Historical note: envoy_shell was based on app_shell + cast stuff.)
,
Dec 1 2016
Dan, is this something you might want to do as part of other envoy cleanup?
,
Dec 2 2016
Ah, I thought you were already doing it since you asked about running the deploy_chrome tests (isn't that part of chromite?). I can do it if you aren't already working on it.
,
Dec 2 2016
Oh, I got distracted by removing Windows support from ash. If you can take care of it that would be great. If you're busy, assign back to me.
,
Dec 2 2016
,
Dec 2 2016
,
Dec 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f53bd3a75b8ba2feaa79101b011d67a3d4bbe052 commit f53bd3a75b8ba2feaa79101b011d67a3d4bbe052 Author: Daniel Erat <derat@chromium.org> Date: Fri Dec 02 18:28:36 2016 chromite: Remove envoy references. BUG= chromium:656133 TEST=ran deploy_chrome_unittest Change-Id: Ic4672387f414726e92879c51abca96debd76d6ed Reviewed-on: https://chromium-review.googlesource.com/416188 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f53bd3a75b8ba2feaa79101b011d67a3d4bbe052/scripts/deploy_chrome.py [modify] https://crrev.com/f53bd3a75b8ba2feaa79101b011d67a3d4bbe052/cros/test/image_test.py [modify] https://crrev.com/f53bd3a75b8ba2feaa79101b011d67a3d4bbe052/scripts/deploy_chrome_unittest.py [modify] https://crrev.com/f53bd3a75b8ba2feaa79101b011d67a3d4bbe052/lib/chrome_util.py
,
Dec 3 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by steve...@chromium.org
, Oct 14 2016Owner: steve...@chromium.org
Summary: Remove "envoy" support from chromite (was: Remove "envoy" support from chromite deploy scripts)