New issue
Advanced search Search tips

Issue 656119 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Eliminate PageLoad.AbortTiming histograms in UMA dash which show 'No data'

Project Member Reported by bmcquade@chromium.org, Oct 14 2016

Issue description

Related to https://bugs.chromium.org/p/chromium/issues/detail?id=648718 we have some histograms.xml entries that don't actually exist, and thus show 'No data' in the dashboard. This leads to a bad user experience. We should fix this so only histograms that log data show up in the dash.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3fc97108d47f023e6843a15210a7a956c6e18d7

commit e3fc97108d47f023e6843a15210a7a956c6e18d7
Author: bmcquade <bmcquade@chromium.org>
Date: Tue Oct 18 23:45:03 2016

Add support for base histograms in histograms.xml.

A base histogram is a histogram that is intended to be suffixed,
but that shouldn't itself show up in the histogram UI. A base
histogram is conceptually similar to an abstract base class.

The histograms.xml syntax is:
 <histogram base="true" name="PageLoad.AbortTiming.Background" units="ms">

A similar syntax is added for marking suffixes as 'base':
 <suffix base="true" name="AfterPaint.BeforeInteraction"/>

PageLoad.AbortTiming base histograms do not record samples, so we
want to avoid showing them in the UI. To do so, we mark them
as base histograms using the new 'base' histogram attribute.

For now, 'base' histograms are simply marked as 'obsolete' with a
default obsolete reason 'Base histogram. Use suffixes of this
histogram instead.'. In the future, we can consider plumbing the
'base' information through to the UI using a mechanism other than
the 'obsolete' reason, if a reason to do so emerges.

BUG= 656119 

Review-Url: https://codereview.chromium.org/2426473006
Cr-Commit-Position: refs/heads/master@{#426087}

[modify] https://crrev.com/e3fc97108d47f023e6843a15210a7a956c6e18d7/tools/metrics/histograms/extract_histograms.py
[modify] https://crrev.com/e3fc97108d47f023e6843a15210a7a956c6e18d7/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/e3fc97108d47f023e6843a15210a7a956c6e18d7/tools/metrics/histograms/print_style.py

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment