New issue
Advanced search Search tips

Issue 656115 link

Starred by 6 users
Status: Fixed
Owner:
sky@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Bookmarks lost when storing bookmark with unicode character in title

Project Member Reported by elawrence@chromium.org, Oct 14 2016 
Version: 54.40.2840.59
OS: Ubuntu

What steps will reproduce the problem?
(1) Visit https://bayden.com/test/unicodetitle.aspx
(2) Bookmark the page by clicking the Star
(3) Click Done (accepting the default title)
(4) Restart Chrome

Observe: All bookmarks lost

Edit the Bookmarks file in your profile folder to remove the unicode character from the JSON text.

Restart Chrome. Observe: Bookmarks restored.

Not repro on Windows.

Comment 1 by sky@chromium.org, Oct 14 2016

Labels: -Pri-2 Pri-1
Owner: sky@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc7f72dcbc3953587ffe9706601f8d09e8d81481

commit cc7f72dcbc3953587ffe9706601f8d09e8d81481
Author: sky <sky@chromium.org>
Date: Fri Nov 11 01:12:37 2016

Adds option for JSON reader to allow invalid utf characters

This way reading in bookmarks files won't throw out everything if a
bogus utf8 character was written.

BUG= 656115 
TEST=covered by test
R=brettw@chromium.org, stevenjb@chromium.org
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2475583002
Cr-Commit-Position: refs/heads/master@{#431433}

[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/base/json/json_file_value_serializer.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/base/json/json_file_value_serializer.h
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/base/json/json_parser.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/base/json/json_parser.h
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/base/json/json_parser_unittest.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/base/json/json_reader.h
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/base/json/json_string_value_serializer.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/base/json/json_string_value_serializer.h
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/base/json/json_value_serializer_unittest.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/chrome/browser/ui/app_list/start_page_service.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/chromeos/network/onc/onc_test_utils.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/chromeos/network/onc/onc_utils_unittest.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/chromeos/tools/onc_validator/onc_validator.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/components/bookmarks/browser/bookmark_storage.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/components/omnibox/browser/search_suggestion_parser.cc
[modify] https://crrev.com/cc7f72dcbc3953587ffe9706601f8d09e8d81481/components/policy/core/common/config_dir_policy_loader.cc

Comment 3 by sky@chromium.org, Nov 11 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment