New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656109 link

Starred by 41 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Call stack is auto-expanding stepping through code

Reported by mitchell...@sencha.com, Oct 14 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36

Steps to reproduce the problem:
1. Hit a breakpoint
2. Collapse call stack panel (in Sources)
3. Step through code

What is the expected behavior?
The call stack panel should remain collapsed as you step through code.

What went wrong?
The call stack panel expands each time you step through code (does not matter if step into, step out or step over).

Did this work before? Yes 53

Chrome version: 54.0.2840.59  Channel: beta
OS Version: OS X 10.12.0
Flash Version: Shockwave Flash 23.0 r0

Sometimes the call stack is very long making inspecting the local variables and the watch panel go out of view when that is an important piece to observe as you step through code.
 

Comment 1 by caseq@chromium.org, Oct 17 2016

Components: -Platform>DevTools Platform>DevTools>JavaScript
Labels: -OS-Mac OS-All
Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Unconfirmed)
Please fix!

Comment 3 by n...@sencha.com, Oct 18 2016

Also, it's about 2000px wide!
Screen Shot 2016-10-18 at 17.54.13.png
82.0 KB View Download

Comment 4 Deleted

Comment 5 by caseq@chromium.org, Oct 21 2016

Cc: kkaluri@chromium.org
 Issue 658103  has been merged into this issue.
This makes debugging a terrible experience. Please fix.
Thank you!
If this is somehow difficult to fix, is there a way we move the stack block down below the Scope block for the time being?  
Comment #7 - That makes even more sense since there's related information on Watch and Scope. Would vote for that if I could.
user reporting as still issue

and also found these as dupe tickets:
656109, 664121, 661293
call-stack-reopens.gif
278 KB View Download
comment #1 from  Issue 661293 :

Bisect: 411262 (good) - 411270 (bad) released as 54.0.2827.0
https://chromium.googlesource.com/chromium/src/+log/62c31132..6f10f638?pretty=fuller
Suspecting https://crrev.com/2234193002 as the only devtools related change, moreover it actually does add a line of code that expands the Stack panel unconditionally.

Cc: sureshkumari@chromium.org kozyatinskiy@chromium.org
 Issue 661293  has been merged into this issue.
Labels: -Type-Bug -Pri-2 M-56 Pri-1 Type-Bug-Regression

Comment 13 by vlas...@gmail.com, Dec 1 2016

Same here.
Any ETA on fix? This makes devtools super uncomfortable to use.
Also, maybe Scope should be above Call stack, imho it's more useful that way (you'd be able to see both at least some of the time).
Is this just being ignored?  

I work with this daily and it's made debugging the worst part of my day.
#14 - if you want a quick fix, you can always inspect the Developer Tools (press F12, undock, press Control + Shift + J) and add a temporary CSS rule that hides the call stack.
Status: Started (was: Assigned)
https://codereview.chromium.org/2544193002/
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f30067e0b27a6e3899cc57b6f92dfac5215479e

commit 7f30067e0b27a6e3899cc57b6f92dfac5215479e
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Dec 02 03:05:43 2016

[DevTools] Don't expand CallStackSidebarPane on pause if it was collapsed

BUG= 656109 
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2544193002
Cr-Commit-Position: refs/heads/master@{#435839}

[modify] https://crrev.com/7f30067e0b27a6e3899cc57b6f92dfac5215479e/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Labels: Merge-Request-56
Status: Fixed (was: Started)
ETA: fix will be available in Canary tomorrow.

Comment 19 by dimu@chromium.org, Dec 3 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 3 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33b6a683ebb0ac3ea188bf5244f2cd6616babf9a

commit 33b6a683ebb0ac3ea188bf5244f2cd6616babf9a
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Sat Dec 03 18:01:34 2016

[DevTools] Don't expand CallStackSidebarPane on pause if it was collapsed

BUG= 656109 
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2544193002
Cr-Commit-Position: refs/heads/master@{#435839}
(cherry picked from commit 7f30067e0b27a6e3899cc57b6f92dfac5215479e)

Review URL: https://codereview.chromium.org/2552553002 .

Cr-Commit-Position: refs/branch-heads/2924@{#317}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/33b6a683ebb0ac3ea188bf5244f2cd6616babf9a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

 Issue 677539  has been merged into this issue.

Comment 22 by kayce@google.com, Jan 26 2017

Labels: DevTools-Release-Notes-Change
I'm still experiencing this issue in Chrome 62 and Chrome 63 on Ubuntu.

@kozyatin said on dec 02 2016:
> ETA: fix will be available in Canary tomorrow.

should this be in mainline today? Only in Chromium? What version?

@phistuck said on dec 01 2016:
> you can always inspect the Developer Tools (press F12, undock, press Control + Shift + J) and add a temporary CSS rule that hides the call stack.

How would you do that quickly? Without expanding 10 divs? There are no ids on them.
For anyone googling: The lack of ids makes you need to manually inspect the location of the specific part. This works for me, but you might have to edit this.

When opening the inspector on a breakpoint, and that annoying intrusive stack won't stay away, enter this:

1. Ctrl + Shift + J - Open devtools' devtools
2. Esc - Open console
3. document.querySelector('.widget.vbox.insertion-point-sidebar .vbox').querySelectorAll('.vbox')[3].style.display = 'none';

Hope that saves someone 10 minutes.
Also experiencing this on Chrome 61 for mac

Comment 26 by phistuck@gmail.com, Sep 24 2017

#23, #25 - please, file a new issue for it. You can comment here with the new issue number so you do not create two new issues.
I'm not sure there are different developer tools in Chromium because some seem to have the problem and others don't, but there was also a new and/or related bug here:  Issue 766086 
This is still an issue as of August 2018
#29 - please, file a new issue with details such as -
- What are you debugging (Node? Or a Chrome tab)?
- If you are debugging Node, how do you open the Developer Tools ("Open dedicated DevTools for Node" on chrome://inspect? Somehow else?)
- What platform are you using?
- What is your Chrome version?
You can comment here with the new issue number.

Sign in to add a comment