New issue
Advanced search Search tips

Issue 656104 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Support M SDK Accessibility actions in Chrome/WebView

Project Member Reported by dmazz...@chromium.org, Oct 14 2016

Issue description

The M SDK defines these new accessibility actions that we can easily support:

ACTION_CONTEXT_CLICK
ACTION_SHOW_ON_SCREEN
ACTION_SCROLL_UP
ACTION_SCROLL_DOWN
ACTION_SCROLL_LEFT
ACTION_SCROLL_RIGHT

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a08ff35da49a509eb05c3a8ed165565c7ca978d

commit 2a08ff35da49a509eb05c3a8ed165565c7ca978d
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Oct 17 20:41:39 2016

Implement M SDK Android accessibility actions

ACTION_CONTEXT_CLICK
ACTION_SHOW_ON_SCREEN
ACTION_SCROLL_UP
ACTION_SCROLL_DOWN
ACTION_SCROLL_LEFT
ACTION_SCROLL_RIGHT

These were all pretty straightforward as we already supported them
internally.

BUG= 656104 , 483653 

Review-Url: https://codereview.chromium.org/2421013002
Cr-Commit-Position: refs/heads/master@{#425769}

[modify] https://crrev.com/2a08ff35da49a509eb05c3a8ed165565c7ca978d/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/2a08ff35da49a509eb05c3a8ed165565c7ca978d/content/browser/accessibility/browser_accessibility_manager_android.h
[modify] https://crrev.com/2a08ff35da49a509eb05c3a8ed165565c7ca978d/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a08ff35da49a509eb05c3a8ed165565c7ca978d

commit 2a08ff35da49a509eb05c3a8ed165565c7ca978d
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Oct 17 20:41:39 2016

Implement M SDK Android accessibility actions

ACTION_CONTEXT_CLICK
ACTION_SHOW_ON_SCREEN
ACTION_SCROLL_UP
ACTION_SCROLL_DOWN
ACTION_SCROLL_LEFT
ACTION_SCROLL_RIGHT

These were all pretty straightforward as we already supported them
internally.

BUG= 656104 , 483653 

Review-Url: https://codereview.chromium.org/2421013002
Cr-Commit-Position: refs/heads/master@{#425769}

[modify] https://crrev.com/2a08ff35da49a509eb05c3a8ed165565c7ca978d/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/2a08ff35da49a509eb05c3a8ed165565c7ca978d/content/browser/accessibility/browser_accessibility_manager_android.h
[modify] https://crrev.com/2a08ff35da49a509eb05c3a8ed165565c7ca978d/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9e5aa6d8c9b24910dce0ab1de29e045555ba5ec

commit c9e5aa6d8c9b24910dce0ab1de29e045555ba5ec
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Oct 26 17:40:08 2016

Clean up two AccessibilityNodeInfo.addAction APIs

The interface to AccessibilityNodeInfo.addAction changed in the L SDK.
Rather than duplicating a large method twice (and forgetting to keep them
in sync), have one method that adds actions to a node, and a small helper
with two implementations, one for L and one for pre-L.

BUG= 656104 

Review-Url: https://codereview.chromium.org/2453583003
Cr-Commit-Position: refs/heads/master@{#427737}

[modify] https://crrev.com/c9e5aa6d8c9b24910dce0ab1de29e045555ba5ec/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
[modify] https://crrev.com/c9e5aa6d8c9b24910dce0ab1de29e045555ba5ec/content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java

Sign in to add a comment