If prefer HTML5 over Flash is enabled and try to download Flash player doesn't get downloaded. |
||||||||
Issue descriptionVersion: 55.0.2883.11 OS: Windows 10/7 Steps followed : 1. Install and launch Chrome version 55.0.2883.11 2. Enable the flag "Prefer HTML over Flash" from about://flags and relaunch(Non corp machine) 3. Visit Chrome://settings --> Advanced settings --> Content settings --> Flash and make sure we see the option "Ask first Before allowing sites to run flash(recommended)" 4. Visit http://www.adobe.com/go/chrome/ and select Operating system and select "FP 23 for Opera and Chromium -PPAPI" and click on Download 5. Should get an bubble to Run Flash with options "Allow" and "Block" 6. Select "Allow" What is the expected output? Adobe Flash player should get downloaded. What do you see instead? Flash player doesn't get downloaded. Note : After selecting page gets refreshed, If I try to download Flash it gets downloaded.
,
Oct 20 2016
CL at: https://chromiumcodereview.appspot.com/2435933002
,
Oct 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b8d85c37e5a38e8db96c9c7eeb9cad16ee3dfcb commit 4b8d85c37e5a38e8db96c9c7eeb9cad16ee3dfcb Author: raymes <raymes@chromium.org> Date: Sun Oct 23 23:29:20 2016 Don't intercept Flash navigations when the current page is the Flash download page. Currently, with HBD, if you navigate to https://get.adobe.com/flashplayer and click "Download", it will trigger the Run Flash prompt. We should ignore navigations if the source URL is the Flash download page itself. BUG= 656062 Review-Url: https://codereview.chromium.org/2435933002 Cr-Commit-Position: refs/heads/master@{#427005} [modify] https://crrev.com/4b8d85c37e5a38e8db96c9c7eeb9cad16ee3dfcb/chrome/browser/plugins/flash_download_interception.cc [modify] https://crrev.com/4b8d85c37e5a38e8db96c9c7eeb9cad16ee3dfcb/chrome/browser/plugins/flash_download_interception_unittest.cc
,
Oct 24 2016
,
Oct 24 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2d2699a1924d310b1c650a32f951887cfe47139 commit a2d2699a1924d310b1c650a32f951887cfe47139 Author: Raymes Khoury <raymes@chromium.org> Date: Tue Oct 25 02:04:46 2016 Don't intercept Flash navigations when the current page is the Flash download page. Currently, with HBD, if you navigate to https://get.adobe.com/flashplayer and click "Download", it will trigger the Run Flash prompt. We should ignore navigations if the source URL is the Flash download page itself. BUG= 656062 Review-Url: https://codereview.chromium.org/2435933002 Cr-Commit-Position: refs/heads/master@{#427005} (cherry picked from commit 4b8d85c37e5a38e8db96c9c7eeb9cad16ee3dfcb) Review URL: https://codereview.chromium.org/2447983002 . Cr-Commit-Position: refs/branch-heads/2883@{#274} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/a2d2699a1924d310b1c650a32f951887cfe47139/chrome/browser/plugins/flash_download_interception.cc [modify] https://crrev.com/a2d2699a1924d310b1c650a32f951887cfe47139/chrome/browser/plugins/flash_download_interception_unittest.cc
,
Oct 25 2016
,
Oct 26 2016
Verified the issue on windows 7 and Mac 10.11.6 on non-corp machine using chrome beta version #55.0.2883.28 as per the comment #0 Observed that the fix is working as expected. Attaching screencast for reference Hence, adding the verified labels.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2d2699a1924d310b1c650a32f951887cfe47139 commit a2d2699a1924d310b1c650a32f951887cfe47139 Author: Raymes Khoury <raymes@chromium.org> Date: Tue Oct 25 02:04:46 2016 Don't intercept Flash navigations when the current page is the Flash download page. Currently, with HBD, if you navigate to https://get.adobe.com/flashplayer and click "Download", it will trigger the Run Flash prompt. We should ignore navigations if the source URL is the Flash download page itself. BUG= 656062 Review-Url: https://codereview.chromium.org/2435933002 Cr-Commit-Position: refs/heads/master@{#427005} (cherry picked from commit 4b8d85c37e5a38e8db96c9c7eeb9cad16ee3dfcb) Review URL: https://codereview.chromium.org/2447983002 . Cr-Commit-Position: refs/branch-heads/2883@{#274} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/a2d2699a1924d310b1c650a32f951887cfe47139/chrome/browser/plugins/flash_download_interception.cc [modify] https://crrev.com/a2d2699a1924d310b1c650a32f951887cfe47139/chrome/browser/plugins/flash_download_interception_unittest.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by lafo...@chromium.org
, Oct 16 2016