New issue
Advanced search Search tips

Issue 656058 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Flash system install doesn't take precedence over Component Flash install in Chrome.

Project Member Reported by pbomm...@chromium.org, Oct 14 2016

Issue description

Version: 55.0.2883.11
OS: Windows 10/7

What steps will reproduce the problem?
(1) Install and Launch Chrome 
(2) visit "Chrome://Components"
(3) Check updates for Adobe Flash version 
(4) Visit "http://www.adobe.com/go/chrome/"
(5) Select Operating system and select "FP 23 for Opera and Chromium -PPAPI" and download and install

What is the expected output?
Once Flash player is installed System install should take precedence over the already existing component Flash player.

What do you see instead?
Component Flash player is still the default.

Note : I need to check the behavior on Mac  and update the appropriate labels if I see similar behavior.

 

Comment 1 by wfh@chromium.org, Oct 14 2016

By design, system flash will only override a component flash of the same version iff the component flash is detected as being hosted on a network drive, so I think this is WAI.

Comment 2 by wfh@chromium.org, Oct 14 2016

perhaps test with --user-data-dir=SOME NETWORK DRIVE
Hey Will, what would be the implications of switching that ordering?  

There seem to be a few issues where people are having problems w/ the component install (e.g. where the Flash .dll is missing from the component user dir) leaving them in a bad state.  If we preference the system install, that would give us/ gCon a relatively simple remediation (i.e. download Flash here...).


Comment 4 by wfh@chromium.org, Oct 17 2016

If there is no working component install then it will preference the system install. Are you suggesting allowing preference to system install if it's the same version as component?

Comment 5 by wfh@chromium.org, Oct 17 2016

Cc: waff...@chromium.org
I believe that is the suggestion. I don't have any objection to this proposal; do you, Will?

Assuming it SGTY, I can land the code if you are busy.

Comment 7 by wfh@chromium.org, Oct 21 2016

Cc: -waff...@chromium.org wfh@chromium.org
Owner: waff...@chromium.org
yes, I spoke to laforge yesterday about this and I don't see any objection to making system flash preferred over component flash if the system flash version is same or higher.
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

Labels: Merge-Request-55

Comment 11 by dimu@chromium.org, Oct 28 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
If possible could you please merge your change to M55 branch 2883 before monday 4PM PST.
Thank you
**** Bulk edit -  please ignore if not applicable ****

Please merge your change to M55 branch 2883 today before 5:00 PM PT or latest by tomorrow, Tuesday (11/01/16) 4:00 PM PT so we can take it for this week Beta release. 
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 31 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce3939e74844e2610689b5fc56ebb305636adf87

commit ce3939e74844e2610689b5fc56ebb305636adf87
Author: Joshua Pawlicki <waffles@google.com>
Date: Mon Oct 31 17:51:45 2016

Do not replace up-to-date System Flash with Component Flash.

BUG= 656058 
TEST=Cases 1, 3, 5 from https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/edit#heading=h.pe0xr0h8vcrv

Review-Url: https://codereview.chromium.org/2434103005
Cr-Commit-Position: refs/heads/master@{#428205}
(cherry picked from commit 151a7690b7312bed56784b8b953cce11e03a1085)

Review URL: https://codereview.chromium.org/2463913002 .

Cr-Commit-Position: refs/branch-heads/2883@{#385}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/ce3939e74844e2610689b5fc56ebb305636adf87/base/files/file_util.h
[modify] https://crrev.com/ce3939e74844e2610689b5fc56ebb305636adf87/base/files/file_util_unittest.cc
[modify] https://crrev.com/ce3939e74844e2610689b5fc56ebb305636adf87/base/files/file_util_win.cc
[modify] https://crrev.com/ce3939e74844e2610689b5fc56ebb305636adf87/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/ce3939e74844e2610689b5fc56ebb305636adf87/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/ce3939e74844e2610689b5fc56ebb305636adf87/chrome/common/chrome_content_client_unittest.cc
[modify] https://crrev.com/ce3939e74844e2610689b5fc56ebb305636adf87/content/public/common/pepper_plugin_info.cc
[modify] https://crrev.com/ce3939e74844e2610689b5fc56ebb305636adf87/content/public/common/pepper_plugin_info.h

Status: Fixed (was: Started)
Based on activity, marking as Fixed.  Please re-open as needed.

Sign in to add a comment