The logic in git_cl.py needs to be fixed.
Sent out for review https://codereview.chromium.org/2419123002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c9ebbd24639c8fb9f7fd2a36032614830e1e5285 commit c9ebbd24639c8fb9f7fd2a36032614830e1e5285 Author: rmistry <rmistry@google.com> Date: Fri Oct 14 19:35:54 2016 Fix logic to detect Gerrit CL in CQ BUG= chromium:656042 Review-Url: https://codereview.chromium.org/2419123002 [modify] https://crrev.com/c9ebbd24639c8fb9f7fd2a36032614830e1e5285/git_cl.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/69fc06f12bb5fc602161bd2169cb54a03fe5634b commit 69fc06f12bb5fc602161bd2169cb54a03fe5634b Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Oct 14 19:44:46 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/c9ebbd24639c8fb9f7fd2a36032614830e1e5285 Fix logic to detect Gerrit CL in CQ (rmistry@google.com) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= chromium:656042 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2423523002 [modify] https://crrev.com/69fc06f12bb5fc602161bd2169cb54a03fe5634b/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/9c9bce00b1ab5145480234aad8c09e419f21e7bc commit 9c9bce00b1ab5145480234aad8c09e419f21e7bc Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Oct 14 20:05:56 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/69fc06f12bb5fc602161bd2169cb54a03fe5634b Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/c9ebbd24639c8fb9f7fd2a36032614830e1e5285 Fix logic to detect Gerrit CL in CQ (rmistry@google.com) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= chromium:656042 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2423533002 [modify] https://crrev.com/9c9bce00b1ab5145480234aad8c09e419f21e7bc/infra/config/recipes.cfg
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/b3997f765c70237826b43ac3e9380aaf6f995fad commit b3997f765c70237826b43ac3e9380aaf6f995fad Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Oct 17 17:29:11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/829daf60e51ee9e6c78bea29918def500427ac76 commit 829daf60e51ee9e6c78bea29918def500427ac76 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Oct 17 22:31:12 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/69fc06f12bb5fc602161bd2169cb54a03fe5634b Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/61728af22d26f33d09ed715d0c43f6051ee9c1ea Fix compile on the Blimp Client Engine Integration bot (shenghuazhang@chromium.org) https://crrev.com/f7b18bcd210f254d4b61c92b2a94942fe9b83927 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/dd839c91b9b2e7f1b45683dfe1e7ac68f01157a6 Modify 'build_dir' for run_mb() to avoid double 'Debug' (shenghuazhang@chromium.org) https://crrev.com/7eea10901de0274a5be22fdf6479e1109582900a Skia trigger recipe: change remote recipe condition (borenet@chromium.org) https://crrev.com/0b094b378658afa9436b1107859128456cd1c08d Add GomaCanaryiOS to chromium.fyi (smut@google.com) https://crrev.com/97367d4e07794d107d6075ff86ce898631169e73 Add option to use goma module in chromium.compile (tikuta@chromium.org) https://crrev.com/d44afde07794016523aceefdd1de603fc2f75459 V8: Run simple-leak-check step on release and trybot (machenbach@chromium.org) https://crrev.com/92dfa57e7376ea9ee60ce378cf16ae290cd9aea3 V8: Bump timeout on arm64 sim nosnap (machenbach@chromium.org) https://crrev.com/6b546c5afd0b236ef02e3dfb029d2d630582786c Revert of V8: Run simple-leak-check step on release and trybot (patchset #1 id:1 of https://codereview.chromium.org/2415243003/ ) (machenbach@chromium.org) https://crrev.com/94aa3062f0f4cc2542d375cf45706c7e2742c714 libyuv: Switch bots over to GN by default. (kjellander@chromium.org) https://crrev.com/ab47d254ddf187fa3b3c0231ea1882557b589f7b Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/3d9ee695a52c6ea7c00b60ae7ce8de03bbf626ed libyuv: Switch {client,tryserver}.libyuv to GN (kjellander@chromium.org) https://crrev.com/ded9582695d74387b613dcbcad04936bff12d88b libyuv: Disable signing for iOS (kjellander@chromium.org) https://crrev.com/1a9cedbf5751bb8b7d4a59ef43f9618b87b0b97f Updating flags necessary for upload_perf_dashboard_results.py (eyaich@chromium.org) https://crrev.com/1088f8337678d51a96fa44917bc9efc64270b0e4 Add the Syzygy x64 bots to the Syzygy waterfall. (sebmarchand@chromium.org) https://crrev.com/7ae96413206814a587e3e5921017762be6257983 Use the Chromium-side script to run the PGO benchmarks. (sebmarchand@chromium.org) https://crrev.com/02bbb17974a70e1bb198ee4243d830ff258d1bb8 Add IGNORE_DEPS_CHANGES flag and coverage builder. (dnj@chromium.org) https://crrev.com/78c3859a73773c4d7eff4ed38c796c147bae998c Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/c0b4818f62ae008fa858794ac278ce7f65cdf92d In archive_layout_test_results, only support archiving to GS. (qyearsley@chromium.org) https://crrev.com/65dc88015fad41b08d59d3f47ce157c3d5f8b051 V8: Add valgrind deps to linux64 bots (machenbach@chromium.org) https://crrev.com/9f623ff560eeca917efb9b799a1ca3137f9dcaa0 Revert of Add IGNORE_DEPS_CHANGES flag and coverage builder. (patchset #3 id:40001 of https://codereview.chromium.org/2418233002/ ) (dnj@chromium.org) https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0 Remove use of "use_mirror" recipe property. (dnj@chromium.org) https://crrev.com/13c03fad59862d90b2b6bb2372a37ab414074228 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/2d442327bbfad0eb211466afbfe2f5a17c4561da Stop archiving redundant copy of {full,failing}_results.json. (qyearsley@chromium.org) https://crrev.com/506376486f9bd8973f5b96a02eddd449a3ef52e2 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/c9ebbd24639c8fb9f7fd2a36032614830e1e5285 Fix logic to detect Gerrit CL in CQ (rmistry@google.com) https://crrev.com/1dbb595dbfa4ebf73ee036cd66275af24253a99d Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/48df58136dc1847cd158eaa330f5dd457265d654 Gerrit git cl: make it work with minimal file. (tandrii@chromium.org) https://crrev.com/d437d76b64e083f2fb2ff3a7b38638d06642e270 Reland "Remove SVN and File support from gclient" (agable@chromium.org) https://crrev.com/aa9e16acd4e74f35dc738b98cd03b2c0b30bfefb Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/1c822ade1f731ec35a3d2d3be8805f773df22c4c Roll recipe dependencies (trivial). (recipe-roller@chromium.org) recipe_engine: https://crrev.com/a15c8474d308784e94fe4e15deb7c7860d717059 Reland: Add post_process hooks to recipe testing facilities. (iannucci@chromium.org) https://crrev.com/7076377b62701f77783d2d5e002fe2708ffab273 Fix VerifySubset when comparing empty lists (martiniss@chromium.org) https://crrev.com/bb6caf8060139fd4bcefee43f54ae00150e7ce3a Remove 'use_mirror' and 'root' properties. (dnj@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 656555 , chromium:656741 ,654806, chromium:656731 ,641588,chromium:633253, 656573 , 655810 , chromium:652188 , 655864 ,chromium:648308, chromium:656042 , 309849 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2422383003 Cr-Commit-Position: refs/heads/master@{#425793} [modify] https://crrev.com/829daf60e51ee9e6c78bea29918def500427ac76/infra/config/recipes.cfg
Comment 1 by rmis...@google.com
, Oct 14 2016