New issue
Advanced search Search tips

Issue 656041 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

isolate tests failing on chromium.win/Win Builder

Project Member Reported by joedow@chromium.org, Oct 14 2016

Issue description

isolate tests failing on chromium.win/Win Builder

Type: build-failure

Builders failed on: 
- Win Builder: 
  https://build.chromium.org/p/chromium.win/builders/Win%20Builder

It looks like the uploads are failing (example failure from log):
09:38:02.498053 Task failed, retrying after a sleep of 100ms: http request failed: Internal Server Error (HTTP 500)
 

Comment 1 by joedow@chromium.org, Oct 14 2016

Also note, I see this same failure on the Webkit builder (500 error when uploading the isolate file(s))

Comment 2 by iannu...@google.com, Oct 14 2016

Cc: vadimsh@chromium.org mar...@chromium.org
I just looked at the appengine console and I don't SEE a spike in 500s, but I'm sure there's a better way to analyze this. + some isolate ppl.

Comment 3 by iannu...@google.com, Oct 14 2016

Next build passed: https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/30659

I think this was just appengine flake (grrrr), but if we can figure it out more precisely that would be good.

Comment 4 by d...@chromium.org, Oct 14 2016

The functional error is:

09:25:07.000581 Task failed, retrying after a sleep of 100ms: http request failed: Internal Server Error (HTTP 500)

Looks like flake to me. However, iannucci@ noted we're not doing exponential backoff here, which is a bug.

Comment 5 by iannu...@google.com, Oct 17 2016

Status: Fixed (was: Available)
My read of the code from the current isolate client is that it should always retry. It looks like this build was done with the old isolate binary which doesn't have this logic. There's another effort to bring the isolate client up to date though, so this should be fixed in the future.

Sign in to add a comment