New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 656035 link

Starred by 1 user
Status: Fixed
Owner:
█ wnwen@chromium.org
OOO until Feb 4th
Closed: Jan 2017
Cc:
dominickn@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 398264



Sign in to add a comment

StrictMode violation in WebappRegistry

Project Member Reported by wnwen@chromium.org, Oct 14 2016 
This is Android N specific.

10-14 12:17:28.152 20966 20966 D StrictMode: StrictMode policy violation; ~duration=6 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=17891359 violation=2
10-14 12:17:28.152 20966 20966 D StrictMode:    at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1293)
10-14 12:17:28.152 20966 20966 D StrictMode:    at java.io.UnixFileSystem.checkAccess(UnixFileSystem.java:249)
10-14 12:17:28.152 20966 20966 D StrictMode:    at java.io.File.exists(File.java:780)
10-14 12:17:28.152 20966 20966 D StrictMode:    at android.app.ContextImpl.ensurePrivateDirExists(ContextImpl.java:512)
10-14 12:17:28.152 20966 20966 D StrictMode:    at android.app.ContextImpl.getPreferencesDir(ContextImpl.java:468)
10-14 12:17:28.152 20966 20966 D StrictMode:    at android.app.ContextImpl.getSharedPreferencesPath(ContextImpl.java:627)
10-14 12:17:28.152 20966 20966 D StrictMode:    at android.app.ContextImpl.getSharedPreferences(ContextImpl.java:345)
10-14 12:17:28.152 20966 20966 D StrictMode:    at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:164)
10-14 12:17:28.152 20966 20966 D StrictMode:    at org.chromium.chrome.browser.webapps.WebappRegistry.<init>(WebappRegistry.java:2263)
10-14 12:17:28.152 20966 20966 D StrictMode:    at org.chromium.chrome.browser.webapps.WebappRegistry.getInstance(WebappRegistry.java:69)
10-14 12:17:28.152 20966 20966 D StrictMode:    at org.chromium.chrome.browser.DeferredStartupHandler$2.run(DeferredStartupHandler.java:179)
10-14 12:17:28.152 20966 20966 D StrictMode:    at org.chromium.chrome.browser.DeferredStartupHandler$1.queueIdle(DeferredStartupHandler.java:117)
10-14 12:17:28.152 20966 20966 D StrictMode:    at android.os.MessageQueue.next(MessageQueue.java:392)
10-14 12:17:28.152 20966 20966 D StrictMode:    at android.os.Looper.loop(Looper.java:136)
10-14 12:17:28.152 20966 20966 D StrictMode:    at android.app.ActivityThread.main(ActivityThread.java:6088)
10-14 12:17:28.152 20966 20966 D StrictMode:    at java.lang.reflect.Method.invoke(Native Method)
10-14 12:17:28.152 20966 20966 D StrictMode:    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
10-14 12:17:28.152 20966 20966 D StrictMode:    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f21ab9c1569a73162ed57c7f09dc7d7e1ec80e24

commit f21ab9c1569a73162ed57c7f09dc7d7e1ec80e24
Author: wnwen <wnwen@chromium.org>
Date: Fri Oct 21 17:16:29 2016

Move WebappRegistry warmup to async task.

On Android N the constructor results in a StrictMode violation due to
WebappRegistry#openSharedPreferences. Use initialization on demand
holder idiom to avoid synchronization issues.

BUG= 656035 

Review-Url: https://chromiumcodereview.appspot.com/2421833003
Cr-Commit-Position: refs/heads/master@{#426823}

[modify] https://crrev.com/f21ab9c1569a73162ed57c7f09dc7d7e1ec80e24/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[modify] https://crrev.com/f21ab9c1569a73162ed57c7f09dc7d7e1ec80e24/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java

Comment 2 by wnwen@chromium.org, Jan 4 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment