Doppler PannerNode deprecation claims removal in 55 |
|||||||||
Issue descriptionLike my issue 654978 , this is another deprecation which still claims removal will be in 55. Actual removal happened in M56 in issue 439644 . Ideally the deprecation message should be updated on the branch to make it clear that removal will be happening in M56. See also discussion in https://codereview.chromium.org/2412423003/
,
Oct 14 2016
,
Oct 14 2016
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964 commit ae7cb4eda8449b71c3fb1c9860dcaebf8d707964 Author: Rick Byers <rbyers@chromium.org> Date: Fri Oct 14 16:43:54 2016 Punt touch UGI and doppler deprecations to M56 Cherry pick and also update the doppler warning to M56 (which was removed from trunk already so can't be merged). BUG= 654978 , 656030 Review-Url: https://codereview.chromium.org/2408203004 Cr-Commit-Position: refs/heads/master@{#424739} (cherry picked from commit 5228ba9c95482de8e3615f189bcf822806e99010) R=rtoy@chromium.org Review URL: https://codereview.chromium.org/2422673002 . Cr-Commit-Position: refs/branch-heads/2883@{#109} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/webaudio/doppler-deprecated-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/Source/core/frame/Deprecation.cpp
,
Oct 14 2016
,
Oct 14 2016
,
Oct 18 2016
Verified the issue 654978 on Windows-10 and observed it's working as expected. rbyers@ - Could you please confirm is this issue is same as 654978 or any other repo steps available ? If yes, could you please provide them to verify it from Chrome-TE end. Thanks!
,
Oct 18 2016
No, this bug is similar but the repro steps are different - sorry for not including them when filing the bug. To repo load http://output.jsbin.com/gokuto which does: var c = new AudioContext(); var f = c.listener.dopplerFactor; f = c.listener.speedOfSound; And open the devtools console. Prior to this fix you'd see the following warnings: gokuto:21 'AudioListener.dopplerFactor' is deprecated and will be removed in M55, around December 2016. It has no effect as the Web Audio doppler effects have already been removed internally. See https://www.chromestatus.com/features/5238926818148352 for more details. (anonymous) @ gokuto:21 gokuto:22 'AudioListener.speedOfSound' is deprecated and will be removed in M55, around December 2016. It has no effect as the Web Audio doppler effects have already been removed internally. See https://www.chromestatus.com/features/5238926818148352 for more details. With this fix instead of "M55, around December 2016" you will see "M56, around January 2017".
,
Oct 18 2016
Verified the fix on Windows 7/10, Mac and Linux with Chrome version 55.0.2883.19, Please find the screenshot for reference.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964 commit ae7cb4eda8449b71c3fb1c9860dcaebf8d707964 Author: Rick Byers <rbyers@chromium.org> Date: Fri Oct 14 16:43:54 2016 Punt touch UGI and doppler deprecations to M56 Cherry pick and also update the doppler warning to M56 (which was removed from trunk already so can't be merged). BUG= 654978 , 656030 Review-Url: https://codereview.chromium.org/2408203004 Cr-Commit-Position: refs/heads/master@{#424739} (cherry picked from commit 5228ba9c95482de8e3615f189bcf822806e99010) R=rtoy@chromium.org Review URL: https://codereview.chromium.org/2422673002 . Cr-Commit-Position: refs/branch-heads/2883@{#109} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/LayoutTests/webaudio/doppler-deprecated-expected.txt [modify] https://crrev.com/ae7cb4eda8449b71c3fb1c9860dcaebf8d707964/third_party/WebKit/Source/core/frame/Deprecation.cpp
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rbyers@chromium.org
, Oct 14 2016Owner: rbyers@chromium.org
Status: Started (was: Unconfirmed)