New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656030 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 439644

Blocking:
issue 655873



Sign in to add a comment

Doppler PannerNode deprecation claims removal in 55

Project Member Reported by rbyers@chromium.org, Oct 14 2016

Issue description

Like my  issue 654978 , this is another deprecation which still claims removal will be in 55.  Actual removal happened in M56 in  issue 439644 .  Ideally the deprecation message should be updated on the branch to make it clear that removal will be happening in M56.

See also discussion in https://codereview.chromium.org/2412423003/
 

Comment 1 by rbyers@chromium.org, Oct 14 2016

Cc: rtoy@chromium.org
Owner: rbyers@chromium.org
Status: Started (was: Unconfirmed)
Actually I need to do a manual merge now for  issue 654978  - I can just as easily punt this to M56 myself at the same time.

Comment 2 by rbyers@chromium.org, Oct 14 2016

Labels: -OS-Linux OS-All

Comment 3 by rbyers@chromium.org, Oct 14 2016

Labels: M-55

Comment 5 by rbyers@chromium.org, Oct 14 2016

Status: Fixed (was: Started)

Comment 6 by rbyers@chromium.org, Oct 14 2016

Blocking: 655873
Cc: brajkumar@chromium.org
Labels: Needs-Feedback
Verified the  issue 654978  on Windows-10 and observed it's working as expected.
	
rbyers@ - Could you please confirm is this issue is same as 654978 or any other repo steps available ? If yes, could you please provide them to verify it from Chrome-TE end.

Thanks!

Comment 8 by rbyers@chromium.org, Oct 18 2016

No, this bug is similar but the repro steps are different - sorry for not including them when filing the bug.

To repo load http://output.jsbin.com/gokuto which does:

var c = new AudioContext();
var f = c.listener.dopplerFactor;
f = c.listener.speedOfSound;

And open the devtools console.  Prior to this fix you'd see the following warnings:

gokuto:21 'AudioListener.dopplerFactor' is deprecated and will be removed in M55, around December 2016. It has no effect as the Web Audio doppler effects have already been removed internally. See https://www.chromestatus.com/features/5238926818148352 for more details.
(anonymous) @ gokuto:21
gokuto:22 'AudioListener.speedOfSound' is deprecated and will be removed in M55, around December 2016. It has no effect as the Web Audio doppler effects have already been removed internally. See https://www.chromestatus.com/features/5238926818148352 for more details.

With this fix instead of "M55, around December 2016" you will see "M56, around January 2017".
Verified the fix on Windows 7/10, Mac and Linux with Chrome version 55.0.2883.19, Please find the screenshot for reference.
656030.png
231 KB View Download

Comment 11 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 12 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment