New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656028 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 581728
issue 616411


Participants' hotlists:
Media-UI


Sign in to add a comment

Refine the scoring of MediaImage

Project Member Reported by zqzh...@chromium.org, Oct 14 2016

Issue description

Should we give a score penalty for non-square images?

What's the proper image size upper bound? Should it be density-dependent or independent?
 
Blocking: 581728
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76252384438261f0c575e22296d5776a7e7f4f47

commit 76252384438261f0c575e22296d5776a7e7f4f47
Author: zqzhang <zqzhang@chromium.org>
Date: Mon Oct 31 12:37:11 2016

Improving non-square large icon in MediaNotification

This CL improves non-square large icon in MediaNotification by:
* Giving penalty score to non-square image.
* Rescalling non-square image while keeping the aspect ratio
  (paddings added).

BUG= 656028 

Review-Url: https://codereview.chromium.org/2462703002
Cr-Commit-Position: refs/heads/master@{#428691}

[modify] https://crrev.com/76252384438261f0c575e22296d5776a7e7f4f47/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java
[modify] https://crrev.com/76252384438261f0c575e22296d5776a7e7f4f47/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/76252384438261f0c575e22296d5776a7e7f4f47/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

Labels: -M-56 M-58
Status: Fixed (was: Assigned)
I think this bug can be marked as fixed unless someone complain on the current situation.

Sign in to add a comment