maintain device mode zoom and orientation when switching between devices
Reported by
kaycebas...@gmail.com,
Oct 14 2016
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2889.0 Safari/537.36 Steps to reproduce the problem: 1. view a page in device mode 2. select "Galaxy S5" 3. change orientation to landscape 4. select "Nexus 5X" What is the expected behavior? zoom stays at 100% and orientation stays in landscape What went wrong? zoom changes to 75% and orientation reverts to portrait Did this work before? N/A Chrome version: 56.0.2889.0 Channel: canary OS Version: OS X 10.11.6 Flash Version: Shockwave Flash 23.0 r0 I didn't test all permutations. Weirdly enough, when you switch to "iPhone 6", it switches back to the correct configuration
,
Oct 14 2016
,
Oct 17 2016
Eric, could you please take a look?
,
Oct 18 2016
,
Oct 20 2016
There is now a CL in review to make orientation preserved across switching devices! https://codereview.chromium.org/2431823002/ For zoom preservation, I think this is less clear to me. The current fit-to-window logic supports devs who want to see the entire device. This makes it easy to quickly see how a site looks overall, especially when switching between phone/tablets. Please help us understand if there's a strong use case to make zoom preserved as well. We can also see if there are more stars / opinions for turning off auto-fit-to-window.
,
Oct 20 2016
My original tweet was only about zoom, not about the device orientation. When I'm trying to check that the elements are right, for me it's much better a 100% view instead of a zoomed blurry view where I can't check things correctly. I doubt that this issue would get many starts because I don't think that the most of the developers will even find it to step up and agree or disagree with it. The best solution would be something "intelligent", like remember the last option that the user has selected in the zoom combo instead of resetting it (ie: don't reset to neither 100% or autozoom), or even remember the zoom factor of each device. Surely there are correct use cases for both autozoom and 100% zoom, so any solution that forces one of them will cause pain for the developers that want the other situation. At the moment I think that remembering zoom and rotation of each device might be the best solution.
,
Oct 20 2016
Sounds good to me. I'll update the CL with last-zoom-for-device, where each device remembers the last zoom it used.
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f65c9f608caeade772dd9ae7845ed71d2bc4e10a commit f65c9f608caeade772dd9ae7845ed71d2bc4e10a Author: luoe <luoe@chromium.org> Date: Tue Oct 25 00:54:13 2016 DevTools: device mode devices remember last used zoom Before, switching devices in Device Mode would set the zoom scale to fit the window. Now, devices will remember their last used mode. BUG= 656020 Review-Url: https://codereview.chromium.org/2431823002 Cr-Commit-Position: refs/heads/master@{#427196} [add] https://crrev.com/f65c9f608caeade772dd9ae7845ed71d2bc4e10a/third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-switching-devices-expected.txt [add] https://crrev.com/f65c9f608caeade772dd9ae7845ed71d2bc4e10a/third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-switching-devices.html [add] https://crrev.com/f65c9f608caeade772dd9ae7845ed71d2bc4e10a/third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-test.js [modify] https://crrev.com/f65c9f608caeade772dd9ae7845ed71d2bc4e10a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js [modify] https://crrev.com/f65c9f608caeade772dd9ae7845ed71d2bc4e10a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
,
Oct 25 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kaycebas...@gmail.com
, Oct 14 2016