New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 656008 link

Starred by 2 users
Status: Fixed
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: Nov 2016
Cc:
█ rachelis@chromium.org
█ nepper@chromium.org
treib@chromium.org
fi...@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 655992


Sign in to add a comment

[Tracking bug] Empty state support for remote sections

Project Member Reported by dgn@chromium.org, Oct 14 2016 
Known categories have (or should have) defined strings and handlers for the status card, that are hardcoded in the client.

Section titles are sent by the backend, and for remote sections, we can receive them from the server.

So some data is missing for "unknown" sections:

- Description for the empty step card
   * TODO: Have a default description
   * TODO: The description should be sent by the backend, through category_info
- Action for the MORE button
   * TODO: Allow fetching suggestions for a specific category. Will probably be addressed through issue 634892.
   * MAYBE: Support omitting the action button.

+nepper@, rachelis@ for defining the description strings. We currently only have some for ARTICLES and BOOKMARKS.
+nepper@: is having optional action buttons on the empty state card something we might need? Also, would we need it to do something different from fetching new suggestions?

Comment 1 by dgn@chromium.org, Oct 14 2016

Labels: zine-16-10-17

Comment 2 by treib@chromium.org, Oct 17 2016

Labels: M-56

Comment 3 by fi...@chromium.org, Oct 17 2016

Labels: -zine-client-v1 zine-client-ux-v1 zine-triaged

Comment 4 by rachelis@chromium.org, Oct 17 2016 

Please don't redefine any sections which are already defined (articles for you, bookmarks, recents, etc). But for generic sections that we're not currently aware of, let's use the strings:

[title] That’s all for now
[description] Your suggestions will appear here.

https://docs.google.com/presentation/d/1IT0NPdbZqV_uumideOjv9IuEjyqpDHfEWYZkXjSlTdA/edit#slide=id.g127ed73201_1_149

Comment 5 by dgn@chromium.org, Oct 17 2016 

Update: The description string will be: "Your suggestions appear here"

Comment 7 by rachelis@google.com, Oct 24 2016

Labels: -zine-ux

Comment 8 by dgn@chromium.org, Oct 24 2016 

Issue 657652 has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8a8ed14c688ed2a049e0e10cce036df3f6457cb

commit c8a8ed14c688ed2a049e0e10cce036df3f6457cb
Author: treib <treib@chromium.org>
Date: Wed Oct 26 17:33:51 2016

[NTP Snippets] Pass "no suggestions" message from the backend to the UI

BUG= 656008 

Review-Url: https://codereview.chromium.org/2447163004
Cr-Commit-Position: refs/heads/master@{#427733}

[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/components/ntp_snippets/category_info.cc
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/components/ntp_snippets/category_info.h
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/components/ntp_snippets/content_suggestions_service_unittest.cc
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/components/ntp_snippets/remote/ntp_snippets_service.cc
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
[modify] https://crrev.com/c8a8ed14c688ed2a049e0e10cce036df3f6457cb/components/ntp_snippets_strings.grdp

Comment 10 Deleted

Comment 11 by nepper@chromium.org, Oct 27 2016 

Sorry, the previous comment was off topic :)

So far I am only aware of the need for a MORE button which would fetch additional server-side sections.

Non-blocking: Allowing the server to define in the response if a MORE button should be displayed again would be nice to avoid showing a MORE button when no additional suggestions can be provided by the server (is FCS capable of telling us if more suggestions will be available?)

Comment 12 by treib@chromium.org, Nov 15 2016 

I think this is basically fixed with https://codereview.chromium.org/2463133002/ ?

Comment 13 by dgn@chromium.org, Nov 15 2016

Status: Fixed (was: Assigned)
Yes, we can close this.
►

Sign in to add a comment