Issue metadata
Sign in to add a comment
|
[M-55] Sending metrics is disabled on ARC++ start up |
||||||||||||||||||||||
Issue descriptionVersion: ToT OS: ChromeOS How to reproduce. 0) Verify ARC++ is disabled. 1) Open "chrome://settings" and click "Advanced settings" 2) Check "Automatically send diagnostic and usage data to Google" 3) Enable ARC++ and open the ToS page. 3.5) Make sure the check box for the metrics is hidden. 4) Press "Agree" 5) Reload "chrome://settings" Expected behavior: - "Automatically send diagnostic and usage data to Google" is kept checked. Actual behavior: - It is unchecked. The root cause is my mistake in crrev.com/2388763002. L518 isMetricsEnabled: !enableMetrics.hidden && enableMetrics.checked, was wrong. If the metrics setting is already enabled, the metrics is hidden. Thus, it sends "false" for the isMetricsEnabled and then the metrics is disabled. Unfortunately this was in M55 release branch, so the cherry-pick fix is needed for M-55 release.
,
Oct 17 2016
,
Oct 17 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/486eb87a797721af37ed1632754d64bd5df66a51 commit 486eb87a797721af37ed1632754d64bd5df66a51 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Wed Oct 19 03:54:05 2016 Fix unexpected metrics preference resetting. Currently, if metrics preference is already enabled on arc_support extension starting, then the checkbox is hidden. Thus, isMetricsEnabled=false is sent onAgree and then it is disabled un-intentionally. This CL fixes the bug. BUG= 656006 , b/32132303 TEST=Ran on test device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2413203003 Cr-Commit-Position: refs/heads/master@{#425334} (cherry picked from commit 6ecec1dcd1856abc9b37d94a460c4f96e047e5ba) Review URL: https://codereview.chromium.org/2427403002 . Cr-Commit-Position: refs/branch-heads/2883@{#185} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/486eb87a797721af37ed1632754d64bd5df66a51/chrome/browser/resources/chromeos/arc_support/background.js
,
Oct 20 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/486eb87a797721af37ed1632754d64bd5df66a51 commit 486eb87a797721af37ed1632754d64bd5df66a51 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Wed Oct 19 03:54:05 2016 Fix unexpected metrics preference resetting. Currently, if metrics preference is already enabled on arc_support extension starting, then the checkbox is hidden. Thus, isMetricsEnabled=false is sent onAgree and then it is disabled un-intentionally. This CL fixes the bug. BUG= 656006 , b/32132303 TEST=Ran on test device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2413203003 Cr-Commit-Position: refs/heads/master@{#425334} (cherry picked from commit 6ecec1dcd1856abc9b37d94a460c4f96e047e5ba) Review URL: https://codereview.chromium.org/2427403002 . Cr-Commit-Position: refs/branch-heads/2883@{#185} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/486eb87a797721af37ed1632754d64bd5df66a51/chrome/browser/resources/chromeos/arc_support/background.js
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Jan 24 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 14 2016