New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 656000 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
pkasting@chromium.org
█ fbarchard@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

blink_tests doesn't build with is_ubsan = true because of protobuf overflows

Project Member Reported by dominicc@chromium.org, Oct 14 2016 
At ToT (r425305) I can't build blink_tests with is_ubsan = true [1] because of protobuf:

[8970/26961] ACTION //cc/proto:proto_i...gen(//build/toolchain/linux:clang_x64)
../../third_party/protobuf/src/google/protobuf/stubs/strutil.cc:984:17: runtime error: signed integer overflow: 42 * 100000000 cannot be represented in type 'int'
[9037/26961] ACTION //components/metri...gen(//build/toolchain/linux:clang_x64)
../../third_party/protobuf/src/google/protobuf/stubs/strutil.cc:984:17: runtime error: signed integer overflow: 42 * 100000000 cannot be represented in type 'int'
[9089/26961] ACTION //components/polic...gen(//build/toolchain/linux:clang_x64)
../../third_party/protobuf/src/google/protobuf/stubs/strutil.cc:984:17: runtime error: signed integer overflow: 42 * 100000000 cannot be represented in type 'int'
[9138/26961] ACTION //components/sync/...gen(//build/toolchain/linux:clang_x64)
../../third_party/protobuf/src/google/protobuf/stubs/strutil.cc:984:17: runtime error: signed integer overflow: 42 * 100000000 cannot be represented in type 'int'

[1] <https://www.chromium.org/developers/testing/undefinedbehaviorsanitizer>

Comment 1 by pkasting@chromium.org, Oct 14 2016

Status: Available (was: Unconfirmed)
This looks to me like a bug in the upstream code.  I think |digits| needs to be changed to a uint32, and that alone may fix this.  I suggest testing that, and if it fixes the problem, sending a PR to https://github.com/google/protobuf .  We can patch locally or (better) pull down the new version to get the change.
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 16 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by thomasanderson@chromium.org, Jan 13 2018

Status: Fixed (was: Untriaged)
Looks like |digits| is now uint32.  Presumably this has been fixed upstream, and was pulled in the latest protobuf roll.  Also, I haven't seen this whenever I do a ubsan build, so I'm closing this issue.  If the issue still persists, plmk so I can reopen.
►

Sign in to add a comment