New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655984 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Buried. Ping if important.
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Regression:Weird flickering is seen after clicking in the text box for "www.verywell.com"

Reported by adha...@etouch.net, Oct 14 2016

Issue description

Chrome version:56.0.2890.0 (Official Build) canary b2c7e72483b4fa50df162b9f38f0270c3079aad9-refs/heads/master@{#425218}(32/64-bit)
OS:Windows(7,8,10)

TEST URL:https://www.verywell.com/

What steps will reproduce the problem?
(1)Launch chrome and navigate to the above url.
(2)Scroll down to "Daily Health Tips To Your Inbox" on L.H.S.
(3)Sign up using any two email id's.(Kindly refer the video)
(4)Now click in the text box 4-5 times and observe.

Actual:Weird flickering is seen after clicking in the text box.

Expected:No such flickering should be seen clicking in the text box.

This is a Regression issue broken in M-56,will soon update other info.

Good build:56.0.2886.0
Bad build:56.0.2888.0

Note:Above issue is not seen on Linux and Mac OS.
 
Actual result.mp4
577 KB View Download
Expected result.mp4
209 KB View Download

Comment 1 by adha...@etouch.net, Oct 14 2016

Status: Unconfirmed (was: Untriaged)
Cc: atimo...@yandex-team.ru
Labels: hasbisect-per-revision
Owner: sky@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2886.0(Revision:424099).
Bad build: 56.0.2888.0 (Revision:424625).

You are probably looking for a change made after 424122 (known good), but no later than 424123 (first known bad).

CHANGELOG URL:
-----------------   https://chromium.googlesource.com/chromium/src/+log/136a7131948b4adc886e8da7ddfac54c2ae8b1b8..6bb7f81927671c8616a89ad235d797159724cf09

From the CL above, assigning the issue to the concern owner 

Note: Unable find the authors name in the owners list so assigning to the reviewer of the file more more updates. 

@sky - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Thanks!

Comment 3 by sky@chromium.org, Oct 14 2016

Owner: brajkumar@chromium.org
I don't believe it's related. The flickering is in content, so I would look through the changelog for recent changes to blink. Although cc changes could impact this as well. None-the-less I'm not a good owner.

Comment 4 by e...@chromium.org, Oct 18 2016

Labels: -Pri-1 -Type-Bug-Regression Needs-Feedback Pri-3 Type-Bug
I don't understand what the problem is, the video doesn't show any flickering and the description doesn't provide enough information.

Labels: -hasbisect-per-revision Needs-Bisect
Owner: adha...@etouch.net
adharap@ Could you please provide tool bisect for this issue from your end.

Thanks!

Comment 6 by rk...@etouch.net, Oct 21 2016

Cc: amalika@google.com
Labels: -Needs-Feedback -Needs-Bisect
Owner: mkwst@chromium.org
With respect comment 5:

Rebisected for the above issue and below is bisect range.

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/136a7131948b4adc886e8da7ddfac54c2ae8b1b8..ecf8bb9b85922dbed58632e269d579deb06ef58b?pretty=fuller&n=10

Suspecting: r424124 ?

@mkwst / @amalika: Please help me to reassign this issue, if your change is not cause for it.
This bug is really caused by my patch (424123).

I suggested a fix in https://crrev.com/2454053004

There is a bug with the same reason:  http://crbug.com/659525 
And this bug should be reproducible only for maximized windows (not fullscreen or normal window mode).
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6279588b7ebc740f85409107dd91b5c3ce628065

commit 6279588b7ebc740f85409107dd91b5c3ce628065
Author: atimoxin <atimoxin@yandex-team.ru>
Date: Fri Oct 28 14:51:37 2016

Don't apply maximized window bounds workaround if bounds aren't changed

In HWNDMessageHandler::OnWindowPosChanging() was added code that
restores correct maximized window's bounds after attaching or detaching
additional display (see crrev.com/6bb7f8192). But this workaround also
applied if OnWindowPosChanging() was called with SWP_NOMOVE/SWP_NOSIZE
flags that leads to bugs such as  crbug.com/659525  and  crbug.com/655984 .

This CL adds additional check for SWP_NOMOVE/SWP_NOSIZE flags before
applying workaround and fixes this bugs.

BUG= 659525 , 655984 

Review-Url: https://codereview.chromium.org/2454053004
Cr-Commit-Position: refs/heads/master@{#428368}

[modify] https://crrev.com/6279588b7ebc740f85409107dd91b5c3ce628065/ui/views/win/hwnd_message_handler.cc

Labels: TE-Verified-56.0.2906.0 TE-Verified-M56
Tested the issue on Windows 7 using chrome Dev version-56.0.2906.0 with the steps mentioned in comment #0.Issue working as expected.

Please find the attached screen cast for the same.

Adding TE-Verified labels.

Thanks.

655984.mp4
913 KB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/deb38c53aaeb0ca533daf90abe4f46536df1661b

commit deb38c53aaeb0ca533daf90abe4f46536df1661b
Author: sky <sky@chromium.org>
Date: Mon Nov 07 18:06:42 2016

Revert of Don't apply maximized window bounds workaround if bounds aren't changed (patchset #1 id:1 of https://codereview.chromium.org/2454053004/ )

Reason for revert:
This resulted in a shortcut to move between monitors not working. See 656001.

Original issue's description:
> Don't apply maximized window bounds workaround if bounds aren't changed
>
> In HWNDMessageHandler::OnWindowPosChanging() was added code that
> restores correct maximized window's bounds after attaching or detaching
> additional display (see crrev.com/6bb7f8192). But this workaround also
> applied if OnWindowPosChanging() was called with SWP_NOMOVE/SWP_NOSIZE
> flags that leads to bugs such as  crbug.com/659525  and  crbug.com/655984 .
>
> This CL adds additional check for SWP_NOMOVE/SWP_NOSIZE flags before
> applying workaround and fixes this bugs.
>
> BUG= 659525 , 655984 
>
> Committed: https://crrev.com/6279588b7ebc740f85409107dd91b5c3ce628065
> Cr-Commit-Position: refs/heads/master@{#428368}

TBR=atimoxin@yandex-team.ru
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 659525 , 655984 

Review-Url: https://codereview.chromium.org/2482933002
Cr-Commit-Position: refs/heads/master@{#430314}

[modify] https://crrev.com/deb38c53aaeb0ca533daf90abe4f46536df1661b/ui/views/win/hwnd_message_handler.cc

Comment 12 by e...@chromium.org, Nov 30 2017

Status: WontFix (was: Assigned)
No longer reproduces.

Sign in to add a comment