Regression: 'You are viewing the source of web page' text seen on bubble of Google Chrome page.
Reported by
rk...@etouch.net,
Oct 14 2016
|
||||||
Issue descriptionChrome Version: 55.0.2883.11 Revision 709e70a37ad5ea7e4155b38134d00530605f11bb-refs/branch-heads/2883@{#79}(32/64bit) OS: Windows(7,8,10),Mac(10.10.5,10.11.4) Linux What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://version page. (2) Right click on page and Select View page source option, click on View site info bubble of source page. (3) Observe the text on bubble Actual: 'You are viewing the source of web page' text seen on bubble of Google Chrome page. Expected: 'You are viewing the source of Google Chrome page' text should seen on bubble. This is a regression issue, broken in 'M-54', will soon update the other info: Good Build: 54.0.2830.0 Bad Build: 54.0.2829.0
,
Oct 14 2016
Using the per-revision bisect providing the bisect results, Good build: 54.0.2829.0(Revision: 411902). Bad build: 54.0.2830.0 (Revision: 412124). You are probably looking for a change made after 407075 (known good), but no later than 407076 (first known bad). CHANGELOG URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/e311188e565ea85ccc4ad8f0aeee03eab488bb23..d37d668d489bdd1c8a678227386c0988fe4ea85b From the CL above, assigning the issue to the concern owner @capn - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Oct 14 2016
My change is unrelated. It only affects the about:credits page and removes a header which would have resulted in a build failure if it was still needed. The first known bad revision (407076) isn't within the bisect range 411902-412124. Could this be related to Issue 606619 instead?
,
Oct 14 2016
Sorry my bad, Updating the right bisect information results below. Using the per-revision bisect providing the bisect results, Good build: 54.0.2829.0(Revision: 411902). Bad build: 54.0.2830.0 (Revision: 412124). You are probably looking for a change made after 412066 (known good), but no later than 412067 (first known bad). CHANGELOG URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/2d932dfbfe8c3c8e3252c98d04509a3bd639a216..e1feca06c43dba6d9465e9a06370cbab24f5d7fe From the CL above, assigning the issue to the concern owner @meacer - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Oct 14 2016
I don't think it's our goal to give exact strings for all combinations of view-source and internal URLs like chrome://, chrome-extension:// and such. This is not a widely used UI and the current string seems sufficient to me. If you agree, I'm going to close this as WontFix.
,
Oct 18 2016
meacer@, thank you for the update. I got your point, however it would be nice to have all our internal URLs contains the correct string(s). Seems like it also regressed recently. On other hand i am reducing the priority to 'P2'.
,
Oct 18 2016
Sorry, but I'm still not seeing a regression here. Previously, the page info text showed the URL of the page, which would be view-source:chrome://chrome/settings/ which is not user friendly. This change completely replaced this text. I'd agree there was a regression if the previous text was also user facing and said "You are viewing the source of a chrome setting" page, but that's not the case here.
,
Oct 18 2016
sure, thank you for the update. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nyerramilli@chromium.org
, Oct 14 2016Status: Untriaged (was: Unconfirmed)