New issue
Advanced search Search tips

Issue 655980 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 631966



Sign in to add a comment

Local Performance tests for the speculative_prefetch_predictor.

Project Member Reported by lizeb@chromium.org, Oct 14 2016

Issue description

$subj.
 
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7371fec73920e104f4ca790572c5b869b22eb08

commit a7371fec73920e104f4ca790572c5b869b22eb08
Author: lizeb <lizeb@chromium.org>
Date: Thu Nov 24 15:27:30 2016

customtabs: Output all the available metrics after a timeout.

Some pages never really finish loading, even though for most benchmarks
we are interested in the first contentful paint timings, that are more
commonly reported.

Change the java benchmark app and the driver script to output the
available metrics after a delay. Also some minor cleanups in the code.

BUG=655980

Review-Url: https://codereview.chromium.org/2531573002
Cr-Commit-Position: refs/heads/master@{#434327}

[modify] https://crrev.com/a7371fec73920e104f4ca790572c5b869b22eb08/tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java
[modify] https://crrev.com/a7371fec73920e104f4ca790572c5b869b22eb08/tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b65cb1a116e559085ec372ea2ea4891bd00b1181

commit b65cb1a116e559085ec372ea2ea4891bd00b1181
Author: lizeb <lizeb@chromium.org>
Date: Wed Nov 30 15:56:50 2016

tools: Local tests for the speculative prefetch predictor.

Adds a tool to reset Chrome's state, push a predictor database to a
device, and load a page after a prefetch, collecting loading metrics.
This is a follow-up to crrev.com/2496563002.

Also adds a way to only enable external prefetch requests in the predictor.

BUG=655980

Review-Url: https://codereview.chromium.org/2508933002
Cr-Commit-Position: refs/heads/master@{#435270}

[modify] https://crrev.com/b65cb1a116e559085ec372ea2ea4891bd00b1181/tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py
[modify] https://crrev.com/b65cb1a116e559085ec372ea2ea4891bd00b1181/tools/resource_prefetch_predictor/generate_database.py
[add] https://crrev.com/b65cb1a116e559085ec372ea2ea4891bd00b1181/tools/resource_prefetch_predictor/prefetch_benchmark.py
[add] https://crrev.com/b65cb1a116e559085ec372ea2ea4891bd00b1181/tools/resource_prefetch_predictor/prefetch_predictor_common.py

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97d8cd800fa13dd25749d99a92540acb0e278b36

commit 97d8cd800fa13dd25749d99a92540acb0e278b36
Author: lizeb <lizeb@chromium.org>
Date: Fri Dec 16 17:20:01 2016

tools: WPR support for testing speculative_prefetch_predictor.

This CL adds support for WPR and network throttling (through WPR) for
testing the speculative_prefetch_predictor. The modifications are:
- Generate a WPR archive in generate_database.py
- Use the archive and set up throttling in prefetch_benchmark.

Also adds the ability to test several configuration of the predictor in
prefetch_benchmark, and make it loop.

BUG=655980

Review-Url: https://codereview.chromium.org/2561353002
Cr-Commit-Position: refs/heads/master@{#439131}

[modify] https://crrev.com/97d8cd800fa13dd25749d99a92540acb0e278b36/tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py
[rename] https://crrev.com/97d8cd800fa13dd25749d99a92540acb0e278b36/tools/resource_prefetch_predictor/generate_test_data.py
[modify] https://crrev.com/97d8cd800fa13dd25749d99a92540acb0e278b36/tools/resource_prefetch_predictor/prefetch_benchmark.py

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5c15db9908512b44a0a47f6b24098d8daeffeb1

commit e5c15db9908512b44a0a47f6b24098d8daeffeb1
Author: lizeb <lizeb@chromium.org>
Date: Mon Dec 19 12:39:25 2016

predictors: Reduce the maximum concurrent prefetches.

In the resource_prefetch_predictor, the maximum number of concurrent
prefetches is set to 24. This is too high, as:
- It defeats the prioritization of resources in the database
- It was shown to slow down page loads in some case on slow connections
  by starving the page load resource fetches. (local testing using WPR
  and tools in tools/resource_prefetch_predictor)

BUG=631966,655980

Review-Url: https://codereview.chromium.org/2589713002
Cr-Commit-Position: refs/heads/master@{#439453}

[modify] https://crrev.com/e5c15db9908512b44a0a47f6b24098d8daeffeb1/chrome/browser/predictors/resource_prefetch_common.cc
[modify] https://crrev.com/e5c15db9908512b44a0a47f6b24098d8daeffeb1/chrome/browser/predictors/resource_prefetcher_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afc56429f8182efa5b97cda6ba8bed9999469a46

commit afc56429f8182efa5b97cda6ba8bed9999469a46
Author: trevordixon <trevordixon@chromium.org>
Date: Fri Mar 10 11:00:18 2017

customtabs: Respect delayToLaunchUrl even without delayToMayLaunchUrl.

In the Custom Tabs benchmark, in the case where mayLaunchUrl isn't
called, launchUrl shouldn't be called immediately. This change causes
launchUrl to be called after the delay specified by delayToLaunchUrl.

BUG=655980

Review-Url: https://codereview.chromium.org/2742563003
Cr-Commit-Position: refs/heads/master@{#456038}

[modify] https://crrev.com/afc56429f8182efa5b97cda6ba8bed9999469a46/tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java

Sign in to add a comment