New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655977 link

Starred by 0 users
Status: WontFix
Owner:
koten...@yandex-team.ru
Closed: Jul 2017
Cc:
nyerramilli@chromium.org
yosin@chromium.org
█ tkonch...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: In chrome://policy, unwanted text is seen in Print Preview section.

Reported by vvishwak...@etouch.net, Oct 14 2016 
Version: 55.0.2883.11 Revision 709e70a37ad5ea7e4155b38134d00530605f11bb-refs/branch-heads/2883@{#79}(32/64bit)
OS: Windows (7,8,10), Mac (10.10.5, 10.11.4), Linux (14.04 LTS)

What steps will reproduce the problem?
1) Launch chrome, go to chrome://policy and click anywhere on the page.
2) Give Print command, in Options section select ‘Selection only’ option.
3) Observe the left side in Preview section.

Unwanted text is seen in Preview section.

Unwanted text should not be seen in Preview section.

This is a Regression issue broken in M-48, below is the bisect info
Manual bisect:
Good build: 48.0.2552.0
Bad build: 48.0.2553.0

Narrow bisect URL:
https://chromium.googlesource.com/chromium/src/+log/40bfc08af48c40b1b76e88754f0d4f10e554bb3d..6b8dbb55a8dc971e5f0b5977f349161e457e35c0?pretty=fuller&n=10

Suspecting: r357309
policy.jpg
151 KB View Download

Comment 1 by koten...@yandex-team.ru, Oct 21 2016

Cc: yosin@chromium.org
I guess, you've skipped step 1.5: Select all content of the page.

The specific change that caused it is https://codereview.chromium.org/1427733003/patch/1/10007?context=10&column_width=80&tab_spaces=8

The problem is that FrameSelection::selectedHTMLForClipboard() that we use now is using ranges in FlatTree and the previous version was using regular ranges. As a quickfix I can just revert the changes in WebLocalFrameImpl.cpp, but the real problem here is that the markup made with the FlatTree range is not displayed correctly.

yosin, what do you think?

Comment 2 by yosin@chromium.org, Oct 24 2016

Status: WontFix (was: Assigned)
I could not reproduce M53(Stable) and M56(Canary).
Print preview doesn't use clipboard. So, FrameSelection::selectedHTMLForClipboard() doesn't relate.

Comment 3 by vvishwak...@etouch.net, Oct 24 2016 

With response to comment #2: The above issue is reproducible on latest Canary build no: 56.0.2899.0.

Correction in Steps:
1) Launch chrome, go to chrome://policy, click anywhere on the page and press Cmd+A (to select all text).
2) Give Print command, in 'Options' section select ‘Selection only’ option.
3) Observe the left side in Preview section.

Please review the attached screencast for reference.
policy_actual.mov
3.5 MB Download

Comment 4 by yosin@chromium.org, Oct 24 2016

Status: Available (was: WontFix)
>#3 vvishwakarma@, thank for video. Finally I understand the issue.

"Filter policies by name"(placeholder) text appeared on the top left corner of the page.

Comment 5 by koten...@yandex-team.ru, Oct 24 2016 

> Print preview doesn't use clipboard. So, FrameSelection::selectedHTMLForClipboard() doesn't relate.

Please see the mentioned diff: https://codereview.chromium.org/1427733003/patch/1/10007?context=10&column_width=80&tab_spaces=8

There you can see that we use FrameSelection::selectedHTMLForClipboard() for WebLocalFrameImpl::selectionAsMarkup(). We started doing that since they were essentially the same, the only difference was that the former uses the FlatTree selection.

Comment 6 by rbpotter@chromium.org, Jun 26 2017

Labels: -Pri-1 -M-55 Needs-Feedback Pri-3
I cannot reproduce this on Win 10 on 58.0.3029.110 Stable or 61.0.3141.0 Canary. Is this still an issue?

Printing internal chrome pages is not high priority, so reducing from P1.

Comment 7 by rbpotter@chromium.org, Jul 27 2017

Status: WontFix (was: Available)
Still not reproducible on 62.0.3168.0.

Closing due to lack of feedback.
►

Sign in to add a comment