New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655972 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 657038
Owner:
Not on Chrome anymore
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 651058



Sign in to add a comment

DCHECK hit when signin out after dismissing all categories

Project Member Reported by dgn@chromium.org, Oct 14 2016

Issue description

1. Sign in to chrome
2. Dismiss everything until getting the empty state with the global REFRESH link
3. Sign out

=> Crash

FATAL:content_suggestions_service.cc(217)] Check failed: providers_by_category_.find(category) != providers_by_category_.end()


After https://codereview.chromium.org/2400783003, dismissing a category removes it from |providers_by_category_|, and since signing out makes a transition to the NOT_PROVIDED state, we hit the DCHECK.
 

Comment 1 by dgn@chromium.org, Oct 14 2016

Blocking: 651058

Comment 2 by fi...@chromium.org, Oct 17 2016

Labels: ReleaseBlock-Stable M-56 zine-triaged

Comment 3 by treib@chromium.org, Oct 17 2016

If this is really just a DCHECK, no other problems, then it's not a release blocker - DCHECKs don't do anything in release builds :)

Of course, we still need to figure out why it triggers and fix the underlying problem.
Owner: dgn@chromium.org
I can't reproduce this, is it still present on trunk?

Comment 5 by dgn@chromium.org, Oct 24 2016

Mergedinto: 657038
Status: Duplicate (was: Assigned)
Can't reproduce anymore either. I think that was addressed by  issue 657038 

Sign in to add a comment