New issue
Advanced search Search tips

Issue 655971 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
TT



Sign in to add a comment

Wire up AD user policy flow.

Project Member Reported by tnagel@chromium.org, Oct 14 2016

Issue description

.

 
Labels: Enterprise-Triaged

Comment 4 by tnagel@chromium.org, Nov 21 2016

Labels: TT

Comment 5 by tnagel@chromium.org, Nov 21 2016

Labels: -M-56 M-57
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57bb531048630ec894f1c90676ed05457939359e

commit 57bb531048630ec894f1c90676ed05457939359e
Author: tnagel <tnagel@chromium.org>
Date: Thu Dec 29 17:46:07 2016

Setup Chromad user policy plumbing

Add UserActiveDirectoryPolicyManager configuration policy provider as a
browser context keyed service for Active Directory user policy.  To
avoid code duplication, the corresponding factory is shared with
UserCloudPolicyManager.  (Only one of the two managers can exist at the
same time.)  To clarify the factory's new role, the "Cloud" is dropped
from its name ("UserCloudPolicyManagerFactoryChromeOS").

As user and device Active Directory policy managers are very similar,
they probably should be merged in a future CL.

BUG= 655971 
TBR=sky (function rename in managed_bookmark_service_factory.cc)
TBR=achuith (a few renames in chrome/browser/chromeos/login)
TBR=anthonyvd (renames, type generalization in chrome/browser/profiles)
TBR=dbeam (renames propagated to policy_ui_handler.cc)

Review-Url: https://codereview.chromium.org/2606773002
Cr-Commit-Position: refs/heads/master@{#440967}

[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/bookmarks/managed_bookmark_service_factory.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/power_policy_browsertest.cc
[add] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_active_directory_policy_manager.cc
[add] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_active_directory_policy_manager.h
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[delete] https://crrev.com/5c105cf0d1aadeb1bb3ff7eafcb72d84bc432e20/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc
[delete] https://crrev.com/5c105cf0d1aadeb1bb3ff7eafcb72d84bc432e20/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.h
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder_factory.cc
[add] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
[add] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.h
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/chromeos/policy/user_policy_test_helper.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/policy/cloud/policy_header_service_factory.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/policy/cloud/user_cloud_policy_invalidator_factory.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/policy/profile_policy_connector.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/policy/profile_policy_connector.h
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/policy/profile_policy_connector_factory.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/policy/profile_policy_connector_unittest.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chrome/browser/ui/webui/policy_ui_handler.cc
[modify] https://crrev.com/57bb531048630ec894f1c90676ed05457939359e/chromeos/dbus/auth_policy_client.cc

Comment 8 by tnagel@chromium.org, Dec 29 2016

This is mostly done, there's only the CL to update the chrome://policy page outstanding: https://codereview.chromium.org/2608573002/
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bc11f1d5f5015f24456fe1ff86e0dc6d53111344

commit bc11f1d5f5015f24456fe1ff86e0dc6d53111344
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Thu Dec 29 13:57:14 2016

authpolicy: Use email as account id for session manager.

Temp solution to unblock other work.
Should be switched back to Object GUID.

BUG= chromium:655971 
TEST=manual on candy

Change-Id: I615fd587dfbae9c429e6f3fa860e6e8360585eb3
Reviewed-on: https://chromium-review.googlesource.com/423070
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>

[modify] https://crrev.com/bc11f1d5f5015f24456fe1ff86e0dc6d53111344/authpolicy/samba_interface.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a1a53c11f695fe666d72884f2195b4153251a1a

commit 7a1a53c11f695fe666d72884f2195b4153251a1a
Author: tnagel <tnagel@chromium.org>
Date: Wed Jan 04 04:32:48 2017

Integrate Chromad user policy into chrome://policy page

BUG= 655971 

Review-Url: https://codereview.chromium.org/2608573002
Cr-Commit-Position: refs/heads/master@{#441317}

[modify] https://crrev.com/7a1a53c11f695fe666d72884f2195b4153251a1a/chrome/browser/ui/webui/policy_ui_handler.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment