New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655970 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

CustomTabActivityTest#testContextMenuEntriesForLink/Image are flaky

Project Member Reported by joh...@chromium.org, Oct 14 2016

Issue description

org.chromium.chrome.browser.customtabs.CustomTabActivityTest#testContextMenuEntriesForImage and org.chromium.chrome.browser.customtabs.CustomTabActivityTest#testContextMenuEntriesForLink are flaky.

They both fail flakily with the same stack:

C  864.603s Main  java.util.concurrent.TimeoutException: waitForCallback timed out!
C  864.603s Main  	at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:184)
C  864.603s Main  	at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:192)
C  864.603s Main  	at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:198)
C  864.603s Main  	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.openContextMenuByJs(ContextMenuUtils.java:82)
C  864.603s Main  	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.openContextMenu(ContextMenuUtils.java:56)
C  864.603s Main  	at org.chromium.chrome.browser.customtabs.CustomTabActivityTest.testContextMenuEntriesForLink(CustomTabActivityTest.java:283)
C  864.603s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  864.603s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  864.603s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  864.603s Main  	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
C  864.603s Main  	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C  864.603s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C  864.603s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  864.603s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  864.604s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C  864.604s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

Of the last few builds of https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester:
ForLink failed on builds [5316, 5314, 5308, 5306]
ForImage failed on build 5312
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72ff8f35e3e0138ea9791d83dbd90b322d135b5b

commit 72ff8f35e3e0138ea9791d83dbd90b322d135b5b
Author: johnme <johnme@chromium.org>
Date: Fri Oct 14 12:27:35 2016

Mark CustomTabActivityTest#testContextMenuEntriesForLink/Image flaky

TBR=yusufo@chromium.org
BUG=655970

Review-Url: https://codereview.chromium.org/2418133002
Cr-Commit-Position: refs/heads/master@{#425300}

[modify] https://crrev.com/72ff8f35e3e0138ea9791d83dbd90b322d135b5b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca6324d8474f7b2e23b21c78b7bf4e6f390757d6

commit ca6324d8474f7b2e23b21c78b7bf4e6f390757d6
Author: wychen <wychen@chromium.org>
Date: Thu Oct 27 01:06:23 2016

Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image

TBR=yusufo@chromium.org
BUG=655970

Review-Url: https://codereview.chromium.org/2451883002
Cr-Commit-Position: refs/heads/master@{#427899}

[modify] https://crrev.com/ca6324d8474f7b2e23b21c78b7bf4e6f390757d6/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bc6bfeed1918d135ff8ed06b8f2bf0642abcc12

commit 1bc6bfeed1918d135ff8ed06b8f2bf0642abcc12
Author: foolip <foolip@chromium.org>
Date: Thu Oct 27 08:58:40 2016

Revert of Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image (patchset #1 id:1 of https://codereview.chromium.org/2451883002/ )

Reason for revert:
Failures in chrome_public_test_apk on Android Tests (dbg) including
failures in CustomTabActivityTest traced to this CL by findit.

Original issue's description:
> Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image
>
> TBR=yusufo@chromium.org
> BUG=655970
>
> Committed: https://crrev.com/ca6324d8474f7b2e23b21c78b7bf4e6f390757d6
> Cr-Commit-Position: refs/heads/master@{#427899}

TBR=ianwen@chromium.org,wychen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=655970

Review-Url: https://codereview.chromium.org/2457693002
Cr-Commit-Position: refs/heads/master@{#427971}

[modify] https://crrev.com/1bc6bfeed1918d135ff8ed06b8f2bf0642abcc12/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1107bd576a9902d29d010cfb1c8edf512fb846a5

commit 1107bd576a9902d29d010cfb1c8edf512fb846a5
Author: wychen <wychen@chromium.org>
Date: Fri Oct 28 20:43:36 2016

Reland of Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image

This is a reland of https://codereview.chromium.org/2451883002/

TBR=yusufo@chromium.org
BUG=655970

Review-Url: https://codereview.chromium.org/2454503006
Cr-Commit-Position: refs/heads/master@{#428482}

[modify] https://crrev.com/1107bd576a9902d29d010cfb1c8edf512fb846a5/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4800fb054661d751e2effad3d5bc21322d2e8250

commit 4800fb054661d751e2effad3d5bc21322d2e8250
Author: johnme <johnme@chromium.org>
Date: Fri Nov 25 12:33:16 2016

CustomTabActivityTest: Mark testContextMenuEntriesForLink/Image flaky

These are the number #1 and #3 causes of flakiness on
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&builder=chromium.android%3ALollipop%20Phone%20Tester
and often fail multiple times in a row, turning builds red despite
automated retries.

TBR=ianwen@chromium.org,wychen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=655970

Review-Url: https://codereview.chromium.org/2532703002
Cr-Commit-Position: refs/heads/master@{#434487}

[modify] https://crrev.com/4800fb054661d751e2effad3d5bc21322d2e8250/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Comment 8 by ian...@chromium.org, Jun 13 2017

Owner: yus...@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment