New issue
Advanced search Search tips

Issue 655967 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

When master/builder memcache entry clears the flakiness dashboard doesn't load

Project Member Reported by joh...@chromium.org, Oct 14 2016

Issue description

Loading https://test-results.appspot.com/dashboards/flakiness_dashboard.html fails

It logs the following error twice:

builders.js:81 No master and builder found for webkit_tests

And then throws an exception in generatePage:

flakiness_dashboard.js:82 Uncaught TypeError: Cannot read property 'length' of undefined(…)

P1, as this makes sheriffing much harder :-|
 
Labels: -Pri-1 Pri-0
Owner: serg...@chromium.org
Status: Started (was: Untriaged)
Status: WontFix (was: Started)
Somehow the dashboard repaired itself. The only thing that I managed to find out is that /builders endpoint returned all masters with no tests and now it returns tests as before, so I am not sure what caused it.
P.S. I've also tried reverting default module to earlier versions (http://shortn/_9qi1zhPV8l, sorry, internal only), but that didn't seem to help.

Comment 4 by estaab@chromium.org, Oct 14 2016

Labels: -Pri-0 Pri-1
Owner: estaab@chromium.org
Status: Assigned (was: WontFix)
Summary: When master/builder memcache entry clears the flakiness dashboard doesn't load (was: Flakiness Dashboard is down)
I think I know what happened here and updated the summary. Assigning to myself to resolve this so it doesn't happen again but I won't get to this right away.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ba0044d3eac27f216508c461ca615436f3892b2f

commit ba0044d3eac27f216508c461ca615436f3892b2f
Author: Erik Staab <estaab@google.com>
Date: Thu Dec 01 14:01:21 2016

test-results: Remove dependency on buildbot / milo.

This changes the way we generate the list of known (master, builder, test)
tuples to use what has recently been uploaded instead of scraping step names
from recent passing buildbot builds.

The benefits to doing this are:
1) No more outages from empty builder data caused by milo queries that
timeout from being too large.
2) The javascript client will now only fetch results for combinations that
exist instead of an approximate set.
3) New test combinations will be able to upload and serve without
needing to be whitelisted.

BUG= 666889 ,659952, 655967 , 666810 , 661047 , 643944 , 405799 

Change-Id: Icd0a8a88eecbd920677f704cf816b143e7437e50
Reviewed-on: https://chromium-review.googlesource.com/413142
Commit-Queue: Erik Staab <estaab@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/ba0044d3eac27f216508c461ca615436f3892b2f/appengine/test_results/index.yaml
[delete] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/test-results/buildextract/buildextract.go
[delete] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/test-results/buildextract/buildextract.infra_testing
[delete] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/test-results/buildextract/buildextract_test.go
[delete] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/test-results/buildextract/testing.go
[delete] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/test-results/buildextract/testing_test.go
[modify] https://crrev.com/ba0044d3eac27f216508c461ca615436f3892b2f/go/src/infra/appengine/test-results/cron.yaml
[modify] https://crrev.com/ba0044d3eac27f216508c461ca615436f3892b2f/go/src/infra/appengine/test-results/frontend/builders.go
[modify] https://crrev.com/ba0044d3eac27f216508c461ca615436f3892b2f/go/src/infra/appengine/test-results/frontend/builders_test.go
[modify] https://crrev.com/ba0044d3eac27f216508c461ca615436f3892b2f/go/src/infra/appengine/test-results/frontend/handlers.go

Status: Fixed (was: Assigned)

Sign in to add a comment