New issue
Advanced search Search tips

Issue 655956 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Delete LegacyPolicyCacheLoader.

Project Member Reported by tnagel@chromium.org, Oct 14 2016

Issue description

// TODO(mnissler): Remove all the legacy policy support members below after
// the number of pre-M20 clients drops back to zero.

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h?rcl=0&l=131

I guess it's safe to remove the LegacyPolicyCacheLoader (whatever that is about)?
 
There used to be a time where we stored user policy directly in the Chrome Profile, instead of having session_manager broker it.

By all standards it's safe to remove this code now.
Labels: Enterprise-Triaged
Owner: dskaram@chromium.org
Status: Unconfirmed (was: Untriaged)
Assigned to dskaram for triage.

Comment 3 by tnagel@chromium.org, Oct 17 2016

Cc: tnagel@chromium.org
Labels: Hotlist-GoodFirstBug
Owner: ----
Status: Available (was: Unconfirmed)
No need to bother David with a minor code health issue.

Comment 4 Deleted

Owner: pmarko@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21108b94206bdb524c67b3d4b765b6965cecc4bd

commit 21108b94206bdb524c67b3d4b765b6965cecc4bd
Author: pmarko <pmarko@chromium.org>
Date: Tue Nov 22 08:58:53 2016

Remove legacy policy cache support on chromeos

Remove obsolete loading of legacy policy cache files from the chrome
profile (created before session_manager was used to store policy).
Also remove unit tests which were testing the migration path.

BUG= 655956 
TEST=ran all components_unittests and unit_tests

Review-Url: https://codereview.chromium.org/2487703002
Cr-Commit-Position: refs/heads/master@{#433818}

[modify] https://crrev.com/21108b94206bdb524c67b3d4b765b6965cecc4bd/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc
[modify] https://crrev.com/21108b94206bdb524c67b3d4b765b6965cecc4bd/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc
[modify] https://crrev.com/21108b94206bdb524c67b3d4b765b6965cecc4bd/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
[modify] https://crrev.com/21108b94206bdb524c67b3d4b765b6965cecc4bd/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

Comment 8 by pmarko@chromium.org, Nov 23 2016

Status: Fixed (was: Started)

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)

Sign in to add a comment