New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655948 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Oct 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Should not able to change to GTK+ theme in Supervised user of Linux

Project Member Reported by sc00335...@techmahindra.com, Oct 14 2016 
Version: 56.0.2890.0 dev
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Sign in to user and import/create supervised user >> Switch to supervised user and add any theme
(2) Now observe themes section in chrome://md-settings

Expected: Only reset to default button should be seen.
Actual: Instead Use GTK+ and Use Classic buttons are seen.

NOTE:1. General settings of supervised user doesn't support GTK+ theme.
2. Issue is not applicable to Windows.

This is a regression issue broken in M56.

Good Build: 56.0.2889.0 dev
Bad Build: 56.0.2890.0 dev
Actual_theme button.ogv
1.1 MB View Download
Expected_theme button.ogv
830 KB View Download

Comment 1 by brajkumar@chromium.org, Oct 14 2016

Labels: -Needs-Bisect
Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce on Ubuntu 14.04 using chrome latest Dev #56.0.2890.0, Issue is not seen on Mac OS 10.12

Bisect Information:
=====================
Good build: 56.0.2889.0
Bad Build : 56.0.2890.0

Unable to perform per revision bisect due to unknown revisions, So providing manual change log below.

Change Log URL: 
-----------------
https://chromium.googlesource.com/chromium/src/+log/56.0.2889.0..56.0.2890.0?pretty=fuller&n=10000

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2413623004

dbeam@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by dbeam@chromium.org, Oct 14 2016

Labels: -Pri-1 Pri-2

Comment 3 by dbeam@chromium.org, Oct 18 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3579d084d1c7856a8ccff5d6191d6eaba9fad97

commit a3579d084d1c7856a8ccff5d6191d6eaba9fad97
Author: dbeam <dbeam@chromium.org>
Date: Wed Oct 19 00:00:38 2016

MD Settings: don't allow supervised users to switch to GTK+ theme

R=dpapad@chromium.org
BUG= 655948 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2426863002
Cr-Commit-Position: refs/heads/master@{#426093}

[modify] https://crrev.com/a3579d084d1c7856a8ccff5d6191d6eaba9fad97/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.html
[modify] https://crrev.com/a3579d084d1c7856a8ccff5d6191d6eaba9fad97/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
[modify] https://crrev.com/a3579d084d1c7856a8ccff5d6191d6eaba9fad97/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/a3579d084d1c7856a8ccff5d6191d6eaba9fad97/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/a3579d084d1c7856a8ccff5d6191d6eaba9fad97/chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp
[modify] https://crrev.com/a3579d084d1c7856a8ccff5d6191d6eaba9fad97/chrome/browser/ui/webui/settings/appearance_handler.cc
[modify] https://crrev.com/a3579d084d1c7856a8ccff5d6191d6eaba9fad97/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/a3579d084d1c7856a8ccff5d6191d6eaba9fad97/chrome/test/data/webui/settings/appearance_page_test.js

Comment 5 by dbeam@chromium.org, Oct 19 2016

Status: Fixed (was: Started)
►

Sign in to add a comment