New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655943 link

Starred by 2 users
Status: Fixed
Owner:
nohe@chromium.org
Closed: Jan 8
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
fukino@chromium.org
yawano@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
PhotoEditor-2018q3p3


Sign in to add a comment

Regression: Unwanted highlight is seen on crop dimension in Gallery.app

Project Member Reported by sandeepkumars@chromium.org, Oct 14 2016 
Version: 55.0.2883.11/8872.8.0 (Official Build) dev-channel Peppy, Gnawty, Daisy
OS: Chrome

What steps will reproduce the problem?
(1) Sign in to user>> try to download 1, 2 images>> open it in gallery>>click on edit settings>> Click on Crop icon>> and observe

Expected: Default focus should not be seen on 1st dimensions box (ex: 1x1)
Actual: Instead default focus is seen 1st dimensions box (ex: 1x1)

This is a Regression as issue is not seen in M54: 54.0.2840.51/8743.57.0 beta channel Peppy

Issue is not applicable to Linux and Windows
Actual.png
154 KB View Download

Comment 1 by yawano@chromium.org, Dec 20 2016

Cc: fukino@chromium.org
Labels: Hotlist-GoodFirstBug

Comment 2 by weifangsun@chromium.org, Jun 7 2018

Cc: yawano@chromium.org
Labels: -Pri-1 -M-55 Pri-3
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bf8f784e384ab9a8aeb092aa66e108623e6e6c9

commit 6bf8f784e384ab9a8aeb092aa66e108623e6e6c9
Author: Alexander Nohe <nohe@chromium.org>
Date: Tue Jan 08 17:20:40 2019

Remove immediate focus from crop aspect ratio buttons.

This ensures that the aspect ratio buttons are not selected when the
toolbar is first shown in the photo editor. Removing this focus helps
the user realize that the 1x1 aspect ratio is not immediately selected
when loading the crop tool.

Bug:  655943 
Change-Id: I5dd7e11af7af5fefddb01c5587f2cf83078c0c05
Reviewed-on: https://chromium-review.googlesource.com/c/1394023
Commit-Queue: Alexander Nohe <nohe@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620772}
[modify] https://crrev.com/6bf8f784e384ab9a8aeb092aa66e108623e6e6c9/ui/file_manager/gallery/js/image_editor/image_editor_toolbar.js
[modify] https://crrev.com/6bf8f784e384ab9a8aeb092aa66e108623e6e6c9/ui/file_manager/integration_tests/gallery/photo_editor.js

Comment 5 by nohe@chromium.org, Jan 8

Owner: nohe@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment