New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655941 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Oct 2016
Cc:
whesse@google.com
█ dimu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Bullets in a list in a floating div move when page is scrolled vertically

Project Member Reported by whesse@chromium.org, Oct 14 2016 
Version:
Google Chrome	54.0.2840.59 (Official Build) (64-bit)
Revision	5b2f167ccdaed3f1a90ec1084715fbb91b8d25b0-refs/branch-heads/2840@{#726}

and

Google Chrome	55.0.2883.11 (Official Build) dev (64-bit)
Revision	709e70a37ad5ea7e4155b38134d00530605f11bb-refs/branch-heads/2883@{#79}

OS: Ubuntu linux

What steps will reproduce the problem?
(1) Open https://docs.python.org/2/library/subprocess.html
(2) Scroll vertically, using scrollbar or mouse wheel
(3) Bullets in the lists in the floating navigation panel at left move with the scrolled content.  List items don't move.

What is the expected output?
  The main content scrolls, the content in the floating div (navigation panel at left) scrolls to the end of its content, then remains fixed while main page continues scrolling
What do you see instead?
 Bullets in the lists in the floating navigation panel at left move with the scrolled main page content.  List items don't move, once we hit the top or bottom of the floating div content, but the bullets do.


Attaching gpu data from chrome://gpu as a text file

Problem does not occur on a Pixel 2, or in firefox on the same linux desktop.
gpu_data.txt
14.0 KB View Download

Comment 1 by dtapu...@chromium.org, Oct 14 2016 

This is a mix of composited scrolling and main thread javascript moving the float in a scroll listener.

See: https://docs.python.org/2/_static/sidebar.js it adjusts the float style inside a main thread listener.

I can certainly get it jumping around on FireFox if you scroll slowly with the scrollbar.

Seems to be fine in Chrome when you use the scrollbar to scroll (which causes main thread scrolling).

Comment 2 by durga.behera@chromium.org, Oct 18 2016

Labels: -Type-Bug -Pri-2 pre-stable-54.0.2840.59 ReleaseBlock-Stable hasbisect-per-revision M-54 OS-Mac OS-Windows Pri-1 Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
This is reproducible on Ubuntu 14.04,Win 10 and Mac 10.11.6 and regressed in M54.

Bisect info:
--------------
Good :54.0.2820.0
Bad : 54.0.2821.0 

CL : https://chromium.googlesource.com/chromium/src/+log/146d122ae8ed166f294231fbe6ca340ceffc356b..9d5d9721db94c90e362f857be02b5f0de22a5219

Possible Suspect : https://codereview.chromium.org/2203933002
wangxianzhu@: Could you please take a look into this if its related to your change.

Comment 3 by bustamante@google.com, Oct 18 2016

Labels: -M-54 M-55
Moving to M55 as we're already in stable, and this doesn't meet the bar for a new roll out.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ab22dff550158922f4a443d86cf993ac46348f8

commit 5ab22dff550158922f4a443d86cf993ac46348f8
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue Oct 18 22:51:14 2016

Fix list marker paint invalidation on move

BUG= 655941 
TEST=paint/invalidation/list-marker-move.html

Review-Url: https://codereview.chromium.org/2428963002
Cr-Commit-Position: refs/heads/master@{#426074}

[add] https://crrev.com/5ab22dff550158922f4a443d86cf993ac46348f8/third_party/WebKit/LayoutTests/paint/invalidation/list-marker-move-expected.html
[add] https://crrev.com/5ab22dff550158922f4a443d86cf993ac46348f8/third_party/WebKit/LayoutTests/paint/invalidation/list-marker-move.html
[modify] https://crrev.com/5ab22dff550158922f4a443d86cf993ac46348f8/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/5ab22dff550158922f4a443d86cf993ac46348f8/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/5ab22dff550158922f4a443d86cf993ac46348f8/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/5ab22dff550158922f4a443d86cf993ac46348f8/third_party/WebKit/Source/core/layout/LayoutListMarker.h

Comment 5 by wangxianzhu@chromium.org, Oct 19 2016

Labels: Merge-Request-55

Comment 6 by dimu@chromium.org, Oct 19 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09796644bb9190a9eb6ee462b6ab83361d98202c

commit 09796644bb9190a9eb6ee462b6ab83361d98202c
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Oct 19 22:17:16 2016

Fix list marker paint invalidation on move

BUG= 655941 
TEST=paint/invalidation/list-marker-move.html

Review URL: https://codereview.chromium.org/2440583003 .

Review-Url: https://codereview.chromium.org/2428963002
Cr-Original-Commit-Position: refs/heads/master@{#426074}
Cr-Commit-Position: refs/branch-heads/2883@{#197}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/09796644bb9190a9eb6ee462b6ab83361d98202c/third_party/WebKit/LayoutTests/paint/invalidation/list-marker-move-expected.html
[add] https://crrev.com/09796644bb9190a9eb6ee462b6ab83361d98202c/third_party/WebKit/LayoutTests/paint/invalidation/list-marker-move.html
[modify] https://crrev.com/09796644bb9190a9eb6ee462b6ab83361d98202c/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/09796644bb9190a9eb6ee462b6ab83361d98202c/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/09796644bb9190a9eb6ee462b6ab83361d98202c/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/09796644bb9190a9eb6ee462b6ab83361d98202c/third_party/WebKit/Source/core/layout/LayoutListMarker.h

Comment 8 by wangxianzhu@chromium.org, Oct 19 2016

Status: Fixed (was: Assigned)

Comment 9 by durga.behera@chromium.org, Oct 20 2016

Labels: TE-Verified-M55 TE-Verified-55.0.2883.21
Verified the issue on beta # 55.0.2883.21 on Mac 10.11.6, Win 10 and Ubuntu 14.04 and its working fine now.Please find the screen cast for the same.
655941_Oct_20.mp4
8.8 MB View Download

Comment 10 Deleted

Comment 11 Deleted

Comment 12 by dimu@google.com, Nov 4 2016 

[Automated comment] removing mislabelled merge-merged-2840

Comment 13 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment