New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655939 link

Starred by 1 user
Status: Fixed
Owner:
xiaoche...@chromium.org
Closed: Oct 2016
Cc:
kojii@chromium.org
█ nainar@chromium.org
█ bugsnash@chromium.org
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Move AlreadySpellCheckedFlag out of NodeFlags

Project Member Reported by xiaoche...@chromium.org, Oct 14 2016 
Spellchecking is not time-critical and should not use rare resources like NodeFlags.

We should move AlreadySpellCheckedFlag out of NodeFlags to make space for more fundamental tasks (e.g., layout).

Comment 1 by yosin@chromium.org, Oct 14 2016

Cc: -yosin@chromium.org
Components: -Blink>Layout

Comment 2 by yosin@chromium.org, Oct 14 2016 

I think ElementFlags is a good place for moving.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2acb119a211ed79d61f76b41070a209375140ff3

commit 2acb119a211ed79d61f76b41070a209375140ff3
Author: xiaochengh <xiaochengh@chromium.org>
Date: Fri Oct 14 11:05:56 2016

Move AlreadySpellCheckedFlag from NodeFlags to ElementFlags

This patch moves the flag from NodeFlags to ElementFlags to make
vacant space in NodeFlags. Currently, NodeFlags is full.

BUG= 655939 

Review-Url: https://codereview.chromium.org/2414323002
Cr-Commit-Position: refs/heads/master@{#425291}

[modify] https://crrev.com/2acb119a211ed79d61f76b41070a209375140ff3/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/2acb119a211ed79d61f76b41070a209375140ff3/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/2acb119a211ed79d61f76b41070a209375140ff3/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Comment 4 by nainar@chromium.org, Oct 14 2016 

Thank you so much for this xiaochengh@!

Comment 5 by xiaoche...@chromium.org, Oct 17 2016

Status: Fixed (was: Assigned)
Closing the issue as r425291 doesn't seem to break anything :)
►

Sign in to add a comment