New issue
Advanced search Search tips

Issue 655938 link

Starred by 1 user
Status: Fixed
Owner:
davidben@chromium.org
Closed: Oct 2016
Cc:
h...@chromium.org
thakis@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ClangToTLinuxASan failing with link errors "Cannot export local symbol 'free'" etc.

Project Member Reported by h...@chromium.org, Oct 14 2016 
E.g. from https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/5502/steps/compile/logs/stdio:

[3491/38671] LINK ./boringssl_bytestring_test
FAILED: boringssl_bytestring_test 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--threads -Wl,--thread-count=4 -pthread -m64 -Wl,-O1 -Wl,--gc-sections --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -L/b/c/b/ClangToTLinuxASan/src/build/linux/debian_wheezy_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/c/b/ClangToTLinuxASan/src/build/linux/debian_wheezy_amd64-sysroot/lib/x86_64-linux-gnu -L/b/c/b/ClangToTLinuxASan/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/c/b/ClangToTLinuxASan/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu -L/b/c/b/ClangToTLinuxASan/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -Wl,-rpath-link=/b/c/b/ClangToTLinuxASan/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -L/b/c/b/ClangToTLinuxASan/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib -Wl,-rpath-link=/b/c/b/ClangToTLinuxASan/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib -fsanitize=address -fsanitize=leak -Wl,-rpath-link=. -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -L. -o "./boringssl_bytestring_test" -Wl,--start-group @"./boringssl_bytestring_test.rsp" ./libc++.so -Wl,--end-group  -ldl -lrt 
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: Cannot export local symbol 'free'
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: Cannot export local symbol 'malloc'
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: Cannot export local symbol 'realloc'
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: error: treating warnings as errors
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)

Comment 1 by h...@chromium.org, Oct 14 2016

Status: Started (was: Available)
I can reproduce locally, and the regression started with this boringssl roll: https://codereview.chromium.org/2395323002

Comment 3 by h...@chromium.org, Oct 14 2016

Owner: h...@chromium.org
Reverting: https://codereview.chromium.org/2418113002/
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c048c38b523c078d567996a8d3263163b710a04c

commit c048c38b523c078d567996a8d3263163b710a04c
Author: hans <hans@chromium.org>
Date: Fri Oct 14 11:30:09 2016

Revert "Roll src/third_party/boringssl/src 0d81373f9..1991af690" (https://codereview.chromium.org/2395323002)

It broke the Linux ASan build of boringssl_bytestring_test.

(Reverting manually; Rietveld complained about some file being too large.)

Original description:
> Roll src/third_party/boringssl/src 0d81373f9..1991af690
>
> https://boringssl.googlesource.com/boringssl/+log/0d81373f9169637ff935449227be924c08bf1ec5..1991af69006a8fe4faf9b80b2340688846e62514
>
> This requires a change in WebCrypto. BoringSSL's
> https://boringssl.googlesource.com/boringssl/+/97227dc52d9e6620c8b83eb1dd4d45edf51d9d7f
> switches to aligning with upstream's APIs for AES key wrap.
>
> This also teaches DevTools how to handle the new draft TLS 1.3 ciphers
> and adds them to histograms.xml. See
> https://tools.ietf.org/html/draft-ietf-tls-tls13-16#appendix-A.4
>
> Finally, it adds the CECPQ1 experimental ciphers which we forgot to add
> there earlier.
>
> BUG= 639495 
> Committed: https://crrev.com/0f3127d8ff177305fe9992e87b4f096598fb787a
> Cr-Commit-Position: refs/heads/master@{#425147}

BUG= 639495 ,  655938 
TBR=davidben

Review-Url: https://codereview.chromium.org/2418113002
Cr-Commit-Position: refs/heads/master@{#425294}

[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/DEPS
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/chrome/browser/ssl/chrome_security_state_model_client.cc
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/chrome/browser/ui/website_settings/website_settings.cc
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/components/webcrypto/algorithms/aes_kw.cc
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/net/socket/ssl_server_socket_unittest.cc
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/net/ssl/ssl_cipher_suite_names.cc
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/net/ssl/ssl_cipher_suite_names.h
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/net/ssl/ssl_cipher_suite_names_unittest.cc
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/third_party/WebKit/Source/platform/network/ResourceResponse.h
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/third_party/WebKit/public/platform/WebURLResponse.h
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/third_party/boringssl/BUILD.generated.gni
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/third_party/boringssl/BUILD.gn
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/third_party/boringssl/err_data.c
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/third_party/boringssl/linux-x86_64/crypto/ec/p256-x86_64-asm.S
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/third_party/boringssl/mac-x86_64/crypto/ec/p256-x86_64-asm.S
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/third_party/boringssl/win-x86_64/crypto/ec/p256-x86_64-asm.asm
[modify] https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c/tools/metrics/histograms/histograms.xml

Comment 5 by thakis@chromium.org, Oct 14 2016

Cc: davidben@chromium.org

Comment 6 by davidben@chromium.org, Oct 14 2016

Cc: -davidben@chromium.org h...@chromium.org
Owner: davidben@chromium.org
Fun. I think we just need to tag those wrappers with visibility("default"), going by  issue #368351 . I'll deal with that in BoringSSL.

(That or we just exclude malloc.cc Chromium-built BoringSSL tests since it's unlikely we're going to get the malloc tests  running there anyway. But this seems to be a legitimate problem with how we're intercepting malloc anyway.)

Comment 7 by davidben@chromium.org, Oct 14 2016 

(That didn't work, so I'm just reverting the BoringSSL change. I'll figure out malloc silliness later.)

Comment 8 by davidben@chromium.org, Oct 14 2016

Status: Fixed (was: Started)
Not sure why bugdroid didn't notice, but the change in question was reverted.
https://boringssl.googlesource.com/boringssl/+/52db0eb46c52fa9b993f419b7d4796c9687ab0cf
►

Sign in to add a comment