Correction:

Good build:55.0.2881.0
Bad build:55.0.2882.0

Attaching screen-cast for reference.

Deleted: Actual.MOV 1.4 MB

Actual.MOV 1.4 MB Download

Using the per-revision bisect providing the bisect results,
Good build:55.0.2881.0(Revision: 423030).
Bad build: 55.0.2882.0 (Revision:423378).

You are probably looking for a change made after 423227 (known good), but no later than 423228 (first known bad).

CHANGELOG URL:
-----------------   https://chromium.googlesource.com/chromium/src/+log/c4e50671c1d6124c8cc4b315f9308a365da79df4..0f6bea6b3b13dc044d18813348c1137d0d0b51bc

From the CL above, assigning the issue to the concern owner 

@finnur - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Thanks!

This may be a new regression, but this menu you clicked on should not appear and I suspect this is fixed already by:
https://codereview.chromium.org/2378013002

Whether this fix is in your build, though, I don't know...

This doesn't appear to be OS specific? Removing OS labels.

Then that's OS-All.

dschuyler@, could you please take a look on comment #3 and fix this issue as this is marked as M55 stable blocker.

Thank you.

I see a crash when doing the steps above.
Though this appears to be an issue in site settings all, which is not going out in M55 or M56. I'm pushing it back to M57.
A recent change at CL 2409003002 puts the "All sites" page behind a chrome://flag, so users would need to enable that before being able to reproduce this bug.

Clarification: I'm pushing *this bug* back to M57

still able to repro the issue on win10 using chrome version 56.0.2902.0 and canary 56.0.2905.0 - browser crashes on clicking any option of three dot menu in chrome://md-settings/siteSettings/all page. Below is the crash ID in chrome://crashes

Crash ID 8100a1bb-49e5-44b2-af04-32931041ed7e (Server ID: 3feb4e4700000000)

Stack Trace:
Thread 0 CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000020 ] MAGIC SIGNATURE THREAD
0x00007ffd0b9477cc	(chrome.dll -content_settings_pref.cc:117 )	content_settings::ContentSettingsPref::SetWebsiteSetting(ContentSettingsPattern const &,ContentSettingsPattern const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::Value *)
0x00007ffd0b944ab0	(chrome.dll -content_settings_pref_provider.cc:124 )	content_settings::PrefProvider::SetWebsiteSetting(ContentSettingsPattern const &,ContentSettingsPattern const &,ContentSettingsType,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::Value *)
0x00007ffd0b93a984	(chrome.dll -host_content_settings_map.cc:369 )	HostContentSettingsMap::SetWebsiteSettingCustomScope(ContentSettingsPattern const &,ContentSettingsPattern const &,ContentSettingsType,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,std::unique_ptr<base::Value,std::default_delete<base::Value> >)
0x00007ffd0b93ace4	(chrome.dll -host_content_settings_map.cc:443 )	HostContentSettingsMap::SetContentSettingCustomScope(ContentSettingsPattern const &,ContentSettingsPattern const &,ContentSettingsType,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,ContentSetting)
0x00007ffd0bedbb52	(chrome.dll -site_settings_handler.cc:504 )	settings::SiteSettingsHandler::HandleSetCategoryPermissionForOrigin(base::ListValue const *)
0x00007ffd0ac2fb6a	(chrome.dll -web_ui_impl.cc:254 )	content::WebUIImpl::ProcessWebUIMessage(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &)
0x00007ffd0ac2f367	(chrome.dll -web_ui_impl.cc:108 )	content::WebUIImpl::OnWebUISend(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &)
0x00007ffd0ac30014	(chrome.dll -ipc_message_templates.h:121 )	IPC::MessageT<ViewHostMsg_WebUISend_Meta,std::tuple<GURL,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue>,void>::Dispatch<content::WebUIImpl,content::WebUIImpl,void,void ( content::WebUIImpl::*)(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &)>(IPC::Message const *,content::WebUIImpl *,content::WebUIImpl *,void *,void ( content::WebUIImpl::*)(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &))
0x00007ffd0ac2f2ac	(chrome.dll -web_ui_impl.cc:91 )	content::WebUIImpl::OnMessageReceived(IPC::Message const &)
0x00007ffd0ac0f201	(chrome.dll -web_contents_impl.cc:673 )	content::WebContentsImpl::OnMessageReceived(content::RenderViewHost *,content::RenderFrameHost *,IPC::Message const &)
0x00007ffd0ab520d8	(chrome.dll -render_view_host_impl.cc:839 )	content::RenderViewHostImpl::OnMessageReceived(IPC::Message const &)
0x00007ffd0ab57af4	(chrome.dll -render_widget_host_impl.cc:464 )	content::RenderWidgetHostImpl::OnMessageReceived(IPC::Message const &)
0x00007ffd0ab46761	(chrome.dll -render_process_host_impl.cc:2000 )	content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const &)
0x00007ffd0b6fd853	(chrome.dll -ipc_channel_proxy.cc:339 )	IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const &)
0x00007ffd0afacc29	(chrome.dll -task_annotator.cc:52 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *)
0x00007ffd0af62b7b	(chrome.dll -message_loop.cc:413 )	base::MessageLoop::RunTask(base::PendingTask *)
0x00007ffd0af63794	(chrome.dll -message_loop.cc:515 )	base::MessageLoop::DoWork()
0x00007ffd0afad510	(chrome.dll -message_pump_win.cc:263 )	base::MessagePumpForUI::DoRunLoop()
0x00007ffd0afad1e3	(chrome.dll -message_pump_win.cc:141 )	base::MessagePumpWin::Run(base::MessagePump::Delegate *)
0x00007ffd0af84fe2	(chrome.dll -run_loop.cc:35 )	base::RunLoop::Run()
0x00007ffd0ae91716	(chrome.dll -chrome_browser_main.cc:2001 )	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x00007ffd0a94fe2c	(chrome.dll -browser_main_runner.cc:155 )	content::BrowserMainRunnerImpl::Run()
0x00007ffd0a948c9a	(chrome.dll -browser_main.cc:46 )	content::BrowserMain(content::MainFunctionParams const &)
0x00007ffd0ae41372	(chrome.dll -content_main_runner.cc:776 )	content::ContentMainRunnerImpl::Run()
0x00007ffd09f6b9ed	(chrome.dll -chrome_main.cc:97 )	ChromeMain
0x00007ff6afc17628	(chrome.exe -main_dll_loader_win.cc:174 )	MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks)
0x00007ff6afc120b0	(chrome.exe -chrome_exe_main_win.cc:247 )	wWinMain
0x00007ff6afca10a2	(chrome.exe -exe_common.inl:253 )	__scrt_common_main_seh
0x00007ffd32498101	(KERNEL32.DLL + 0x00018101 )	BaseThreadInitThunk
0x00007ffd329cc5b3	(ntdll.dll + 0x0005c5b3 )	RtlUserThreadStart

Similar stack trace is seen in  issue 651326 

@dschuyler: Gentle ping, can we have an update on this issue. Issue is marked with a blocker label.

Thanks.!

@dschuyler-Please take a look into this issue & provide us the update on the same .

Thank you.

Tested the issue on Windows 10 using chrome latest canary M57 #57.0.2942.0 and issue is not reproduced.

Steps followed :

1. Enabled the flag "Site settings with All sites and Site details " from chrome://flags .
2. Navigated to chrome://md-settings/siteSettings/all page and clicked on three dot meny on any sites .
3. No crash observed .

@jbanavatu-- Could you please check in latest canary , if you can reproduce the issue and update the thread .

Thanks!

Able to reproduce issue on Ubuntu 14.04 using latest dev #57.0.2942.0.

CL 2593503004

 Issue 649254  has been merged into this issue.

I believe the bug is that the three dot menu should not be shown on the all-sites page.

Correct. I think the problem is that this:

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_settings/site_list.html?sq=package:chromium&dr&l=85

... should not be calling isExceptionControlled_(item.source) but shouldShowMenu_(item.source).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed631c6c5084eeaedd93ac8a767bff4c6d6506d5

commit ed631c6c5084eeaedd93ac8a767bff4c6d6506d5
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Dec 21 17:57:10 2016

[MD settings] remove action menu from all-sites

This CL fixes a crash in content settings that arises from using the
action menu within the all-sites page. The action menu should be hidden
on that page and this CL removes that UI from the all-sites page.

BUG= 655929 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2593503004
Cr-Commit-Position: refs/heads/master@{#440147}

[modify] https://crrev.com/ed631c6c5084eeaedd93ac8a767bff4c6d6506d5/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/ed631c6c5084eeaedd93ac8a767bff4c6d6506d5/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/ed631c6c5084eeaedd93ac8a767bff4c6d6506d5/chrome/test/data/webui/settings/site_list_tests.js

Verified on Mac OS 10.12.2 , Ubuntu 14.04 and windows 10 using chrome Dev M57 #57.0.2970.0 and issue is fixed.

No crash is seen on clicking any option of three dot menu in chrome://md-settings/siteSettings/all page.

Attached screencast for reference.

Adding TE-Verified Labels.

Thanks!

Deleted: 655929.mp4 128 KB

	655929.mp4 128 KB View Download