Issue metadata
Sign in to add a comment
|
Regression : ‘Microphone’ icon is missing in microphone permission bubble.
Reported by
yfulgaon...@etouch.net,
Oct 14 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 56.0.2890.0 (Official Build) b2c7e72483b4fa50df162b9f38f0270c3079aad9-refs/heads/master@{#425218} 64-bit OS: Mac(10.10.5)(10.11.5) Test URL : https://permission.site/ What steps will reproduce the problem? 1. Launch chrome and navigate to above URL. 2. Click on ‘Microphone’ button and observe the ‘Permission’ bubble. Actual : ‘Microphone’ icon is missing in microphone permission bubble. Expected : ‘Microphone’ icon should be there in permission bubble. This is a regression issue broken in ‘M-55’, below is the Manual Regression and Narrow Bisect info. Good build : 55.0.2881.0 Bad build : 55.0.2882.0 Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/fe50203c3961eedce90e4b3d10c75acfa6552758..626bdde804d615c4582b5c1a78bd8929f83b1ab9?pretty=fuller&n=10000 Suspecting: r423212 from Narrow Bisect @estade : Please take a look. Note : This is Mac specific issue and not seen on Windows/Linux OS.
,
Oct 14 2016
Adding RB label as this is a recent regression.
,
Oct 14 2016
estade@, could you please take a look and fix this ASAP as this is marked as M55 stable blocker. Thank you.
,
Oct 17 2016
I guess this[1] isn't working as expected, or perhaps this is a Elly, would you mind having a look while I'm ooo? [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm?rcl=0&l=517
,
Oct 21 2016
@ellyjones: gentle Ping, can we have an update on this issue
,
Oct 24 2016
Since this issue is marked as a stable blocker issue, can we get any latest update on it? Already M55 has moved to beta and we are planning to push M55 to stable version soon.
,
Oct 24 2016
ellyjones@ is OOO. estade@ may be out for part of this week (can't tell) but if so he will be back before ellyjones@. Assigning back to him.
,
Oct 24 2016
we're pushing m55 to stable soon? Calendar says early December.
,
Oct 25 2016
On chrome 56.0.2899.0 canary (64-bit) on my laptop, I do get the icon. OSX 10.11.6 estade: Is it possible that https://codereview.chromium.org/2385063005 fixed this?
,
Oct 25 2016
yea, that seems likely. I don't look forward to merging that :/ merge request for https://codereview.chromium.org/2385063005
,
Oct 26 2016
**** Bulk edit - please ignore if not applicable **** A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
,
Oct 26 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 26 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 27 2016
Rechecked this on chrome canary version 56.0.2901.4 on MAC 10.11.6. Fix is working as intended. Able to see the Microphone icon in the permission bubble. Need to verify on M55 branch once the merge is in. Adding TE-Verified labels for Canary. Thanks.!
,
Oct 27 2016
merge seems to have gone through cleanly, thankfully.
,
Oct 27 2016
estade@, could you please confirm whether CL listed at comment #10 (https://codereview.chromium.org/2385063005) is merged to M55? I don't see any bugdroid update for merge so double checking. Thank you.
,
Oct 27 2016
ask whoever's in charge of bugdroid why it's flaky here's the commit: https://chromium.googlesource.com/chromium/src/+/089cf6d16f3733ff8c78767c56bd8856e6695d09
,
Oct 27 2016
Thank you estade@. https://chromium.googlesource.com/chromium/src/+/089cf6d16f3733ff8c78767c56bd8856e6695d09 (listed BUG= 651270 ). And this bug is 655925, this is the reason we don't see bugdroid update in this bug.
,
Oct 27 2016
If nothing is pending for M55, please remove "Merge-Approved-55" label and apply "merge-merged-2883" label. Thank you.
,
Oct 27 2016
ah, makes sense
,
Nov 1 2016
Verified the issue on chrome latest M55-55.0.2883.34 by followings steps mentioned in the original comment. Observed the microphone icon is present in the permission bubble as expected. Hence adding TE-Verified label. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by yfulgaon...@etouch.net
, Oct 14 2016