Issue 655920 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	toyoshim@chromium.org
Closed:	Feb 2017
Components:	Blink>Loader
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Bug

Blocking:
issue 655916

Platform/Loader Yukari - Step 1: move Resource(Client) subclasses to core/loader/resources

Project Member Reported by toyoshim@chromium.org, Oct 14 2016

Issue description

See parent meta bug  crbug.com/655916  for details.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34e1750b210d1e66183fcfd26fb0e72dc544cd5f

commit 34e1750b210d1e66183fcfd26fb0e72dc544cd5f
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Oct 14 08:05:59 2016

Loading: bulk style errors fix in core/loader

There are many style errors probably after the cl-format changes
indents. This may hide important presubmit warnings/errors in the middle
of refactoring works.

TEST=./Tools/Scripts/check-webkit-style Source/core/loader
TEST=ninja -C out/Release all
BUG= 655920 

Review-Url: https://codereview.chromium.org/2415373002
Cr-Commit-Position: refs/heads/master@{#425271}

[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/FormSubmission.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/HttpEquiv.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/MixedContentChecker.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/TextResourceDecoderBuilder.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.h
[modify] https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a85520418a62d27bdb5fc4e5356c88e2bd459d1

commit 3a85520418a62d27bdb5fc4e5356c88e2bd459d1
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Oct 14 08:06:52 2016

Loading: bulk style errors fix in core/fetch

This patch fixes style errors on core/fetch that happens probably after
the cl-format changes. This fix will help to avoid from hidding
important presubmit warnings/errors in the middle of refactoring works.

(*1): Style check still shows one error, but it needs non-mechanical
changes that will make different binary. So I do not want to contain
the fix for it in this change.

TEST=./Tools/Script/check-webkit-style Source/core/fetch  (*1)
TEST=ninja -C out/Release all
BUG= 655920 

Review-Url: https://codereview.chromium.org/2417173002
Cr-Commit-Position: refs/heads/master@{#425272}

[modify] https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp
[modify] https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp
[modify] https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1/third_party/WebKit/Source/core/fetch/FetchContext.cpp
[modify] https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
[modify] https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp

Comment 3 Deleted

Comment 4 by toyoshim@chromium.org, Nov 11 2016

This plan is slightly modified.
I will move Resource and ResourceClient sub-classes to core/loader/resource/, then move core/fetch directly to platform/loader/fetch.

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/162f29c10a4d1e9d037ed42c34eb9460ae20a5bb

commit 162f29c10a4d1e9d037ed42c34eb9460ae20a5bb
Author: toyoshim <toyoshim@chromium.org>
Date: Mon Nov 14 10:28:03 2016

Loading: Factor out ResourceFetcherMockFetchContext

Factor out ResourceFetcherMockFetchContext as MockFetchContext
so that multiple unit tests can use it for mocking FetchContext
on unit tests.

I'm planning to split ResourceFetcherTest.cpp into multiple files
so that I can remove undesirable dependencies from the tests to
Resource and ResourceClient sub-classes. Once the tests are split
into multiple files, they all will use this single header file
to have a mocked FetchContext.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2495003002
Cr-Commit-Position: refs/heads/master@{#431849}

[modify] https://crrev.com/162f29c10a4d1e9d037ed42c34eb9460ae20a5bb/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/162f29c10a4d1e9d037ed42c34eb9460ae20a5bb/third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp
[add] https://crrev.com/162f29c10a4d1e9d037ed42c34eb9460ae20a5bb/third_party/WebKit/Source/core/fetch/MockFetchContext.h
[modify] https://crrev.com/162f29c10a4d1e9d037ed42c34eb9460ae20a5bb/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfac0465b75d41170c765d1d1d3463917e7f79f8

commit cfac0465b75d41170c765d1d1d3463917e7f79f8
Author: toyoshim <toyoshim@chromium.org>
Date: Wed Nov 16 08:36:17 2016

Loading: move core/fetch/*Resource* to core/loader/resource/

To remove core/ dependency so that core/fetch can be moved under
platform, move Resource and ResourceClient classes and inheritances
to core/loader/resource/.

This change is the first step, moving classes on that classes under
core/fetch/ do not depend.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2497463004
Cr-Commit-Position: refs/heads/master@{#432431}

[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/dom/PendingScript.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/dom/PendingScript.h
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/dom/ScriptLoader.h
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/fetch/BUILD.gn
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/BUILD.gn
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/LinkLoader.h
[rename] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/resource/DocumentResource.cpp
[rename] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/resource/DocumentResource.h
[rename] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/resource/LinkFetchResource.cpp
[rename] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/resource/LinkFetchResource.h
[rename] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.cpp
[rename] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.h
[rename] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp
[rename] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/resource/ScriptResource.h
[rename] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/resource/XSLStyleSheetResource.cpp
[rename] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/loader/resource/XSLStyleSheetResource.h
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/svg/SVGElementProxy.h
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/svg/SVGResourceClient.h
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/svg/SVGUseElement.h
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/workers/Worklet.h
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/workers/WorkletScriptLoader.h
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/xml/XSLImportRule.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95739c0f46d7ba1eaa74833531c45dd0121c3cd6

commit 95739c0f46d7ba1eaa74833531c45dd0121c3cd6
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Nov 17 07:31:49 2016

Loading: split tests depend on FontResource to loader/resource/FontResourceTest

This patch splits a test that depends on FontResource to another test
file, loader/resource/FontResourceTest.

FontResource will follow this patch to be moved into loader/resource/.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2510603002
Cr-Commit-Position: refs/heads/master@{#432800}

[modify] https://crrev.com/95739c0f46d7ba1eaa74833531c45dd0121c3cd6/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/95739c0f46d7ba1eaa74833531c45dd0121c3cd6/third_party/WebKit/Source/core/fetch/FontResource.h
[modify] https://crrev.com/95739c0f46d7ba1eaa74833531c45dd0121c3cd6/third_party/WebKit/Source/core/fetch/MockFetchContext.h
[modify] https://crrev.com/95739c0f46d7ba1eaa74833531c45dd0121c3cd6/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
[add] https://crrev.com/95739c0f46d7ba1eaa74833531c45dd0121c3cd6/third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aca85fb7b0661acec32e99688fc99f6de63b6e69

commit aca85fb7b0661acec32e99688fc99f6de63b6e69
Author: toyoshim <toyoshim@chromium.org>
Date: Wed Nov 30 07:40:26 2016

Loading: factor out common functionalities for memory cache testing

Before splitting resource type specific memory cache tests from
CachingCorrectnessTest, factor out common functionalities for memory
cache testing so that we can use it from multiple test files.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2509593003
Cr-Commit-Position: refs/heads/master@{#435133}

[modify] https://crrev.com/aca85fb7b0661acec32e99688fc99f6de63b6e69/third_party/WebKit/Source/core/BUILD.gn
[rename] https://crrev.com/aca85fb7b0661acec32e99688fc99f6de63b6e69/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp
[add] https://crrev.com/aca85fb7b0661acec32e99688fc99f6de63b6e69/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp
[add] https://crrev.com/aca85fb7b0661acec32e99688fc99f6de63b6e69/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36e4ca5c1a4975972816b84d110c35f70c956798

commit 36e4ca5c1a4975972816b84d110c35f70c956798
Author: toyoshim <toyoshim@chromium.org>
Date: Wed Nov 30 07:50:08 2016

Loading: move FontResource to core/loader/resource

To remove core/ dependency so that core/fetch can be moved under
platform, move FontResource and FontResourceClient classes
to core/loader/resource/.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2501543002
Cr-Commit-Position: refs/heads/master@{#435140}

[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp
[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.h
[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/css/FontFaceCache.cpp
[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/fetch/BUILD.gn
[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/frame/FrameSerializer.cpp
[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/loader/BUILD.gn
[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[rename] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/loader/resource/FontResource.cpp
[rename] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/loader/resource/FontResource.h
[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp
[modify] https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798/third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.h

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09057c54923af5745b85c30e86290643d0fdac7a

commit 09057c54923af5745b85c30e86290643d0fdac7a
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Dec 01 01:13:32 2016

Loading: move *StyleSheetResource to core/loader/resource

To remove core/ dependency so that core/fetch can be moved under
platform, move StyleSheetResource, StyleSheetResourceClient,
CSSStyleSheetResource, and CSSStyleSheetResourceClient classes
to core/loader/resource/.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2504883003
Cr-Commit-Position: refs/heads/master@{#435512}

[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/css/StyleRuleImport.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/css/StyleRuleImport.h
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/css/StyleSheetContents.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/dom/ProcessingInstruction.h
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/fetch/BUILD.gn
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/fetch/DEPS
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/html/LinkStyle.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/html/LinkStyle.h
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/loader/BUILD.gn
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[rename] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp
[rename] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.h
[rename] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResourceTest.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.h
[rename] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/loader/resource/StyleSheetResource.h
[rename] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/loader/resource/StyleSheetResourceClient.h
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/loader/resource/XSLStyleSheetResource.cpp
[modify] https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a/third_party/WebKit/Source/core/loader/resource/XSLStyleSheetResource.h

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87a093df53d87549a8b1d54850b15af9a477bcc5

commit 87a093df53d87549a8b1d54850b15af9a477bcc5
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Dec 02 08:22:34 2016

Loading: move TextResource to core/loader/resource

To remove core/ dependency so that core/fetch can be moved under
platform, move TextResource and TextResourceClient classes
to core/loader/resource/.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2510613002
Cr-Commit-Position: refs/heads/master@{#435885}

[modify] https://crrev.com/87a093df53d87549a8b1d54850b15af9a477bcc5/third_party/WebKit/Source/core/fetch/BUILD.gn
[modify] https://crrev.com/87a093df53d87549a8b1d54850b15af9a477bcc5/third_party/WebKit/Source/core/fetch/DEPS
[modify] https://crrev.com/87a093df53d87549a8b1d54850b15af9a477bcc5/third_party/WebKit/Source/core/loader/BUILD.gn
[modify] https://crrev.com/87a093df53d87549a8b1d54850b15af9a477bcc5/third_party/WebKit/Source/core/loader/resource/DocumentResource.h
[modify] https://crrev.com/87a093df53d87549a8b1d54850b15af9a477bcc5/third_party/WebKit/Source/core/loader/resource/ScriptResource.h
[modify] https://crrev.com/87a093df53d87549a8b1d54850b15af9a477bcc5/third_party/WebKit/Source/core/loader/resource/StyleSheetResource.h
[rename] https://crrev.com/87a093df53d87549a8b1d54850b15af9a477bcc5/third_party/WebKit/Source/core/loader/resource/TextResource.cpp
[rename] https://crrev.com/87a093df53d87549a8b1d54850b15af9a477bcc5/third_party/WebKit/Source/core/loader/resource/TextResource.h

Comment 12 by toyoshim@chromium.org, Dec 2 2016

Summary: Platform/Loader Yukari - Step 1: move Resource(Client) subclasses to core/loader/resources (was: Platform/Loader Yukari - Step 1: collect loading related code into core/loader)

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3d284d7654727b708bddce7b28bb205a6076ca1

commit e3d284d7654727b708bddce7b28bb205a6076ca1
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Dec 13 09:24:30 2016

Loading: split MockResourceClients into multiple files type by type

This patch splits MockResourceClients into MockResourceClient and
MockImageResourceClient, because MemoryCacheTest and ResourceFetcherTest
just need MockResourceClient and do not want to depend on
MockImageResourceClient that has a dependency to ImageResource.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2559703002
Cr-Commit-Position: refs/heads/master@{#438109}

[modify] https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
[modify] https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp
[rename] https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1/third_party/WebKit/Source/core/fetch/MockImageResourceClient.cpp
[add] https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1/third_party/WebKit/Source/core/fetch/MockImageResourceClient.h
[add] https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1/third_party/WebKit/Source/core/fetch/MockResourceClient.cpp
[rename] https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1/third_party/WebKit/Source/core/fetch/MockResourceClient.h
[modify] https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1/third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31d4e7d45fb313e90ff623b769cf5e06265db7ce

commit 31d4e7d45fb313e90ff623b769cf5e06265db7ce
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Dec 13 13:58:43 2016

Loading: remove dependencies from ResourceFetcher to ImageResource

To move ImageResource out of core/fetch, remove unexpected dependencies
from ResourceFetcher to ImageResource.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2510883003
Cr-Commit-Position: refs/heads/master@{#438156}

[modify] https://crrev.com/31d4e7d45fb313e90ff623b769cf5e06265db7ce/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/31d4e7d45fb313e90ff623b769cf5e06265db7ce/third_party/WebKit/Source/core/fetch/ImageResource.h
[modify] https://crrev.com/31d4e7d45fb313e90ff623b769cf5e06265db7ce/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
[modify] https://crrev.com/31d4e7d45fb313e90ff623b769cf5e06265db7ce/third_party/WebKit/Source/core/fetch/Resource.h
[modify] https://crrev.com/31d4e7d45fb313e90ff623b769cf5e06265db7ce/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab9d0bcb41c77781cf482f4937686cc604b41112

commit ab9d0bcb41c77781cf482f4937686cc604b41112
Author: toyoshim <toyoshim@chromium.org>
Date: Wed Dec 14 07:39:20 2016

Loading: Use MockResource in ResourceFetcherTest.cpp

Now tests in ResourceFetcherTest.cpp use ImageResource for testing,
but ImageResource will be moved to core/loader/resource/, and core/fetch
should not have a dependency to the core/loader/.

This patch introduces MockResource and uses it in several tests in
ResourceFetcherTest.cpp.

BUG= 655920 
TEST=webkit_unit_tests --gtest_filter='ResourceFetcherTest.*'

Review-Url: https://codereview.chromium.org/2549093008
Cr-Commit-Position: refs/heads/master@{#438456}

[modify] https://crrev.com/ab9d0bcb41c77781cf482f4937686cc604b41112/third_party/WebKit/Source/core/BUILD.gn
[add] https://crrev.com/ab9d0bcb41c77781cf482f4937686cc604b41112/third_party/WebKit/Source/core/fetch/MockResource.cpp
[add] https://crrev.com/ab9d0bcb41c77781cf482f4937686cc604b41112/third_party/WebKit/Source/core/fetch/MockResource.h
[modify] https://crrev.com/ab9d0bcb41c77781cf482f4937686cc604b41112/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/ab9d0bcb41c77781cf482f4937686cc604b41112/third_party/WebKit/Source/core/fetch/Resource.h
[modify] https://crrev.com/ab9d0bcb41c77781cf482f4937686cc604b41112/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/ab9d0bcb41c77781cf482f4937686cc604b41112/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/ab9d0bcb41c77781cf482f4937686cc604b41112/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f19805a9187b34d8368ada79091c9980c7d83fb2

commit f19805a9187b34d8368ada79091c9980c7d83fb2
Author: toyoshim <toyoshim@chromium.org>
Date: Wed Dec 14 08:58:03 2016

Loading: Use MockResource in MemoryCacheCorrectnessTest.cpp

Now tests in MemoryCacheCorrectnessTest.cpp use ImageResource for
testing, but ImageResource will be moved to core/loader/resource/, and
core/fetch should not have a dependency to the core/loader/.

This patch makes tests in MemoryCacheCorrectnessTest.cpp use
MockResource to remove a dependency to the ImageResource.

BUG= 655920 
TEST=webkit_unit_tests --gtest_filer='MemoryCacheCorrectnessTest.*'

Review-Url: https://codereview.chromium.org/2560763002
Cr-Commit-Position: refs/heads/master@{#438466}

[modify] https://crrev.com/f19805a9187b34d8368ada79091c9980c7d83fb2/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp
[modify] https://crrev.com/f19805a9187b34d8368ada79091c9980c7d83fb2/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp
[modify] https://crrev.com/f19805a9187b34d8368ada79091c9980c7d83fb2/third_party/WebKit/Source/core/fetch/MockResource.cpp
[modify] https://crrev.com/f19805a9187b34d8368ada79091c9980c7d83fb2/third_party/WebKit/Source/core/fetch/MockResource.h

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2873ac755621ee8b3dec722ee17789838625ab68

commit 2873ac755621ee8b3dec722ee17789838625ab68
Author: toyoshim <toyoshim@chromium.org>
Date: Wed Dec 14 09:09:21 2016

Loading: move ImageResource and related classes to core/loader/resource

To move core/dependency so that core/fetch can be moved under
platform, move ImageResource, ImageResourceClient, and related classes
to core/loader/resource/.

After this patch, all dependencies from core/fetch to core/ will be
removed, and core/fetch gets ready to be moved under platform.

BUG= 655920 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2558033002
Cr-Commit-Position: refs/heads/master@{#438468}

[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/clipboard/DataTransfer.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/css/CSSCrossfadeValue.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/css/CSSImageValue.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValue.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/fetch/BUILD.gn
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/fetch/DEPS
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/frame/FrameSerializer.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/layout/LayoutImage.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/layout/LayoutImageResource.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/BUILD.gn
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/ImageLoader.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResourceTest.cpp
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/ImageResource.h
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.h
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/ImageResourceObserver.h
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.h
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/MockImageResourceClient.cpp
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/MockImageResourceClient.h
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParser.cpp
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParser.h
[rename] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParserTest.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/style/ShapeValue.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/style/StyleFetchedImage.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/style/StyleFetchedImage.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/style/StyleFetchedImageSet.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/svg/SVGFEImageElement.h
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/2873ac755621ee8b3dec722ee17789838625ab68/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3d655ba26ec0573d15cfaefb6d05af09e16e484

commit d3d655ba26ec0573d15cfaefb6d05af09e16e484
Author: hiroshige <hiroshige@chromium.org>
Date: Sat Dec 17 18:53:22 2016

Resurrect ImageResourceTest and MultipartImageResourceParserTest

ImageResourceTest.cpp and MultipartImageResourceParserTest.cpp were removed
from BUILD.gn by https://codereview.chromium.org/2558033002/ and thus they
have not been compiled and executed.
This CL resurrects these entries in BUILD.gn and thus re-enabling these tests.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2577073004
Cr-Commit-Position: refs/heads/master@{#439347}

[modify] https://crrev.com/d3d655ba26ec0573d15cfaefb6d05af09e16e484/third_party/WebKit/Source/core/BUILD.gn

Project Member

Comment 19 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13f041896a0a9a9bbca893f9f4fb62ce4b500827

commit 13f041896a0a9a9bbca893f9f4fb62ce4b500827
Author: toyoshim <toyoshim@chromium.org>
Date: Mon Dec 19 09:26:00 2016

Loading: pass minimum information to Resource::resourceTypeToString()

Now Resource::resourceTypeToString() takes const FetchInitiatorInfo&,
but just uses FetchInitiatorInfo.name.

This patch changes the interface to only take const AtomicString& of
FetchInitiatorInfo.name to have minimum dependencies each other.

Also add a static_assert() for FetchInitiatorTypeNames because code
looks easily broken when someone want to add a new type.

This is a preparation to remove binding/core dependency from core/fetch.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2572373003
Cr-Commit-Position: refs/heads/master@{#439442}

[modify] https://crrev.com/13f041896a0a9a9bbca893f9f4fb62ce4b500827/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/13f041896a0a9a9bbca893f9f4fb62ce4b500827/third_party/WebKit/Source/core/fetch/Resource.h
[modify] https://crrev.com/13f041896a0a9a9bbca893f9f4fb62ce4b500827/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/13f041896a0a9a9bbca893f9f4fb62ce4b500827/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5daea93d2ae560a310f341015ec9d21b0fcfea77

commit 5daea93d2ae560a310f341015ec9d21b0fcfea77
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Dec 20 15:18:27 2016

Loading: move V8DOMActivityLogger dependency from core/fetch

Now, core/fetch has a dependency to bindings/core/, but this won't be
permitted once the directory is moved to platform/loader/fetch.

This patch moves this last unexpected dependency, and make it
finally possible to move under platform/.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2578983002
Cr-Commit-Position: refs/heads/master@{#439806}

[modify] https://crrev.com/5daea93d2ae560a310f341015ec9d21b0fcfea77/third_party/WebKit/Source/core/fetch/DEPS
[modify] https://crrev.com/5daea93d2ae560a310f341015ec9d21b0fcfea77/third_party/WebKit/Source/core/fetch/FetchContext.cpp
[modify] https://crrev.com/5daea93d2ae560a310f341015ec9d21b0fcfea77/third_party/WebKit/Source/core/fetch/FetchContext.h
[modify] https://crrev.com/5daea93d2ae560a310f341015ec9d21b0fcfea77/third_party/WebKit/Source/core/fetch/FetchRequest.h
[modify] https://crrev.com/5daea93d2ae560a310f341015ec9d21b0fcfea77/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/5daea93d2ae560a310f341015ec9d21b0fcfea77/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/5daea93d2ae560a310f341015ec9d21b0fcfea77/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/5daea93d2ae560a310f341015ec9d21b0fcfea77/third_party/WebKit/Source/core/loader/PingLoader.cpp

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17d77116e97bade618e29ce717c26ed88e439dc7

commit 17d77116e97bade618e29ce717c26ed88e439dc7
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Jan 17 11:01:23 2017

MemoryCacheCorrectnessTest: Fix a test name typo

RequestWithNoCahe should be RequestWithNoCache.

BUG= 655920 
TEST=ninja webkit_unit_tests

Review-Url: https://codereview.chromium.org/2638653008
Cr-Commit-Position: refs/heads/master@{#444020}

[modify] https://crrev.com/17d77116e97bade618e29ce717c26ed88e439dc7/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a568e5096fc65ebf8f338288000dac8fffadc84

commit 2a568e5096fc65ebf8f338288000dac8fffadc84
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Jan 17 11:08:00 2017

RawResourceTest: Use loadingTaskRunner to be balanced with Resource

ResourceCallback::schedule() was changed to use loadingTaskRunner
instead of Timer, but RawResourceTest is still using a Timer to remove
a client from a Resource. Since tests expects tasks are scheduled
sequentially, we should use the same infrastructure to run asynchronous
tasks for both Resource and tests.

Tests work without task reordering at this point, but tests fail
due to reordering if this file is moved under platform and run with
TestingPlatformSupportWithMockScheduler.

TEST=webkit_unit_tests --ftest_filter=RawResourceTest.AddClientDuringCallback
BUG= 655920 

Review-Url: https://codereview.chromium.org/2631093004
Cr-Commit-Position: refs/heads/master@{#444022}

[modify] https://crrev.com/2a568e5096fc65ebf8f338288000dac8fffadc84/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ef6d3ba0eecb7bbc12671f83ac8adfea0b9c00b

commit 2ef6d3ba0eecb7bbc12671f83ac8adfea0b9c00b
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Jan 17 11:24:52 2017

Remove TestingPlatformMockScheduler

Since TestingPlatformMockScheduler is used only in IdleDeadlineTest,
this patch removes TestingPlatformMockScheduler from
TestingPlatformSupport, and implements it directly inside
IdleDeadlineTest as MockScheduler.

This will also help to avoid misunderstanding that
TestingPlatformSupportWithMockScheduler uses
TestingPlatformMockScheduler.
Actually, it uses scheduler::RendererSchedulerImpl with
cc::OrderedSimpleTaskRunner.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2633293003
Cr-Commit-Position: refs/heads/master@{#444025}

[modify] https://crrev.com/2ef6d3ba0eecb7bbc12671f83ac8adfea0b9c00b/third_party/WebKit/Source/core/dom/IdleDeadlineTest.cpp
[modify] https://crrev.com/2ef6d3ba0eecb7bbc12671f83ac8adfea0b9c00b/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp
[modify] https://crrev.com/2ef6d3ba0eecb7bbc12671f83ac8adfea0b9c00b/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h

Project Member

Comment 24 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b6c57a4011db4ae08c5b70c9029633796802582

commit 7b6c57a4011db4ae08c5b70c9029633796802582
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Jan 19 06:21:18 2017

Use MockResource as much as possibler in MemoryCacheCorrectnessTest

This patch modifies MemoryCacheCorrectnessTest to use MockResource
instead of RawResource as much as possible, and to use MockResource*
or RawResource* rather than Resource* to hold references so that
EXPECT_EQ can force to use a right resource type for testing.

Now we have two unit tests that require RawResource to use
fetchSynchronously() and willFollowRedirect().

Also, since we do not have any other tests that use
MemorycacheCorrectnessTestHelper any more, this patch merges the file
to MemoryCacheCorrectnessTest.

TEST=webkit_unit_tests --gtest_filter=MemoryCacheCorrectnessTest.\*
BUG= 655920 

Review-Url: https://codereview.chromium.org/2637063002
Cr-Commit-Position: refs/heads/master@{#444664}

[modify] https://crrev.com/7b6c57a4011db4ae08c5b70c9029633796802582/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/7b6c57a4011db4ae08c5b70c9029633796802582/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp
[delete] https://crrev.com/fe5b80deb66d94a110ef347739f3f7e8d7d164c5/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.cpp
[delete] https://crrev.com/fe5b80deb66d94a110ef347739f3f7e8d7d164c5/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTestHelper.h
[modify] https://crrev.com/7b6c57a4011db4ae08c5b70c9029633796802582/third_party/WebKit/Source/core/fetch/RawResource.cpp
[modify] https://crrev.com/7b6c57a4011db4ae08c5b70c9029633796802582/third_party/WebKit/Source/core/fetch/RawResource.h

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e13f57fbda95f7260cdfb7c7610fcdeeb36e1991

commit e13f57fbda95f7260cdfb7c7610fcdeeb36e1991
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Jan 19 08:33:22 2017

Remove STACK_ALLOCATED() from ScopedTestingPlatformSupport

Since I have seen some use cases where it's beneficial to have
ScopedTestingPlatformSupport as a member variable, let's make
ScopedTestingPlatformSupport available as a member variable.

It's usual that tests need to initialize something after the
mocked platform is registered. If we could have the
ScopedTestingPlatformSupport as a member, we can have such
initialization code in testing::Test::SetUp(). This can remove
many boilerplate code from each test definition.

Also, some tests need to have a helper methods that access to
the ScopedTestingPlatformSupport. In such case, having it as
a member makes code much simple.

BUG= 655920 
TEST=webkit_unit_tests
TBR=hongchan@chromium.org

Review-Url: https://codereview.chromium.org/2645733003
Cr-Commit-Position: refs/heads/master@{#444683}

[modify] https://crrev.com/e13f57fbda95f7260cdfb7c7610fcdeeb36e1991/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
[modify] https://crrev.com/e13f57fbda95f7260cdfb7c7610fcdeeb36e1991/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
[modify] https://crrev.com/e13f57fbda95f7260cdfb7c7610fcdeeb36e1991/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/e13f57fbda95f7260cdfb7c7610fcdeeb36e1991/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
[modify] https://crrev.com/e13f57fbda95f7260cdfb7c7610fcdeeb36e1991/third_party/WebKit/Source/platform/TimerTest.cpp
[modify] https://crrev.com/e13f57fbda95f7260cdfb7c7610fcdeeb36e1991/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h

Project Member

Comment 26 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4105bfeb59cd108955521f923dc7731939f07de8

commit 4105bfeb59cd108955521f923dc7731939f07de8
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Jan 19 16:31:54 2017

Use TestingPlatformSupportWithMockScheduler to use mocked Time

Now MemoryCacheCorrectnessTest implements an original TimeFunction for
testing, but it's available via TestingPlatformSupportWithMockScheduler.

Because MemoryCacheCorrectnessTest needs to use
TestingPlatformSupportWithMockScheduler once it is moved to platform,
and to keep using the original TimeFunction costs a little to avoid
conflicting with TestingPlatformSupportWithMockScheduler's one,
let's use TestingPlatformSupportWithMockScheduler version beforehand.

BUG= 655920 
TEST=webkit_unit_tests --gtest_filter=MemoryCacheCorrectnessTest.\*

Review-Url: https://codereview.chromium.org/2631383003
Cr-Commit-Position: refs/heads/master@{#444763}

[modify] https://crrev.com/4105bfeb59cd108955521f923dc7731939f07de8/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp

Project Member

Comment 27 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/284fe71823b4516ac5630addd2f44788347ddd07

commit 284fe71823b4516ac5630addd2f44788347ddd07
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Jan 24 04:20:50 2017

ResourceFetcherTest: introduce FetchTestingPlatformSupport

To move ResourceFetcherTest under platform, we need to use
TestingPlatformSupportWithMockScheduler and to make
WebURLLoaderMockFactory available with the MockScheduler.

FetchTestingPlatformSupport is the TestingPlatformSupport
inheritance that adds WebURLLoaderMockFactory and FetchContext
support. At this point, only ResourceFetcherTest use the
FetchTestingplatformSupport, but eventually, other tests
may want to use it.

Also this patch contains modifications to remove cached resources
and all mock URL entries so that we can cleanup each test safely.

This is needed to pass LinkPreloadResourceMultipleFetchersAnd{Use|Move}
without any retry.

BUG= 655920 
TEST=webkit_unit_tests --gtest_filter='ResourceFetcherTest.*'

Review-Url: https://codereview.chromium.org/2644083003
Cr-Commit-Position: refs/heads/master@{#445639}

[modify] https://crrev.com/284fe71823b4516ac5630addd2f44788347ddd07/third_party/WebKit/Source/core/BUILD.gn
[add] https://crrev.com/284fe71823b4516ac5630addd2f44788347ddd07/third_party/WebKit/Source/core/fetch/FetchTestingPlatformSupport.cpp
[add] https://crrev.com/284fe71823b4516ac5630addd2f44788347ddd07/third_party/WebKit/Source/core/fetch/FetchTestingPlatformSupport.h
[modify] https://crrev.com/284fe71823b4516ac5630addd2f44788347ddd07/third_party/WebKit/Source/core/fetch/MockFetchContext.h
[modify] https://crrev.com/284fe71823b4516ac5630addd2f44788347ddd07/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/284fe71823b4516ac5630addd2f44788347ddd07/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp
[modify] https://crrev.com/284fe71823b4516ac5630addd2f44788347ddd07/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
[modify] https://crrev.com/284fe71823b4516ac5630addd2f44788347ddd07/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc
[modify] https://crrev.com/284fe71823b4516ac5630addd2f44788347ddd07/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h

Project Member

Comment 28 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc

commit ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Jan 24 17:36:42 2017

Loading: move core/fetch to platform/loader/fetch

Now that core/fetch does not have any unexpected dependency,
we can move it under platform.

BUG= 655920 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2584423002
Cr-Commit-Position: refs/heads/master@{#445751}

[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/bindings/core/v8/ScriptController.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/CoreInitializer.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/css/CSSImageValue.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/css/FontFaceCache.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/css/StyleRuleImport.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/css/cssom/CSSResourceValue.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/css/parser/CSSParserContext.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/dom/DOMURL.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/dom/PendingScript.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/dom/ProcessingInstruction.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/dom/ScriptLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/editing/Editor.cpp
[delete] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/third_party/WebKit/Source/core/fetch/BUILD.gn
[delete] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/third_party/WebKit/Source/core/fetch/DEPS
[delete] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/third_party/WebKit/Source/core/fetch/FetchTestingPlatformSupport.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/SubresourceIntegrity.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/HTMLDocument.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/HTMLImageElement.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/LinkResource.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/LinkStyle.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/imports/HTMLImportLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/html/parser/PreloadRequest.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/layout/LayoutImage.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/DocumentLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/FrameClientHintsPreferencesContext.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/FrameLoadRequest.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/FrameLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/FrameLoaderClient.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/HttpEquiv.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/LinkLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/LinkLoaderClient.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/PingLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/TextTrackLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/ThreadableLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResourceTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/DocumentResource.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/DocumentResource.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/FontResource.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/FontResource.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/ImageResource.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/LinkFetchResource.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/LinkFetchResource.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h
[add] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/MockImageResourceClient.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/ScriptResource.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/StyleSheetResourceClient.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/TextResource.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/loader/resource/XSLStyleSheetResource.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/paint/FramePainter.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/workers/WorkletScriptLoader.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/xml/XSLImportRule.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/fetch/FetchResponseData.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/fetch/Headers.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/fetch/Response.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoaderTest.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.h
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/BUILD.gn
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/OWNERS
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/AccessControlStatus.h
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/CachePolicy.h
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/CachedMetadata.cpp
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/CachedMetadata.h
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/CachedMetadataHandler.h
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/ClientHintsPreferences.cpp
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/ClientHintsPreferences.h
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/ClientHintsPreferencesTest.cpp
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.h
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControlTest.cpp
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/FetchContext.cpp
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/FetchInitiatorInfo.h
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/FetchInitiatorTypeNames.in
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/FetchRequest.cpp
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/FetchRequest.h
[add] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader/fetch/FetchTestingPlatformSupport.cpp
[rename] https://crrev.com/ecbfcdcef3fa7692d28b32aeb0c89e9a5e5c4ebc/third_party/WebKit/Source/platform/loader

Project Member

Comment 29 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea8d9b39ef5247a3ff4ad2bbe8610d6bfd62dff2

commit ea8d9b39ef5247a3ff4ad2bbe8610d6bfd62dff2
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Jan 26 09:28:11 2017

ResourceFetcherTest: cleanup finalization

Now the test cleanups WebURLLoaderMockFactory in TearDown, but
it would be better to do them in FetchTestingPlatformSupport's
destructor because it owns WebURLLoaderMockFactory.

TEST=blink_platform_unittests
BUG= 655920 

Review-Url: https://codereview.chromium.org/2657583004
Cr-Commit-Position: refs/heads/master@{#446283}

[modify] https://crrev.com/ea8d9b39ef5247a3ff4ad2bbe8610d6bfd62dff2/third_party/WebKit/Source/platform/loader/fetch/FetchTestingPlatformSupport.cpp
[modify] https://crrev.com/ea8d9b39ef5247a3ff4ad2bbe8610d6bfd62dff2/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

Project Member

Comment 30 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fa47a4664f18f8f4a2d28408ff4754eb600aaf4

commit 0fa47a4664f18f8f4a2d28408ff4754eb600aaf4
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Jan 26 13:32:25 2017

Make WebURLLoaderMockFactoryImpl::createURLLoader accept nullptr

Now a valid instance of WebURLLoader is required to create a
WebURLLoaderMock instance through createURLLoader() so that
it can have defaultLoader, a WebURLLoader for fallbacks.

But, in most cases, it can work without defaultLoader since
many tests are designed to use mocked URLs that would be
served from files directly without using defaultLoader.

In blink_platform_tests, default Platform::current() does not
return a valid instance for createURLLoader(). So allowing
nullptr would be useful.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2657793002
Cr-Commit-Position: refs/heads/master@{#446316}

[modify] https://crrev.com/0fa47a4664f18f8f4a2d28408ff4754eb600aaf4/third_party/WebKit/Source/platform/loader/fetch/FetchTestingPlatformSupport.cpp
[modify] https://crrev.com/0fa47a4664f18f8f4a2d28408ff4754eb600aaf4/third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc
[modify] https://crrev.com/0fa47a4664f18f8f4a2d28408ff4754eb600aaf4/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fabb1af2315f0b6fc685118b7c25b726bf3f94e

commit 8fabb1af2315f0b6fc685118b7c25b726bf3f94e
Author: toyoshim <toyoshim@chromium.org>
Date: Mon Feb 06 11:03:57 2017

platform/testing/{URL|Unit}TestHelpers improvements

URLTestHelpers assumed that the test directory is web/tests/data.
But for blink_platform_tests, we didn't have a dependency to
web/tests/data in build rules, and should use platform/testing/data
instead of web/tests/data.

This patch revises URLTestHelpers so that it works without knowing
where the test directory is, and adds interfaces that provide
test directories for web and platform.

Also this patch does some refactoring changes against caller side
files so that these interface changes should not affect so much.

Some tests that directly had test directory path literals are
fixed to use UnitTestHelpers to obtain fullpaths for test files.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2654933003
Cr-Commit-Position: refs/heads/master@{#448227}

[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoaderTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/platform/fonts/FontPlatformDataTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/platform/fonts/FontTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/platform/testing/URLTestHelpers.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/platform/testing/URLTestHelpers.h
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[add] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/platform/testing/data/white-1x1.png
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/WebAssociatedURLLoaderImplTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/ViewportTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/WebDocumentTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/WebImageTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/WebSearchableFormDataTest.cpp
[modify] https://crrev.com/8fabb1af2315f0b6fc685118b7c25b726bf3f94e/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Project Member

Comment 32 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ad7d8b5293d72bbf08f72d65bb0e9d343437bad

commit 9ad7d8b5293d72bbf08f72d65bb0e9d343437bad
Author: toyoshim <toyoshim@chromium.org>
Date: Wed Feb 08 13:22:00 2017

Generalize ScopedRegisteredURL as ScopedMockedURL*

ImageResourceTest had ScopedRegisteredURL implementation, but this
is a useful scheme for every tests that use URLTestHelpers.

This patch creates ScopedMockedURL.{cpp|h} to have ScopedMockedURL
and its variants, and makes ImageResourceTest use one of them.

Eventually, we would like to obsolete URLTestHelpers.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2680723002
Cr-Commit-Position: refs/heads/master@{#448974}

[modify] https://crrev.com/9ad7d8b5293d72bbf08f72d65bb0e9d343437bad/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/9ad7d8b5293d72bbf08f72d65bb0e9d343437bad/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/9ad7d8b5293d72bbf08f72d65bb0e9d343437bad/third_party/WebKit/Source/platform/testing/ScopedMockedURL.cpp
[add] https://crrev.com/9ad7d8b5293d72bbf08f72d65bb0e9d343437bad/third_party/WebKit/Source/platform/testing/ScopedMockedURL.h
[modify] https://crrev.com/9ad7d8b5293d72bbf08f72d65bb0e9d343437bad/third_party/WebKit/Source/platform/testing/URLTestHelpers.cpp
[modify] https://crrev.com/9ad7d8b5293d72bbf08f72d65bb0e9d343437bad/third_party/WebKit/Source/platform/testing/URLTestHelpers.h

Comment 33 by toyoshim@chromium.org, Feb 9 2017

Status: Fixed (was: Started)

Project Member

Comment 34 by bugdroid1@chromium.org, Feb 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f957e754783252a60497ab095b9d430cd5f73b3

commit 9f957e754783252a60497ab095b9d430cd5f73b3
Author: hiroshige <hiroshige@chromium.org>
Date: Sun Feb 12 03:44:05 2017

Remove unintendedly resurrected MockImageResourceClient.h

This CL removes MockImageResourceClient.h that
https://codereview.chromium.org/2584423002 seems to resurrect
unintendedly.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2680163010
Cr-Commit-Position: refs/heads/master@{#449884}

[modify] https://crrev.com/9f957e754783252a60497ab095b9d430cd5f73b3/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[delete] https://crrev.com/ba312ce74654e54790202de6afa9987d38a7965b/third_party/WebKit/Source/core/loader/resource/MockImageResourceClient.h

Project Member

Comment 35 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96ce5a090b950b68977e03b4c8f5e10d5ab8949d

commit 96ce5a090b950b68977e03b4c8f5e10d5ab8949d
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Feb 17 05:03:41 2017

Loading: use MockFetchContext in ImageResourceTest

ImageResourceTest still has a FetchContext subclass for testing.
But MockFetchContext can replace it.

BUG= 655920 

Review-Url: https://codereview.chromium.org/2692203008
Cr-Commit-Position: refs/heads/master@{#451221}

[modify] https://crrev.com/96ce5a090b950b68977e03b4c8f5e10d5ab8949d/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/96ce5a090b950b68977e03b4c8f5e10d5ab8949d/third_party/WebKit/Source/platform/loader/fetch/MockFetchContext.h

►

Issue 655920 link

Issue metadata

Platform/Loader Yukari - Step 1: move Resource(Client) subclasses to core/loader/resources

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 14 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Oct 14 2016

Comment 2 Deleted

Comment 3 Deleted

Comment 4 by toyoshim@chromium.org, Nov 11 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Nov 14 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Nov 16 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Nov 17 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Nov 30 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Nov 30 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Dec 1 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Dec 2 2016

Comment 11 Deleted

Comment 12 by toyoshim@chromium.org, Dec 2 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Dec 13 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Dec 13 2016

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Dec 14 2016

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Dec 14 2016

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Dec 14 2016

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Dec 17 2016

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Dec 19 2016

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Dec 20 2016

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Jan 17 2017

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Jan 17 2017

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Jan 17 2017

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Jan 19 2017

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Jan 19 2017

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Jan 19 2017

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Jan 24 2017

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Jan 24 2017

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Jan 26 2017

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Jan 26 2017

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Feb 6 2017

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Feb 8 2017

Comment 32 Deleted

Comment 33 by toyoshim@chromium.org, Feb 9 2017

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Feb 12 2017

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Feb 17 2017

Comment 35 Deleted

Sign in to add a comment