[Native] doesn't work for interface enums |
||
Issue description
The following doesn't seem to work:
interface Foo {
[Native]
enum Bar;
}
In mojom-shared.h, I see
using Bar = mojo::NativeEnum;
But everywhere else Bar is referred as Foo_Bar, which becomes undeclared.
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50ba000ec3132d4b12f55b1ff46e08407843e605 commit 50ba000ec3132d4b12f55b1ff46e08407843e605 Author: rockot <rockot@chromium.org> Date: Fri Oct 14 17:30:22 2016 Generate the correct C++ symbol name for scoped native enums BUG= 655919 TBR=yzshen@chromium.org Review-Url: https://codereview.chromium.org/2413093004 Cr-Commit-Position: refs/heads/master@{#425373} [modify] https://crrev.com/50ba000ec3132d4b12f55b1ff46e08407843e605/mojo/public/tools/bindings/generators/cpp_templates/module-shared.h.tmpl
,
Oct 14 2016
,
Oct 14 2016
Does it make sense to add a test in test_native_types.mojom to cover this? https://cs.chromium.org/chromium/src/mojo/public/interfaces/bindings/tests/test_native_types.mojom?q=test_native_types.mojom&sq=package:chromium&dr
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efd2ed209baaa86c49442114e1d812bc19808034 commit efd2ed209baaa86c49442114e1d812bc19808034 Author: xhwang <xhwang@chromium.org> Date: Fri Oct 14 22:18:08 2016 More fix on generating correct C++ symbol name for scoped native enums This is a follow up of https://crrev.com/50ba000ec3132d4b12f55b1ff46e08407843e605 R=rockot@chromium.org BUG= 655919 TEST=Tested locally Review-Url: https://codereview.chromium.org/2419163002 Cr-Commit-Position: refs/heads/master@{#425492} [modify] https://crrev.com/efd2ed209baaa86c49442114e1d812bc19808034/mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl |
||
►
Sign in to add a comment |
||
Comment 1 by xhw...@chromium.org
, Oct 14 2016