New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655901 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Can't open downloaded mp3 file

Project Member Reported by benwells@chromium.org, Oct 14 2016

Issue description

Version: Chroem Dev 55.0.2883.9
OS: Android 7.0.0; Nexus 5X

What steps will reproduce the problem?
1. download an mp3. I got one via http://www.factmag.com/2016/10/13/the-xx-fact-mix-classic/
2. go to downloads
3. tap the mp3

What is the expected output?
The mp3 is opened in an app that can play mp3s

What do you see instead?
Chrome says 'Can't open file'. When I opened Google Play it had already noticed the MP3 and made it available.


Please use labels and text to provide additional information.

 
Cc: dfalcant...@chromium.org
Labels: M-55 ReleaseBlock-Stable
Owner: qin...@chromium.org
Status: Assigned (was: Untriaged)
Don't know why this would block stable, but I'm guessing it's a MIME type issue because it's not registering as an audio file when I open downloads (there's no music note).  I believe Min mentioned that servers were bad about this kind of thing.

The mp3 I downloaded from http://soundhelix.com/audio-examples worked fine.
Screenshot (Oct 14, 2016 11-28-19 AM).png
141 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17963656406b00fd2050bc567e85041cbca3a55c

commit 17963656406b00fd2050bc567e85041cbca3a55c
Author: qinmin <qinmin@chromium.org>
Date: Fri Oct 14 22:12:09 2016

Remap MIME type when loading download items from history db

Chrome remaps MIME type when inserting download into Android
DownloadManager.
That allows media file to play properly if they use generic MIME type.
However, this doesn't affect the MIME type stored in download history.
And when loading the history item into download home, we should do the
same thing.

BUG= 655901 

Review-Url: https://codereview.chromium.org/2423563002
Cr-Commit-Position: refs/heads/master@{#425489}

[modify] https://crrev.com/17963656406b00fd2050bc567e85041cbca3a55c/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
[modify] https://crrev.com/17963656406b00fd2050bc567e85041cbca3a55c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Comment 4 by qin...@chromium.org, Oct 17 2016

Labels: Merge-Request-55
Status: Started (was: Assigned)

Comment 5 by dimu@chromium.org, Oct 17 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1670b4e649db6e170f0e23968fa20d48f0e9bc99

commit 1670b4e649db6e170f0e23968fa20d48f0e9bc99
Author: Min Qin <qinmin@chromium.org>
Date: Mon Oct 17 19:31:10 2016

Remap MIME type when loading download items from history db

Chrome remaps MIME type when inserting download into Android
DownloadManager.
That allows media file to play properly if they use generic MIME type.
However, this doesn't affect the MIME type stored in download history.
And when loading the history item into download home, we should do the
same thing.

TBR=dfalcantara@chromium.org
BUG= 655901 

Review-Url: https://codereview.chromium.org/2423563002
Cr-Commit-Position: refs/heads/master@{#425489}
(cherry picked from commit 17963656406b00fd2050bc567e85041cbca3a55c)

Review URL: https://codereview.chromium.org/2429633002 .

Cr-Commit-Position: refs/branch-heads/2883@{#156}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/1670b4e649db6e170f0e23968fa20d48f0e9bc99/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
[modify] https://crrev.com/1670b4e649db6e170f0e23968fa20d48f0e9bc99/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Comment 7 by qin...@chromium.org, Oct 17 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in M55-55.0.2883.18 build

Comment 9 by qin...@chromium.org, Oct 19 2016

Cc: twelling...@chromium.org dah...@chromium.org ian...@chromium.org qin...@chromium.org asanka@chromium.org
 Issue 657590  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1670b4e649db6e170f0e23968fa20d48f0e9bc99

commit 1670b4e649db6e170f0e23968fa20d48f0e9bc99
Author: Min Qin <qinmin@chromium.org>
Date: Mon Oct 17 19:31:10 2016

Remap MIME type when loading download items from history db

Chrome remaps MIME type when inserting download into Android
DownloadManager.
That allows media file to play properly if they use generic MIME type.
However, this doesn't affect the MIME type stored in download history.
And when loading the history item into download home, we should do the
same thing.

TBR=dfalcantara@chromium.org
BUG= 655901 

Review-Url: https://codereview.chromium.org/2423563002
Cr-Commit-Position: refs/heads/master@{#425489}
(cherry picked from commit 17963656406b00fd2050bc567e85041cbca3a55c)

Review URL: https://codereview.chromium.org/2429633002 .

Cr-Commit-Position: refs/branch-heads/2883@{#156}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/1670b4e649db6e170f0e23968fa20d48f0e9bc99/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
[modify] https://crrev.com/1670b4e649db6e170f0e23968fa20d48f0e9bc99/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Comment 11 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 12 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment