cros_repair: Verifiy fails due to "Battery is less than 50%" (old battery) |
||
Issue descriptionLooking at this test result: https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/hosts/chromeos1-row3-rack1-host6/234604-verify/20161310144334/debug/ 10/13 14:43:47.985 ERROR| verify:0025| Battery is less than 50% Python is missing; may be caused by powerwash ... AutoservVerifyDependencyError: Battery is less than 50% # ssh chromeos1-row3-rack1-host6.cros power_supply_info Device: Line Power path: /sys/class/power_supply/AC online: yes type: Mains enum type: AC voltage (V): 0 current (A): 0 [1013/181624:WARNING:power_supply.cc(981)] Ignoring probably-bogus zero battery percentage max voltage (V): 0 max current (A): 0 active source: AC available sources: AC* [/] supports dual-role: no Device: Battery path: /sys/class/power_supply/BATX vendor: SANYO model name: serial number: 0000000000004210 state: Discharging voltage (V): 0.159 energy (Wh): 0 energy rate (W): 0.000159 current (A): 0.001 charge (Ah): 0 full charge (Ah): 2.386 full charge design (Ah): 2.5 percentage: 0 display percentage: 0 technology: Li-ion The battery on this device is indeed dead, but that does not prevent it from running tests (especially in our pool:crouton). I could trace back to https://chromium-review.googlesource.com/#/c/331751/, which added a >50% battery test. I understand that having a full enough battery is critical for some tests, but shouldn't the dependency be added to the specific tests? Or maybe we could add an autotest label to indicate that the DUT's battery is dead, but we still want verify to pass?
,
Oct 17 2016
We'd like to keep the testing environment same for all duts and want to avoid situations where a draining battery can aversely affect test results. We'll mark this a wont-fix, if you really would like this feature, we'll need to do a much deeper evaluation of the benefits for this.
,
Oct 17 2016
Sounds reasonable, thanks for the replies. |
||
►
Sign in to add a comment |
||
Comment 1 by jrbarnette@chromium.org
, Oct 14 2016Labels: -Type-Bug Type-Feature
Owner: ----
We don't currently have the ability to tailor verification checks to particular tests. As a practical matter, although the battery check is sometimes for the benefit of specific tests (e.g. power tests), it's also a way of finding and reporting failures: * We've had cases where devices actually had AC power unplugged, and wanted it to be reported before the battery drained and the DUT went down. * We've had software bugs where the device couldn't detect AC power; this verifier puts such bugs front and center.