New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655879 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Stop showing low-space notifications in guest mode

Project Member Reported by fukino@chromium.org, Oct 14 2016

Issue description

In guest mode, it doesn't make much sense to warn users that the storage is low and saved files can be deleted.
Let's stop showing them in guest mode. (and maybe ephemeral users)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44a5f92dde8b3cb2fa8d54b02fa97d08f0ee494a

commit 44a5f92dde8b3cb2fa8d54b02fa97d08f0ee494a
Author: dspaid <dspaid@chromium.org>
Date: Mon Oct 17 23:59:36 2016

Do not watch for low disk events in guest mode.

Guest sessions do not store data on the persistent disk and therefore
should not receive notifications regarding low disk space.

BUG= 655879 
TEST=Log in to device as non-guest
Create a sufficiently large file in Downloads to trigger low disk notifications
Log out
Log in as guest user
Observe that no low disk notification is shown.

Review-Url: https://codereview.chromium.org/2420843002
Cr-Commit-Position: refs/heads/master@{#425823}

[modify] https://crrev.com/44a5f92dde8b3cb2fa8d54b02fa97d08f0ee494a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Owner: weifangsun@chromium.org
Status: Assigned (was: Available)
Labels: M-67

Comment 4 by sashab@chromium.org, Feb 16 2018

Labels: CrOS-FilesApp-StorageMgmt
<files-triage> Weifang, is this fixed? :)

Comment 5 by sashab@chromium.org, Feb 20 2018

Labels: -CrOS-FilesApp-StorageMgmt

Comment 6 by sashab@chromium.org, Feb 20 2018

Labels: CrOS-FilesApp-LowStorage
Cc: -mitsuji@chromium.org -fukino@chromium.org weifangsun@chromium.org
Owner: fukino@chromium.org
<files-triage> fukino@ - Looks like you made a commit for this issue. Are we still seeing this?

Comment 8 by fukino@chromium.org, Feb 22 2018

Status: Fixed (was: Assigned)
Oops, it seems I forgot to mark this as Fixed.

Sign in to add a comment