New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655876 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX

Blocked on:
issue 543635
issue 654638
issue 656758
issue 709171


Participants' hotlists:
Security-UX-Consistency


Sign in to add a comment

Change "Site settings" link in Page Info to point to per-site view Material Page Info

Project Member Reported by lgar...@chromium.org, Oct 14 2016

Issue description

This works on Android, but Desktop has been gated on Material site settings for... a long time.
 

Comment 1 by dbeam@chromium.org, Oct 14 2016

Cc: dschuyler@chromium.org groby@chromium.org
hey Lucas!  let us know if you're interested in helping with site settings on desktop.  we're making changes like you saw in  bug 654638  to address the "long time" part ;) but we'll be sure to bring "site settings" fully to desktop soon after!
Components: UI>Browser>Omnibox>PageInfo
Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo
Labels: -Hotlist-PageInfo
Blockedon: 656758
Blockedon: 709171
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a21a04cf272f00d9478450dd072c113abe2d4b9c

commit a21a04cf272f00d9478450dd072c113abe2d4b9c
Author: Patricia Lor <patricialor@chromium.org>
Date: Mon Jun 05 04:14:56 2017

Desktop Page Info: Point "Site settings" link to "Site Details" when enabled.

If the "Site Details" page (found in Chrome's MD Settings) is enabled,
(i.e. #enable-site-details or #enable-site-settings is on), allow the user to
navigate to the "Site Details" of the origin they are currently visiting via
clicking the "Site settings" link at the bottom of the Page Info bubble.

BUG= 655876 ,  656758 
TEST=With the #enable-site-details and/or the #enable-site-settings flag turned
on, navigate to https://www.permission.site/. Open the Page Info bubble by
clicking on the icon next to the URL in the Omnibox. At the bottom of the
bubble, click "Site settings". This should take you to
With both flags off, repeating the above steps should open a new tab with
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

chrome: //settings/content/siteDetails?site=https%3A%2F%2Fpermission.site%2F.
chrome: //settings/content
Change-Id: I6778534923ad2df5b15175ad476686b8491da7b3
Reviewed-on: https://chromium-review.googlesource.com/504067
Commit-Queue: Patricia Lor <patricialor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mike West <mkwst@google.com>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476937}
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/browser/ui/page_info/page_info.h
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/browser/ui/view_ids.h
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/browser/ui/views/page_info/page_info_bubble_view.h
[add] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/browser/ui/views/page_info/page_info_bubble_view_browsertest.cc
[delete] https://crrev.com/c3e34b2e51926d4b133aee54d3db4608c94707f3/chrome/browser/ui/views/page_info/page_info_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/common/url_constants.cc
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/common/url_constants.h
[modify] https://crrev.com/a21a04cf272f00d9478450dd072c113abe2d4b9c/chrome/test/BUILD.gn

Owner: patricia...@chromium.org
Status: Fixed (was: Available)
Belatedly marking this fixed (with #enable-site-details or #enable-site-settings on).

Sign in to add a comment