New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655872 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Page Info buttons/links are hooked up wrong in Views.

Project Member Reported by lgar...@chromium.org, Oct 14 2016

Issue description

e.g. "Re-enable warnings" opens DevTools.
 
Components: Security>UX
Labels: Hotlist-PageInfo OS-Chrome OS-Linux OS-Mac OS-Windows
Cc: emilyschechter@chromium.org
Labels: ReleaseBlock-Stable
CL at https://crrev.com/2422473002
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/633c166bf730a58a847a6705c46ec08989a74db0

commit 633c166bf730a58a847a6705c46ec08989a74db0
Author: lgarron <lgarron@chromium.org>
Date: Fri Oct 14 18:43:14 2016

Fix wiring for Page Info buttons/links.

This also includes a partial revert of
crrev.com/0af7d0edfddd038461850cbc8957f1fba1686df9 to force proper sizing of the "Re-enable warnings" styled label.

BUG= 655872 

Review-Url: https://codereview.chromium.org/2422473002
Cr-Commit-Position: refs/heads/master@{#425401}

[modify] https://crrev.com/633c166bf730a58a847a6705c46ec08989a74db0/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Cc: lgar...@chromium.org
 Issue 646057  has been merged into this issue.
Labels: Merge-Request-55
All buttons verified in Chrome 56.0.2891.0 on on Windows 10. Asking for a merge to M55.

Comment 6 by dimu@chromium.org, Oct 17 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 17 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c13b91b536abd1fb4f09e19fceee985380407998

commit c13b91b536abd1fb4f09e19fceee985380407998
Author: Lucas Garron <lgarron@chromium.org>
Date: Mon Oct 17 22:58:00 2016

Fix wiring for Page Info buttons/links.

This also includes a partial revert of
crrev.com/0af7d0edfddd038461850cbc8957f1fba1686df9 to force proper sizing of the "Re-enable warnings" styled label.

BUG= 655872 

Review-Url: https://codereview.chromium.org/2422473002
Cr-Commit-Position: refs/heads/master@{#425401}
(cherry picked from commit 633c166bf730a58a847a6705c46ec08989a74db0)

Review URL: https://codereview.chromium.org/2429693002 .

Cr-Commit-Position: refs/branch-heads/2883@{#162}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/c13b91b536abd1fb4f09e19fceee985380407998/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Status: Fixed (was: Started)
Labels: Needs-Feedback
lgarron@ - Could you please provide repro steps, expected and actual behavior to test this issue.

Thanks...!!
Cc: krajshree@chromium.org
Components: UI>Browser>Omnibox>PageInfo
Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo
Cc: est...@chromium.org
 Issue 658743  has been merged into this issue.
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c13b91b536abd1fb4f09e19fceee985380407998

commit c13b91b536abd1fb4f09e19fceee985380407998
Author: Lucas Garron <lgarron@chromium.org>
Date: Mon Oct 17 22:58:00 2016

Fix wiring for Page Info buttons/links.

This also includes a partial revert of
crrev.com/0af7d0edfddd038461850cbc8957f1fba1686df9 to force proper sizing of the "Re-enable warnings" styled label.

BUG= 655872 

Review-Url: https://codereview.chromium.org/2422473002
Cr-Commit-Position: refs/heads/master@{#425401}
(cherry picked from commit 633c166bf730a58a847a6705c46ec08989a74db0)

Review URL: https://codereview.chromium.org/2429693002 .

Cr-Commit-Position: refs/branch-heads/2883@{#162}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/c13b91b536abd1fb4f09e19fceee985380407998/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Comment 15 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 16 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Components: -Security>UX
lgarron@ Please provide repro steps to verify this bug.
1) Open Page Info for google.com (Visit google.com, click on the security indicator icon on the left of the omnibox)
2) Click on the "X in use" link below "Cookies".
A cookie details dialog should open.

1) Visit expired.badssl.com and click through the warning (Advanced > Proceed...) to visit the page (red background)
2) Open Page Info
3) Click on "Re-enable warnings"
4) Refresh the page.
The SSL interstitial from step 1 should show again.

1) Open Page Info for google.com
2) Click on the "Site settings" button/link at the bottom.
chrome://settings/content should open in a new tab.


M55:
1) Open Page Info for google.com
2) Click on "Details"
3) The Security panel should open in DevTools

M56:
1) Open Page Info for google.com
2) Click on "Learn more"
3) The Chrome help center page titled "Check Chrome's connection to a site" should show in a new tab.
Status: Verified (was: Fixed)
Thank you very much for the detailed repro steps lgarron@

Verified on ChromeOS M55 (8872.70.0, 55.0.2883.87) & M56 (9000.21.0, 56.0.2924.19)

Sign in to add a comment