Page Info buttons/links are hooked up wrong in Views. |
|||||||||||||
Issue descriptione.g. "Re-enable warnings" opens DevTools.
,
Oct 14 2016
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/633c166bf730a58a847a6705c46ec08989a74db0 commit 633c166bf730a58a847a6705c46ec08989a74db0 Author: lgarron <lgarron@chromium.org> Date: Fri Oct 14 18:43:14 2016 Fix wiring for Page Info buttons/links. This also includes a partial revert of crrev.com/0af7d0edfddd038461850cbc8957f1fba1686df9 to force proper sizing of the "Re-enable warnings" styled label. BUG= 655872 Review-Url: https://codereview.chromium.org/2422473002 Cr-Commit-Position: refs/heads/master@{#425401} [modify] https://crrev.com/633c166bf730a58a847a6705c46ec08989a74db0/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
,
Oct 14 2016
,
Oct 17 2016
All buttons verified in Chrome 56.0.2891.0 on on Windows 10. Asking for a merge to M55.
,
Oct 17 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c13b91b536abd1fb4f09e19fceee985380407998 commit c13b91b536abd1fb4f09e19fceee985380407998 Author: Lucas Garron <lgarron@chromium.org> Date: Mon Oct 17 22:58:00 2016 Fix wiring for Page Info buttons/links. This also includes a partial revert of crrev.com/0af7d0edfddd038461850cbc8957f1fba1686df9 to force proper sizing of the "Re-enable warnings" styled label. BUG= 655872 Review-Url: https://codereview.chromium.org/2422473002 Cr-Commit-Position: refs/heads/master@{#425401} (cherry picked from commit 633c166bf730a58a847a6705c46ec08989a74db0) Review URL: https://codereview.chromium.org/2429693002 . Cr-Commit-Position: refs/branch-heads/2883@{#162} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/c13b91b536abd1fb4f09e19fceee985380407998/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
,
Oct 18 2016
,
Oct 18 2016
lgarron@ - Could you please provide repro steps, expected and actual behavior to test this issue. Thanks...!!
,
Oct 18 2016
,
Oct 19 2016
,
Oct 20 2016
,
Oct 26 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c13b91b536abd1fb4f09e19fceee985380407998 commit c13b91b536abd1fb4f09e19fceee985380407998 Author: Lucas Garron <lgarron@chromium.org> Date: Mon Oct 17 22:58:00 2016 Fix wiring for Page Info buttons/links. This also includes a partial revert of crrev.com/0af7d0edfddd038461850cbc8957f1fba1686df9 to force proper sizing of the "Re-enable warnings" styled label. BUG= 655872 Review-Url: https://codereview.chromium.org/2422473002 Cr-Commit-Position: refs/heads/master@{#425401} (cherry picked from commit 633c166bf730a58a847a6705c46ec08989a74db0) Review URL: https://codereview.chromium.org/2429693002 . Cr-Commit-Position: refs/branch-heads/2883@{#162} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/c13b91b536abd1fb4f09e19fceee985380407998/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 24 2016
,
Dec 7 2016
lgarron@ Please provide repro steps to verify this bug.
,
Dec 7 2016
1) Open Page Info for google.com (Visit google.com, click on the security indicator icon on the left of the omnibox) 2) Click on the "X in use" link below "Cookies". A cookie details dialog should open. 1) Visit expired.badssl.com and click through the warning (Advanced > Proceed...) to visit the page (red background) 2) Open Page Info 3) Click on "Re-enable warnings" 4) Refresh the page. The SSL interstitial from step 1 should show again. 1) Open Page Info for google.com 2) Click on the "Site settings" button/link at the bottom. chrome://settings/content should open in a new tab. M55: 1) Open Page Info for google.com 2) Click on "Details" 3) The Security panel should open in DevTools M56: 1) Open Page Info for google.com 2) Click on "Learn more" 3) The Chrome help center page titled "Check Chrome's connection to a site" should show in a new tab.
,
Dec 8 2016
Thank you very much for the detailed repro steps lgarron@ Verified on ChromeOS M55 (8872.70.0, 55.0.2883.87) & M56 (9000.21.0, 56.0.2924.19) |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by lgar...@chromium.org
, Oct 14 2016Labels: Hotlist-PageInfo OS-Chrome OS-Linux OS-Mac OS-Windows