New issue
Advanced search Search tips

Issue 655865 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

IDB Observers - make options per-observe call

Project Member Reported by dmu...@chromium.org, Oct 14 2016

Issue description

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b06152c63ff8df7b927a9ad7e5d13541aa377ea

commit 2b06152c63ff8df7b927a9ad7e5d13541aa377ea
Author: dmurph <dmurph@chromium.org>
Date: Wed Nov 09 00:06:06 2016

[IDBObservers] Moving options from constructor to .observe call.

Per spec change in
https://github.com/WICG/indexed-db-observers/commit/5aa4abc288ef526801797d3a9209ac0da8e359e7.

I'm also adding more exceptions here, as per
https://github.com/WICG/indexed-db-observers/commit/7723586ef6e5663739ae4800f1e6a7172296f67c.

R=cmumford
BUG= 655865 

Review-Url: https://codereview.chromium.org/2459113002
Cr-Commit-Position: refs/heads/master@{#430779}

[modify] https://crrev.com/2b06152c63ff8df7b927a9ad7e5d13541aa377ea/third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-tests.js
[modify] https://crrev.com/2b06152c63ff8df7b927a9ad7e5d13541aa377ea/third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer.js
[modify] https://crrev.com/2b06152c63ff8df7b927a9ad7e5d13541aa377ea/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp
[modify] https://crrev.com/2b06152c63ff8df7b927a9ad7e5d13541aa377ea/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
[modify] https://crrev.com/2b06152c63ff8df7b927a9ad7e5d13541aa377ea/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
[modify] https://crrev.com/2b06152c63ff8df7b927a9ad7e5d13541aa377ea/third_party/WebKit/Source/modules/indexeddb/IDBObserver.idl
[modify] https://crrev.com/2b06152c63ff8df7b927a9ad7e5d13541aa377ea/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.cpp
[modify] https://crrev.com/2b06152c63ff8df7b927a9ad7e5d13541aa377ea/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h

Status: Fixed (was: Started)

Sign in to add a comment