signing_unittest.py caught the error.  it's not run as part of preupload because it's way too slow -- it actually signs images.

i don't think we want to run the tests as part of the normal flow as the tests can take like 15 minutes on an unloaded system, and requires root access (to mount images and such).  adding a specific precq bot that we could list in the repo's COMMIT-QUEUE.ini should be fine though.

I'm trying to decide how to best run the tests.

How about a makefile or script in cros-signing, just so the builder doesn't have to have a hard coded list of tests to run?

adding a run_tests runner akin to chromite shouldn't be a problem.  the bigger question is how the bot runs.  i guess we create a new simple bot that just runs the code ?  we don't need a chroot or anything ...

Exactly what I was thinking. That's fairly easy to do now, and we have several of them.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/97176ab56c384ab61ded295bfb7e5f1ab7486ff1

commit 97176ab56c384ab61ded295bfb7e5f1ab7486ff1
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Oct 14 03:24:15 2016

Looks like the first part (run_tests runner) is done, I'll assign to Don for now the second part (how the bot runs).

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/6969a5227826d529b0b3ca1c7303de24efbad4d1

commit 6969a5227826d529b0b3ca1c7303de24efbad4d1
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Nov 02 20:22:57 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/6969a5227826d529b0b3ca1c7303de24efbad4d1

commit 6969a5227826d529b0b3ca1c7303de24efbad4d1
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Nov 02 20:22:57 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/736f764cafe4387915b6bbcbb0c3c08fd7d924eb

commit 736f764cafe4387915b6bbcbb0c3c08fd7d924eb
Author: Don Garrett <dgarrett@google.com>
Date: Sat Oct 15 02:19:19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/00ab44da049c4916b2386f3cdc7fe23c3f197faa

commit 00ab44da049c4916b2386f3cdc7fe23c3f197faa
Author: Don Garrett <dgarrett@google.com>
Date: Sat Oct 15 02:21:04 2016

signer-pre-cq: Create new signer unittests precq builder.

Create a new build config, build class, test stage, and test command all
dedicated to running the cros-signing unittests. After we test that this
builder works correctly, we can use it to verify signer changes via a
COMMIT-QUEUE.ini for that git repository.

CQ-DEPEND=CL:*297397
BUG= chromium:655849 
TEST=run_tests
     cbuildbot --buildbot --debug --nobootstrap --noreexec \
       --buildroot <dir> -g *297397 signer-pre-cq

Change-Id: I5e46f9b63d83338c502eb0be44c4108b22d2e6e2
Reviewed-on: https://chromium-review.googlesource.com/399583
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/00ab44da049c4916b2386f3cdc7fe23c3f197faa/cbuildbot/commands.py
[modify] https://crrev.com/00ab44da049c4916b2386f3cdc7fe23c3f197faa/cbuildbot/chromeos_config.py
[modify] https://crrev.com/00ab44da049c4916b2386f3cdc7fe23c3f197faa/cbuildbot/config_dump.json
[modify] https://crrev.com/00ab44da049c4916b2386f3cdc7fe23c3f197faa/cbuildbot/stages/test_stages.py
[modify] https://crrev.com/00ab44da049c4916b2386f3cdc7fe23c3f197faa/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/00ab44da049c4916b2386f3cdc7fe23c3f197faa/cbuildbot/builders/test_builders.py

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/f18b8cb313993421a2016189f293fa8b5ab0315b

commit f18b8cb313993421a2016189f293fa8b5ab0315b
Author: Don Garrett <dgarrett@google.com>
Date: Wed Nov 16 22:47:24 2016

We now test and submit signer CLs from the PreCQ.

thanks!