New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655841 link

Starred by 1 user
Status: Verified
Owner:
█ x...@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
m...@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Close tab doesn't end session when casting to Hendrix.

Project Member Reported by x...@chromium.org, Oct 13 2016 
This seems like a long standing issue. Reproed from M53.
Closing tab when casting to Chromecast device will trigger onEnded event for video track, and MR will stop audio track when receiving this event.
For audio only mirroring, when the tab is closed, no onEnded event is triggered, and session can't be stopped.

Comment 1 by sko...@chromium.org, Oct 14 2016

Labels: M-55
We should try to merge this back to M55 once we have a fix.

Comment 2 by x...@chromium.org, Oct 14 2016 

patch out for review: https://codereview.chromium.org/2416123002/

Comment 4 by x...@chromium.org, Oct 21 2016

Labels: Merge-Request-55
Status: Fixed (was: Started)

Comment 5 by x...@chromium.org, Oct 21 2016 

Requesting to merge to M55. Low risk.

Comment 6 by dimu@chromium.org, Oct 24 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 24 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cbe0b632a2359e04dc0908a884867faef5bd419

commit 6cbe0b632a2359e04dc0908a884867faef5bd419
Author: Yuri Wiitala <miu@chromium.org>
Date: Mon Oct 24 21:49:06 2016

Stop media stream source when audio capture error occurs. This is to ensure that session ends when closing the tab while audio is mirroring.

BUG= 655841 

Review-Url: https://chromiumcodereview.appspot.com/2416123002
Cr-Commit-Position: refs/heads/master@{#426400}
(cherry picked from commit 9d67562879f4cbddb2c1ddd08225310cea891490)

Review URL: https://codereview.chromium.org/2449563003 .

Cr-Commit-Position: refs/branch-heads/2883@{#264}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/external_media_stream_audio_source.cc
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/local_media_stream_audio_source.cc
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/media_stream_audio_source.cc
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/media_stream_audio_source.h
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/media_stream_audio_unittest.cc
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/speech_recognition_audio_sink_unittest.cc
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/webrtc/processed_local_audio_source.cc

Comment 8 by dbbrooks@chromium.org, Oct 25 2016 

Should this be fixed in Chrome version 56.0.2896.3? I can repro with it.

Comment 9 by x...@chromium.org, Oct 25 2016 

The fix is in 56.0.2897.0 or later, or 55.0.2883.25 or later for M55.

Comment 10 by dbbrooks@chromium.org, Oct 26 2016

Status: Verified (was: Fixed)
I just verified that closing tab ends session to Cast audio device in 56.0.2901.0.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cbe0b632a2359e04dc0908a884867faef5bd419

commit 6cbe0b632a2359e04dc0908a884867faef5bd419
Author: Yuri Wiitala <miu@chromium.org>
Date: Mon Oct 24 21:49:06 2016

Stop media stream source when audio capture error occurs. This is to ensure that session ends when closing the tab while audio is mirroring.

BUG= 655841 

Review-Url: https://chromiumcodereview.appspot.com/2416123002
Cr-Commit-Position: refs/heads/master@{#426400}
(cherry picked from commit 9d67562879f4cbddb2c1ddd08225310cea891490)

Review URL: https://codereview.chromium.org/2449563003 .

Cr-Commit-Position: refs/branch-heads/2883@{#264}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/external_media_stream_audio_source.cc
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/local_media_stream_audio_source.cc
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/media_stream_audio_source.cc
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/media_stream_audio_source.h
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/media_stream_audio_unittest.cc
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/speech_recognition_audio_sink_unittest.cc
[modify] https://crrev.com/6cbe0b632a2359e04dc0908a884867faef5bd419/content/renderer/media/webrtc/processed_local_audio_source.cc

Comment 12 by dimu@google.com, Nov 4 2016 

[Automated comment] removing mislabelled merge-merged-2840

Comment 13 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment