[payments] Contact row on bottomsheet: place phone number and email in a single line |
||||||
Issue description
,
Oct 14 2016
Correct. Thanks gogerald@!
,
Oct 14 2016
,
Oct 14 2016
Here is the result: 1.png is the initial display of a payment request. 2.png is the screen after clicking payment row to expand to full screen. Note that shipping address row was shorten to one single row. 3.png is the screen after clicking shipping address row. 4.png, 5.png, and 6.png are the screens with contact information. What do you think hwi@?
,
Oct 14 2016
Fast! Thanks! 1. Bottomsheet(1,4) and clicked views with radio buttons: correct 2. Fullsheet non clicked view: Only meant to apply the change to the *bottomsheet* (1 and 4). On *fullsheet*, showing them on *multi* line is intended since it is easier to scroll vertically. Apologies, I was unclear on comment#2.
,
Nov 18 2016
,
Nov 18 2016
UI looks good, thanks.
,
Nov 18 2016
lgtm - thanks! ☕
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3458e46a4da95a4cb769a61908af8772b9fc3a8c commit 3458e46a4da95a4cb769a61908af8772b9fc3a8c Author: gogerald <gogerald@chromium.org> Date: Fri Nov 18 21:00:19 2016 Display payment method and contact summary in a single line in bottom sheet BUG= 655823 , 655822 Review-Url: https://codereview.chromium.org/2514693002 Cr-Commit-Position: refs/heads/master@{#433296} [modify] https://crrev.com/3458e46a4da95a4cb769a61908af8772b9fc3a8c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/3458e46a4da95a4cb769a61908af8772b9fc3a8c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/3458e46a4da95a4cb769a61908af8772b9fc3a8c/components/autofill_strings.grdp
,
Feb 6 2017
,
Jun 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by gogerald@chromium.org
, Oct 14 2016