New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655807 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Crash in blink::LinkStyle::setCSSStyleSheet

Project Member Reported by ClusterFuzz, Oct 13 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5742867844956160

Fuzzer: inferno_webbot
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: UNKNOWN
Crash Address: 0x00000007
Crash State:
  blink::LinkStyle::setCSSStyleSheet
  blink::CSSStyleSheetResource::checkNotify
  blink::Resource::finish
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_syzyasan_chrome&range=424963:424978

Minimized Testcase (0.06 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv97NJdwvG2pHtIZ0QjS4Wc6Y8z0QKjfxqlxLPirn7B1eYlMJoWqLo_MHMk4I6q08jiM9S1u7cQB-LkRRGFWAGUquTqbyXAoGh2EcgkISzo4iOh4CA9cBexonUOBslyFAehYBZnWiBmwalJfoNLZmQbb3yH09Ow?testcase_id=5742867844956160
<script>
window.location = "http://alabamaoutdoors.com";</script>


Issue manually filed by: mummareddy

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tools>Test>FindIt>WrongResult Blink>CSS
Labels: M-56 Te-Logged
Owner: kouhei@chromium.org
Status: Assigned (was: Untriaged)
Suspected CL through code search on file CSSStyleSheetResource.cpp
https://chromium.googlesource.com/chromium/src/+/afa48c3ed31f7229c306ce7cda62111be593f719

kouhei@, could you please take a look and reassign if it is not related your changes.

Comment 2 by kouhei@chromium.org, Oct 14 2016

Status: Started (was: Assigned)

Comment 3 by kouhei@chromium.org, Oct 17 2016

Cc: mummare...@chromium.org kouhei@chromium.org csharrison@chromium.org
 Issue 655812  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b89d127027ca441b6abfcde56aee65add6423ca

commit 3b89d127027ca441b6abfcde56aee65add6423ca
Author: kouhei <kouhei@chromium.org>
Date: Mon Oct 17 02:41:50 2016

Fix LinkStyle SRI check when against 0 sized resource.

Before this CL, SRI check in LinkStyle::setCSSStyleSheet assumed that
the target CSS resource had >0 size.

However, it is possible that the CSS size is 0.
This CL removes the assert that assumed resourceBuffer() != nullptr,
which isn't true when the CSS empty.
In addition, this CL also ensures SRI check on empty CSS resource,
which doesn't affect user visible behaviour, but needed to emit SRI
verification failure messages.

Test by csharrison@chromium.org
BUG= 655807 

Review-Url: https://codereview.chromium.org/2418083002
Cr-Commit-Position: refs/heads/master@{#425611}

[add] https://crrev.com/3b89d127027ca441b6abfcde56aee65add6423ca/third_party/WebKit/LayoutTests/fast/loader/sri-with-empty-response.html
[add] https://crrev.com/3b89d127027ca441b6abfcde56aee65add6423ca/third_party/WebKit/LayoutTests/resources/empty.css
[modify] https://crrev.com/3b89d127027ca441b6abfcde56aee65add6423ca/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

Project Member

Comment 5 by ClusterFuzz, Oct 18 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Components: -Tools>Test>FindIt>WrongResult
Labels: Test-Predator-Wrong
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment