New issue
Advanced search Search tips

Issue 655798 link

Starred by 0 users
Status: Available
Owner: ----
Cc:
qyears...@chromium.org
dpranke@chromium.org
iannu...@google.com
pfeldman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clean-up: Scripts in build repo take ignored parameter --build-dir.

Project Member Reported by qyears...@chromium.org, Oct 13 2016 
There are a collection of scripts in the build repo, mostly in build/scripts/slave/chromium/ that take an option --build-dir which is ignored.

Originally, before November 2013, the value passed in as --build-dir was used and passed to build_directory.ConvertBuildDirToLegacy.

Then, iannucci@ made a CL to change rename ConvertBuildDirToLegacy (which didn't use the input build_dir anyway) to GetBuildOutputDirectory, and that CL also removed the unused parameters.

That change didn't stick and appeared to cause failures, but later pfeldman relanded most of it.

See: https://cs.chromium.org/search/?q="build-dir"

Since those --build-dir parameters have been unused for a few years, I'm pretty sure they could be removed.

Although, in http://crrev.com/2420543002, dpranke@ notes that GetBuildOutputDirectory makes some assumptions: it assumes that the build dir is src/out (or in some cases, it may be src/xcodebuild or src/build or src/out_<cros-board>.

If these assumptions seem safe, then the easiest thing to do is to remove all the ignored --build-dir parameters; otherwise, we could change things to have the passed in values of --build-dir actually used.

Comment 1 by dpranke@chromium.org, Oct 13 2016 

The fewer places things are hardcoded, the better.

Comment 2 by qyears...@chromium.org, Oct 13 2016 

So, in general, passing things in as parameters is better than relying on the build dir being in some constant place like "src/out"?

There is an advantage to relying on functions that return hard-coded values returned by functions like GetBuildOutputDirectory, which is that it'd be less argument to take as input to a script, but maybe having extra options is less of a cost than the potential cost of having to update everything if the build dir might ever be in some other place?

Comment 3 by qyears...@chromium.org, Oct 13 2016 

* ... which is that it would be one less argument to take as input ...

Also, additional note: There's also a nice advantage of taking --build-dir as an input, since then one doesn't need to depend on build_directory.GetBuildOutputDirectory.

Comment 4 by qyears...@chromium.org, Oct 13 2016

Summary: Clean-up: Scripts in build repo take ignored parameter --build-dir. (was: Clean-up: Remove ignored parameter --build-dir in scripts in build repo.)

Comment 5 by dpranke@chromium.org, Oct 13 2016 

Re: comments 2 and 3: your reasoning is correct :).
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/072fdd58f2070edbb909079ff8523ce6a38c8d65

commit 072fdd58f2070edbb909079ff8523ce6a38c8d65
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Oct 14 00:21:45 2016

Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py.

BUG=655798

Review-Url: https://codereview.chromium.org/2420543002

[modify] https://crrev.com/072fdd58f2070edbb909079ff8523ce6a38c8d65/scripts/slave/chromium/archive_layout_test_results.py
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/8b835e3620ac1705a57b75f0f2ccc4afadef8f5d

commit 8b835e3620ac1705a57b75f0f2ccc4afadef8f5d
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Oct 14 02:25:38 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/072fdd58f2070edbb909079ff8523ce6a38c8d65 Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py. (qyearsley@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=655798

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2415283002

[modify] https://crrev.com/8b835e3620ac1705a57b75f0f2ccc4afadef8f5d/infra/config/recipes.cfg
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/c145d9bf6bf6d333036c6b66f3fa58089b1e12ad

commit c145d9bf6bf6d333036c6b66f3fa58089b1e12ad
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Oct 14 18:18:14 2016

Revert of Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py. (patchset #4 id:60001 of https://codereview.chromium.org/2420543002/ )

Reason for revert:
I think this could have possibly caused  http://crbug.com/656063 , so speculatively reverting

Original issue's description:
> Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py.
>
> BUG=655798
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/072fdd58f2070edbb909079ff8523ce6a38c8d65

TBR=dpranke@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=655798

Review-Url: https://codereview.chromium.org/2419133002

[modify] https://crrev.com/c145d9bf6bf6d333036c6b66f3fa58089b1e12ad/scripts/slave/chromium/archive_layout_test_results.py
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/445e4651977fa83f88ed6101366fb69d0aee4177

commit 445e4651977fa83f88ed6101366fb69d0aee4177
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Oct 14 18:35:50 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/c145d9bf6bf6d333036c6b66f3fa58089b1e12ad Revert of Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py. (patchset #4 id:60001 of https://codereview.chromium.org/2420543002/ ) (qyearsley@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=655798

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2420153002

[modify] https://crrev.com/445e4651977fa83f88ed6101366fb69d0aee4177/infra/config/recipes.cfg
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24731848f0e937f7a705c474290c74c91f24d063

commit 24731848f0e937f7a705c474290c74c91f24d063
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Oct 14 18:34:46 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/c145d9bf6bf6d333036c6b66f3fa58089b1e12ad Revert of Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py. (patchset #4 id:60001 of https://codereview.chromium.org/2420543002/ ) (qyearsley@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=655798

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2421893003
Cr-Commit-Position: refs/heads/master@{#425396}

[modify] https://crrev.com/24731848f0e937f7a705c474290c74c91f24d063/infra/config/recipes.cfg
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/e22f92fea14cffb851511b3bf1417c92f22336ad

commit e22f92fea14cffb851511b3bf1417c92f22336ad
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Oct 14 21:41:49 2016

Comment 12 by benhenry@google.com, Oct 16 2016

Components: -Infra Infra>SDK
Labels: -Pri-3 Pri-2
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 17 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by aga...@chromium.org, Nov 2 2017

Components: -Infra>SDK Infra>Client>Chrome
Labels: -Hotlist-Recharge-Cold
Owner: qyears...@chromium.org
Status: Started (was: Untriaged)
Assigning back to qyearsley to answer the question "is the work complete?"

Comment 15 by qyears...@chromium.org, Nov 2 2017 

Nope -- there are still lots of scripts that take and ignore --build-dir in build/scripts/slave:

https://cs.chromium.org/search/?q=%22--build-dir%22+file:%5Ebuild/scripts/slave/chromium/+package:%5Echromium$&type=cs

We can certainly go ahead and try to remove some/all again! First step is to remove usage of --build-dir, e.g. in these:
https://cs.chromium.org/search/?q=%22+%27--build-dir%27,%22+file:%5Ebuild/scripts+package:%5Echromium$&type=cs
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8a322e20b931786ce7748b17b73e3dde7aadd761

commit 8a322e20b931786ce7748b17b73e3dde7aadd761
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Tue Nov 28 16:15:36 2017

Remove --build-dir argument from archive_layout_test_results invocation

The --build-dir argument is ignored if passed in. Not passing it is one part
of removing it in this place and other similar places.

Bug: 655798
Change-Id: I5da73ed42e5d2c575e5e04745edc721105d95cb5
Reviewed-on: https://chromium-review.googlesource.com/791865
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/webkit_tests_interrupted.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_that_fails.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_minimal_pass_continues.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/android.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_win.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/unexpected_flakes.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_with_and_without_patch_fail.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/chromium_trybot.expected/add_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_fail.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/win.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_linux.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_compile_without_patch_fails.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_unexpected_error.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/big.json
[modify] https://crrev.com/8a322e20b931786ce7748b17b73e3dde7aadd761/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

Comment 17 by qyears...@chromium.org, Nov 28 2017 

Some scripts that require a --build-dir arg:
  src/build/find_isolated_tests.py
    used by build/scripts/slave/recipe_modules/isolate/api.py
  src/build/win/merge_pgc_files.py
  src/build/win/run_pgo_profiling_benchmarks.py
  src/tools/determinism/remove_build_metadata.py
  build/scripts/slave/recipe_modules/v8/resources/build-dep-stats.py
  Possibly some others.

Some scripts that ignore a --build-dir arg:

  build/scripts/slave/extract_build.py
  build/scripts/slave/process_dumps.py
  build/scripts/slave/runtest.py
  build/scripts/slave/zip_build.py
  build/scripts/slave/extract_dynamorio_build.py
  build/scripts/slave/generate_profile_shim.py
  build/scripts/slave/archive_profiling_data.py
  build/scripts/slave/chromium/asan_archive_build.py
  build/scripts/slave/chromium/dynamorio_coverage.py
  build/scripts/slave/chromium/process_coverage.py
  build/scripts/slave/chromium/archive_coverage.py
  build/scripts/slave/chromium/sizes.py
  build/scripts/slave/chromium/lint_test_files_wrapper.py

Note, some of these script names are found in build/scripts/master/factory/commands.py, but I didn't see anywhere that uses that commands module that passes --build-dir. For most of these scripts, the ignored --build-dir arg could just be directly removed now.
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/695fa77d27cced6fb1a63315776e43e549326f0c

commit 695fa77d27cced6fb1a63315776e43e549326f0c
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Dec 06 19:32:01 2017

Revert "Remove --build-dir argument from archive_layout_test_results invocation"

This reverts commit 8a322e20b931786ce7748b17b73e3dde7aadd761.

Reason for revert: As noted in a later change, this was actually not what we wanted to do according to the logic in crbug.com/655798 -- instead we would want to, in general, pass in --build-dir and not ignore the argument.

Original change's description:
> Remove --build-dir argument from archive_layout_test_results invocation
> 
> The --build-dir argument is ignored if passed in. Not passing it is one part
> of removing it in this place and other similar places.
> 
> Bug: 655798
> Change-Id: I5da73ed42e5d2c575e5e04745edc721105d95cb5
> Reviewed-on: https://chromium-review.googlesource.com/791865
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

TBR=qyearsley@chromium.org,dpranke@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 655798
Change-Id: Ieb8187e2b6295e4a62ad6023fbe039abd6d7022d
Reviewed-on: https://chromium-review.googlesource.com/811764
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/webkit_tests_interrupted.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_that_fails.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_minimal_pass_continues.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/android.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_win.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/unexpected_flakes.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_with_and_without_patch_fail.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/chromium_trybot.expected/add_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_fail.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/win.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_linux.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_compile_without_patch_fails.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_unexpected_error.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipe_modules/chromium_tests/tests/steps/blink_test.expected/big.json
[modify] https://crrev.com/695fa77d27cced6fb1a63315776e43e549326f0c/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

Comment 19 by qyears...@chromium.org, Dec 22 2017

Cc: qyears...@chromium.org
Owner: ----
Status: Available (was: Started)

Comment 20 by iannu...@google.com, Oct 19

Cc: -iannucci@chromium.org iannu...@google.com
►

Sign in to add a comment