Checkbox disappears when safe browsing interstitial is reloaded |
||||
Issue descriptionVersion: At least 53.0.2785.143 (stable) and 55.0.2883.11 (dev) OS: Linux What steps will reproduce the problem? * Visit http://testsafebrowsing.appspot.com/, click the first phishing link * Note the extended-reporting checkbox shows. * Hit reload, and it disappears What is the expected output? Checkbox should remain
,
Oct 13 2016
Bisect result: You are probably looking for a change made after 366187 (known good), but no later than 366203 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/f2c63b1954b5683b65ce3760d64a3c4db4c8c352..ee0fb4ddd63628f501863401af0976b3047ba1a5 mattm: https://codereview.chromium.org/1509073002 looks the most likely CL in that range. Can you please take a look?
,
Nov 4 2016
mattm -- Can you take a look? If not let me know and I'll reassign.
,
Nov 17 2016
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3294450834f7ae8978994a8d2f7f9dd1df3178f2 commit 3294450834f7ae8978994a8d2f7f9dd1df3178f2 Author: mattm <mattm@chromium.org> Date: Wed Nov 30 22:23:39 2016 If replacing a safebrowsing interstitial, don't call DontProceed on the old one. Calling DontProceed directly has some side effects like destroying the pending NavigationEntry. There is already common code in InterstitialPageImpl::Show to handle closing an existing interstitial when showing a new one, and it properly handles the pending NavigationEntry. BUG= 655794 Review-Url: https://codereview.chromium.org/2510003002 Cr-Commit-Position: refs/heads/master@{#435445} [modify] https://crrev.com/3294450834f7ae8978994a8d2f7f9dd1df3178f2/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc [modify] https://crrev.com/3294450834f7ae8978994a8d2f7f9dd1df3178f2/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
,
Nov 30 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nparker@chromium.org
, Oct 13 2016