New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 655778 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"unit_tests (with patch)" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Oct 13 2016

Issue description

"unit_tests (with patch)" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyIgsSBUZsYWtlIhd1bml0X3Rlc3RzICh3aXRoIHBhdGNoKQw.



This flaky test/step was previously tracked in  issue 628217 .
 
Cc: kulshin@chromium.org
Labels: -Sheriff-Chromium
Owner: dim...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/922b86e7520d4d9a8795d9458f4e6be939c434bf

commit 922b86e7520d4d9a8795d9458f4e6be939c434bf
Author: dimich <dimich@chromium.org>
Date: Fri Oct 14 01:00:32 2016

Temporary disable of the new test because it is flaky.

BUG= 655778 

Review-Url: https://codereview.chromium.org/2416453007
Cr-Commit-Position: refs/heads/master@{#425222}

[modify] https://crrev.com/922b86e7520d4d9a8795d9458f4e6be939c434bf/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

Comment 4 by dim...@chromium.org, Oct 14 2016

Status: Started (was: Assigned)
Cc: -kulshin@chromium.org
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Oct 14 2016

Detected 16 new flakes for test/step "unit_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyIgsSBUZsYWtlIhd1bml0X3Rlc3RzICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app.

Comment 7 by dim...@chromium.org, Oct 14 2016

Labels: Merge-Rejected-55
Requesting merge to M55 to avoid flakiness in branch tests.
This is a trivial change in a test file, so should be easy.
Labels: -Merge-Rejected-55 Merge-Request-55
Corrected label :-)

Comment 9 by dimu@chromium.org, Oct 19 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 23 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 24 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3d72cd89fe50f16f66892d2a0efec0450473b15

commit c3d72cd89fe50f16f66892d2a0efec0450473b15
Author: Dmitry Titov <dimich@chromium.org>
Date: Mon Oct 24 19:49:59 2016

Temporary disable of the new test because it is flaky.

BUG= 655778 

Review-Url: https://codereview.chromium.org/2416453007
Cr-Commit-Position: refs/heads/master@{#425222}
(cherry picked from commit 922b86e7520d4d9a8795d9458f4e6be939c434bf)

Review URL: https://codereview.chromium.org/2450523002 .

Cr-Commit-Position: refs/branch-heads/2883@{#252}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/c3d72cd89fe50f16f66892d2a0efec0450473b15/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

Status: Fixed (was: Started)
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3d72cd89fe50f16f66892d2a0efec0450473b15

commit c3d72cd89fe50f16f66892d2a0efec0450473b15
Author: Dmitry Titov <dimich@chromium.org>
Date: Mon Oct 24 19:49:59 2016

Temporary disable of the new test because it is flaky.

BUG= 655778 

Review-Url: https://codereview.chromium.org/2416453007
Cr-Commit-Position: refs/heads/master@{#425222}
(cherry picked from commit 922b86e7520d4d9a8795d9458f4e6be939c434bf)

Review URL: https://codereview.chromium.org/2450523002 .

Cr-Commit-Position: refs/branch-heads/2883@{#252}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/c3d72cd89fe50f16f66892d2a0efec0450473b15/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

Comment 14 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 15 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment