New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 655755 link

Starred by 1 user
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Jan 2017
Cc:
█ sbc@chromium.org
thestig@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 430105



Sign in to add a comment

Unbundle dpkg-dev once build infrastructure is entirely off of Precise

Project Member Reported by thomasanderson@chromium.org, Oct 13 2016 
dpkg-dev was added to third_party in CL:
https://codereview.chromium.org/2411423002/

The version of the utility to calculate Debian dependencies, dpkg-shlibdeps, was too old on Precise to support the feature we needed for using the sysroot to calculate dependencies (specifically, the "-l" option was needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev should be removed once the builders are entirely switch off of Precise.

This can be done by reverting the above CL and applying ps40001.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e6c4d244253b5a5339a97fc9d8a5bfb3d7aa127

commit 6e6c4d244253b5a5339a97fc9d8a5bfb3d7aa127
Author: thomasanderson <thomasanderson@google.com>
Date: Fri Jan 27 20:15:33 2017

Unbundle dpkg-shlibdeps

Now that all official builders have been upgraded to trusty, we can
remove dpkg-dev from third-party.

BUG= 655755 
R=jochen@chromium.org,phajdan.jr@chromium.org
CC=dpranke@chromium.org,sbc@chromium.org,thestig@chromium.org

Review-Url: https://codereview.chromium.org/2662493002
Cr-Commit-Position: refs/heads/master@{#446746}

[modify] https://crrev.com/6e6c4d244253b5a5339a97fc9d8a5bfb3d7aa127/chrome/installer/linux/BUILD.gn
[modify] https://crrev.com/6e6c4d244253b5a5339a97fc9d8a5bfb3d7aa127/chrome/installer/linux/debian/build.sh
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/LICENSE
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/OWNERS
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/README.chromium
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/abitable
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/cputable
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/ostable
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Arch.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/BuildEnv.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/BuildFlags.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/BuildOptions.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/BuildProfiles.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Changelog.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Changelog/Debian.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Changelog/Entry.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Changelog/Entry/Debian.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Changelog/Parse.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Checksums.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Compression.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Compression/FileHandle.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Compression/Process.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Conf.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Control.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Control/Changelog.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Control/Fields.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Control/FieldsCore.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Control/Hash.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Control/HashCore.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Control/Info.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Control/Types.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Deps.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/ErrorHandling.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Exit.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/File.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Gettext.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/IPC.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Index.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Interface/Storable.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Package.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Path.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Shlibs.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Shlibs/Cppfilt.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Shlibs/Objdump.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Shlibs/Symbol.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Shlibs/SymbolFile.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Archive.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Functions.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Package.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Package/V1.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Package/V2.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Package/V3/Bzr.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Package/V3/Custom.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Package/V3/Git.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Package/V3/Native.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Package/V3/Quilt.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Patch.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Source/Quilt.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Substvars.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Util.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Vars.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Vendor.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Vendor/Debian.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Vendor/Default.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Vendor/Ubuntu.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/Dpkg/Version.pm
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/scripts/dpkg-shlibdeps.pl
[delete] https://crrev.com/0b00ee46de806f080c6780e6434762ea07bba876/third_party/dpkg-dev/triplettable
[modify] https://crrev.com/6e6c4d244253b5a5339a97fc9d8a5bfb3d7aa127/tools/checklicenses/checklicenses.py

Comment 2 by thomasanderson@chromium.org, Jan 27 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment