New issue
Advanced search Search tips

Issue 655749 link

Starred by 1 user
Status: Fixed
Owner:
rajendrant@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Majority of the DataUse bytes are not tagged with the service

Project Member Reported by tbansal@chromium.org, Oct 13 2016 
Looking at the histograms, it seems that typically sum of samples in DataUse.MessageSize.NotTagged histogram is more than 50% of the sum of samples in DataUse.TrafficSize.System.Downstream.Foreground.NotCellular. That means at least 50% of the data used by services is unaccounted for.

We should add TAGS for all services, and in future add a DCHECK to ensure that   all services attach the TAG when creating a  network fetcher.

Comment 1 by rajendrant@chromium.org, Oct 14 2016 

https://codereview.chromium.org/2375773002/ covers more services.

Comment 2 by bengr@chromium.org, Oct 28 2016

Labels: -Pri-3 M-56 Pri-2
Owner: rajendrant@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9

commit 2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9
Author: rajendrant <rajendrant@chromium.org>
Date: Thu Nov 17 21:29:29 2016

Add data usage tracking for cloud print, update client service and search provide logos

BUG= 655749 

Review-Url: https://codereview.chromium.org/2491733002
Cr-Commit-Position: refs/heads/master@{#432963}

[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/chrome/browser/printing/cloud_print/gcd_api_flow_impl.cc
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/chrome/browser/printing/cloud_print/privet_url_fetcher.cc
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/chrome/service/BUILD.gn
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/chrome/service/DEPS
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/chrome/service/cloud_print/cloud_print_url_fetcher.cc
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/components/data_use_measurement/core/data_use_user_data.cc
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/components/data_use_measurement/core/data_use_user_data.h
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/components/search_provider_logos/BUILD.gn
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/components/search_provider_logos/DEPS
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/components/search_provider_logos/logo_tracker.cc
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/components/update_client/BUILD.gn
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/components/update_client/DEPS
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/components/update_client/url_fetcher_downloader.cc
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/components/update_client/utils.cc
[modify] https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/261e942a33a7be65253c33398c1b91db36f396c4

commit 261e942a33a7be65253c33398c1b91db36f396c4
Author: rajendrant <rajendrant@chromium.org>
Date: Thu Dec 01 20:59:56 2016

Add data usage tracking for sync service

BUG= 655749 

Review-Url: https://codereview.chromium.org/2539063003
Cr-Commit-Position: refs/heads/master@{#435708}

[modify] https://crrev.com/261e942a33a7be65253c33398c1b91db36f396c4/components/sync/driver/sync_stopped_reporter.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfee22ef3c7c2749538912889b26c1142530a122

commit bfee22ef3c7c2749538912889b26c1142530a122
Author: rajendrant <rajendrant@chromium.org>
Date: Fri Jan 20 20:34:17 2017

Add data usage tracking for chrome services

Add data usage tracking for GCM driver, web history and network time tracker services

BUG= 655749 

Review-Url: https://codereview.chromium.org/2641293002
Cr-Commit-Position: refs/heads/master@{#445148}

[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/data_use_measurement/core/data_use_user_data.cc
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/data_use_measurement/core/data_use_user_data.h
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/gcm_driver/BUILD.gn
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/gcm_driver/DEPS
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/gcm_driver/gcm_channel_status_request.cc
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/history/core/browser/BUILD.gn
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/history/core/browser/DEPS
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/history/core/browser/web_history_service.cc
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/network_time/BUILD.gn
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/network_time/DEPS
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/components/network_time/network_time_tracker.cc
[modify] https://crrev.com/bfee22ef3c7c2749538912889b26c1142530a122/tools/metrics/histograms/histograms.xml
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/937e6ddb752843acbff843c01fabb29518f3aba5

commit 937e6ddb752843acbff843c01fabb29518f3aba5
Author: rajendrant <rajendrant@chromium.org>
Date: Sat Jan 21 01:50:28 2017

Add data usage tracking for supervised_user service

BUG= 655749 

Review-Url: https://codereview.chromium.org/2644223003
Cr-Commit-Position: refs/heads/master@{#445247}

[modify] https://crrev.com/937e6ddb752843acbff843c01fabb29518f3aba5/chrome/browser/supervised_user/DEPS
[modify] https://crrev.com/937e6ddb752843acbff843c01fabb29518f3aba5/chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc
[modify] https://crrev.com/937e6ddb752843acbff843c01fabb29518f3aba5/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc
[modify] https://crrev.com/937e6ddb752843acbff843c01fabb29518f3aba5/chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc
[modify] https://crrev.com/937e6ddb752843acbff843c01fabb29518f3aba5/chrome/browser/supervised_user/legacy/supervised_user_refresh_token_fetcher.cc
[modify] https://crrev.com/937e6ddb752843acbff843c01fabb29518f3aba5/components/data_use_measurement/core/data_use_user_data.cc
[modify] https://crrev.com/937e6ddb752843acbff843c01fabb29518f3aba5/components/data_use_measurement/core/data_use_user_data.h
[modify] https://crrev.com/937e6ddb752843acbff843c01fabb29518f3aba5/tools/metrics/histograms/histograms.xml
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a66ce0054bc03e4a8e787871bdf29a38e3e528d3

commit a66ce0054bc03e4a8e787871bdf29a38e3e528d3
Author: rajendrant <rajendrant@chromium.org>
Date: Tue Jan 24 03:23:09 2017

Add data usage tracking for GAIA auth api

BUG= 655749 

Review-Url: https://codereview.chromium.org/2575603002
Cr-Commit-Position: refs/heads/master@{#445626}

[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/components/data_use_measurement/core/BUILD.gn
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/components/data_use_measurement/core/DEPS
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/components/data_use_measurement/core/data_use_measurement.cc
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/components/data_use_measurement/core/data_use_user_data.cc
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/components/data_use_measurement/core/data_use_user_data.h
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/google_apis/gaia/gaia_auth_fetcher.cc
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/google_apis/gaia/gaia_auth_util.cc
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/google_apis/gaia/gaia_auth_util.h
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/google_apis/gaia/gaia_oauth_client.cc
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/google_apis/gaia/oauth2_access_token_fetcher_impl.cc
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/google_apis/gaia/oauth2_api_call_flow.cc
[modify] https://crrev.com/a66ce0054bc03e4a8e787871bdf29a38e3e528d3/tools/metrics/histograms/histograms.xml
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a81c185f34b34ef8410239506825b185b332c00b

commit a81c185f34b34ef8410239506825b185b332c00b
Author: rajendrant <rajendrant@chromium.org>
Date: Tue Jan 24 21:13:44 2017

Add data usage tracking for chrome services

Add data usage tracking for captive portal, web resource and signin services

BUG= 655749 

Review-Url: https://codereview.chromium.org/2643013004
Cr-Commit-Position: refs/heads/master@{#445810}

[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/captive_portal/BUILD.gn
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/captive_portal/DEPS
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/captive_portal/captive_portal_detector.cc
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/data_use_measurement/core/data_use_user_data.cc
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/data_use_measurement/core/data_use_user_data.h
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/signin/core/browser/BUILD.gn
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/signin/core/browser/DEPS
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/signin/core/browser/gaia_cookie_manager_service.cc
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/web_resource/BUILD.gn
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/web_resource/DEPS
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/components/web_resource/web_resource_service.cc
[modify] https://crrev.com/a81c185f34b34ef8410239506825b185b332c00b/tools/metrics/histograms/histograms.xml

Comment 11 by bengr@chromium.org, May 5 2017 

Raj, what's the status? Is all service traffic tagged?

Comment 12 by bengr@chromium.org, Nov 8 2017 

Raj, what's the status? Is all service traffic tagged?

Comment 13 by rajendrant@chromium.org, Nov 9 2017 

This bug is a work in progress.
I am closing this bug and opening another P3 bug.

Comment 14 by rajendrant@chromium.org, Nov 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment