MD Settings: page zoom is wonky (ghost zoom levels cuz rounding, not observing changes, etc.) |
||||
Issue descriptionIn the old Options, when the user sets the value of 33% in the dropdown, we were actually setting the zoom to 33.333333. This is not the case in the new settings (see comparison at [1] and [2]), where we only set the zoom percentage to integer values, and have also designed the chrome.setttingPrivate.setDefaultZoomPercent to accept integers only, see [3]. Preserving old Options requires changes in chrome.settingsPrivate.setDefaultZoompPercent API itself (needs to allow setting a non-integer value) as well as adding a way to dynamically populate the zoom dropdown values instead of hardcoding them, similar to https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/options/browser_options_handler.cc?l=2068. [1] http://imgur.com/a/0Vxjj [2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/appearance_page/appearance_page.js?l=81-98 [3] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/settings_private/settings_private_delegate.cc?dr&q=settings_private_delegate.cc&l=69
,
Oct 15 2016
,
Oct 15 2016
,
Oct 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c1d68f185e5651164542cb6dd1c6ec9548ec1b1 commit 0c1d68f185e5651164542cb6dd1c6ec9548ec1b1 Author: dbeam <dbeam@chromium.org> Date: Sat Oct 15 19:07:44 2016 MD Settings: handle zoom as floats to fix ghost zoom level issue R=dpapad@chromium.org TBR=rdevlin.cronin@chromium.org BUG= 655742 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2422603003 Cr-Commit-Position: refs/heads/master@{#425569} [modify] https://crrev.com/0c1d68f185e5651164542cb6dd1c6ec9548ec1b1/chrome/browser/extensions/api/settings_private/settings_private_delegate.cc [modify] https://crrev.com/0c1d68f185e5651164542cb6dd1c6ec9548ec1b1/chrome/browser/extensions/api/settings_private/settings_private_delegate.h [modify] https://crrev.com/0c1d68f185e5651164542cb6dd1c6ec9548ec1b1/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/0c1d68f185e5651164542cb6dd1c6ec9548ec1b1/chrome/browser/resources/settings/appearance_page/appearance_page.js [modify] https://crrev.com/0c1d68f185e5651164542cb6dd1c6ec9548ec1b1/chrome/common/extensions/api/settings_private.idl
,
Oct 15 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dbeam@chromium.org
, Oct 14 2016Labels: -Pri-2 Pri-3